You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "klevy-toast (via GitHub)" <gi...@apache.org> on 2023/05/24 22:21:05 UTC
[GitHub] [pulsar] klevy-toast commented on a diff in pull request #20239: [feat][client] PIP-253 Expose ProducerStats for DeadLetter and RetryLetter producers in ConsumerStats
klevy-toast commented on code in PR #20239:
URL: https://github.com/apache/pulsar/pull/20239#discussion_r1204813512
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleProducerConsumerStatTest.java:
##########
@@ -561,4 +561,133 @@ public void testMsgRateExpired() throws Exception {
log.info("-- Exiting {} test --", methodName);
}
+
+ @Test
+ public void testRetryLetterAndDeadLetterStats() throws PulsarClientException, InterruptedException {
+ final String topicName = "persistent://my-property/my-ns/testRetryLetterAndDeadLetterStats";
+
+ Consumer<byte[]> consumer = pulsarClient.newConsumer()
+ .topic(topicName)
+ .subscriptionType(SubscriptionType.Shared)
+ .negativeAckRedeliveryDelay(100, TimeUnit.MILLISECONDS)
+ .enableRetry(true)
+ .deadLetterPolicy(DeadLetterPolicy.builder()
+ .maxRedeliverCount(3)
+ .retryLetterTopic("persistent://my-property/my-ns/retry-topic")
+ .deadLetterTopic("persistent://my-property/my-ns/dlq-topic")
+ .build())
+ .subscriptionName("sub")
+ .subscribe();
+
+ Producer<byte[]> producer = pulsarClient.newProducer()
+ .topic(topicName)
+ .create();
+
+ final int messages = 1;
+ for (int i = 0; i < messages; i++) {
+ producer.send(("message-" + i).getBytes());
+ }
+
+ for (int i = 0; i < messages * 4; i++) {
+ // nack and reconsumeLater
+ Message msg = consumer.receive(1, TimeUnit.SECONDS);
+ if (msg != null) {
+ consumer.reconsumeLater(msg, 100, TimeUnit.MILLISECONDS);
+ }
+ }
+ Thread.sleep(2000); // wait for producers to be created and stats interval to pass
+
+ ConsumerStats stats = consumer.getStats();
+ ProducerStats retryStats = stats.getRetryLetterProducerStats();
+ ProducerStats deadLetterStats = stats.getDeadLetterProducerStats();
+ assertNotNull(retryStats);
+ assertNotNull(deadLetterStats);
+ assertEquals(retryStats.getTotalMsgsSent(), 3);
+ assertEquals(deadLetterStats.getTotalMsgsSent(), 1);
+ }
+ @Test
+ public void testDeadLetterStats() throws PulsarClientException, InterruptedException {
+ final String topicName = "persistent://my-property/my-ns/testDeadLetterStats";
+
+ Consumer<byte[]> consumer = pulsarClient.newConsumer()
+ .topic(topicName)
+ .subscriptionType(SubscriptionType.Shared)
+ .negativeAckRedeliveryDelay(100, TimeUnit.MILLISECONDS)
+ .deadLetterPolicy(DeadLetterPolicy.builder()
+ .maxRedeliverCount(1)
+ .deadLetterTopic("persistent://my-property/my-ns/dlq-topic")
+ .build())
+ .subscriptionName("sub")
+ .subscribe();
+
+ Producer<byte[]> producer = pulsarClient.newProducer()
+ .topic(topicName)
+ .create();
+
+ final int messages = 1;
+ for (int i = 0; i < messages; i++) {
+ producer.send(("message-" + i).getBytes());
+ }
+
+ for (int i = 0; i < messages * 2; i++) {
+ // nack and reconsumeLater
+ Message msg = consumer.receive(1, TimeUnit.SECONDS);
+ if (msg != null) {
+ consumer.negativeAcknowledge(msg);
+ }
+ }
+ Thread.sleep(2000); // wait for producers to be created and stats interval to pass
+
+ ConsumerStats stats = consumer.getStats();
+ ProducerStats dlqStats = stats.getDeadLetterProducerStats();
+ assertNotNull(dlqStats);
+ assertEquals(dlqStats.getTotalMsgsSent(), 1);
+ }
+
+ @Test
+ public void testPartitionedRetryLetterAndDeadLetterStats()
+ throws PulsarClientException, InterruptedException, PulsarAdminException {
+ final String topicName = "persistent://my-property/my-ns/testPartitionedRetryLetterAndDeadLetterStats";
+
+ admin.topics().createPartitionedTopic(topicName, 10);
+ Consumer<byte[]> consumer = pulsarClient.newConsumer()
+ .topic(topicName)
+ .subscriptionType(SubscriptionType.Shared)
+ .negativeAckRedeliveryDelay(100, TimeUnit.MILLISECONDS)
+ .enableRetry(true)
+ .deadLetterPolicy(DeadLetterPolicy.builder()
+ .maxRedeliverCount(3)
+ .retryLetterTopic("persistent://my-property/my-ns/retry-topic")
+ .deadLetterTopic("persistent://my-property/my-ns/dlq-topic")
+ .build())
+ .subscriptionName("sub")
+ .subscribe();
+
+ Producer<byte[]> producer = pulsarClient.newProducer()
+ .topic(topicName)
+ .messageRoutingMode(MessageRoutingMode.RoundRobinPartition)
+ .create();
+
+ final int messages = 30;
+ for (int i = 0; i < messages; i++) {
+ producer.send(("message-" + i).getBytes());
+ }
+
+ for (int i = 0; i < messages * 4; i++) {
+ // nack and reconsumeLater
+ Message msg = consumer.receive(1, TimeUnit.SECONDS);
+ if (msg != null) {
+ consumer.reconsumeLater(msg, 100, TimeUnit.MILLISECONDS);
+ }
+ }
+ Thread.sleep(2000); // wait for producers to be created and stats interval to pass
Review Comment:
Thanks @Technoboy- , I made the suggested change!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org