[jira] [Commented] (THRIFT-1973) TCompactProtocol in C# lib does not serialize and deserialize negative int32 and int64 number correctly

["Henrique Mendonca (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13661647#comment-13661647 ] 

Henrique Mendonca commented on THRIFT-1973:
-------------------------------------------

Hi Eric,
Thanks for you patch. Are both your client and server running C#?
Would you be able to provide us some unit-testing to reproduce that?
We are already using this on production code and the cases you mentioned were successfully tested against a c++ server, but yes, this could be a problem on the other side.
Ideally, we should make the existing tests to optionally use compact binary to check this.

Cheers,
Henrique
                
> TCompactProtocol in C# lib does not serialize and deserialize negative int32 and int64 number correctly
> -------------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-1973
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1973
>             Project: Thrift
>          Issue Type: Bug
>          Components: C# - Library
>    Affects Versions: 0.9, 1.0
>         Environment: Windows
>            Reporter: Eric Ding
>              Labels: PatchAvailable
>             Fix For: 1.0
>
>         Attachments: thrift-1973-TCompactProtocol-Fix.patch
>
>
> longToZigzag and ZigzagToLong in TCompactProtocol does not perform corresponding operations to serialize and deserialize negative int32 and int64 number correctly.  Purpose to change longToZigzag from (ulong)(((ulong)n << 1) ^ ((ulong)n >> 63)) to (ulong)(n << 1) ^ (ulong)(n >> 63).
> Will need to do same for intToZigZag.  The reason is that we want arithmetic shift not logic shift.  
> The test case in the project shows this, the output on server and client are different even though client received the same number back.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira