[jira] [Commented] (LUCENE-10253) Remove BadApple test annotation

["Robert Muir (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-10253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448060#comment-17448060 ] 

Robert Muir commented on LUCENE-10253:
--------------------------------------

+1, if a test is flaky, we should just apply {{AwaitsFix}}. 

It is really confusing today that you can apply this {{BadApple}} annotation and the tests still run by default anyways and will sporadically fail. Turning flaky tests off only in certain CI builds but still leaving them flaky for devs is wrong IMO.

> Remove BadApple test annotation
> -------------------------------
>
>                 Key: LUCENE-10253
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10253
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Adrien Grand
>            Priority: Minor
>
> Lucene currently doesn't have a single test annotated with BadApple. Let's remove this annotation and try hard to not add any new flaky test?
> I know Solr is currently using this annotation so I plan to make this change 10.0-only to give Solr time to add this annotation on its end.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org