You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/01/02 12:07:10 UTC
[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #407:
HDDS-2829. Deduplicate KDC docker image definition
adoroszlai opened a new pull request #407: HDDS-2829. Deduplicate KDC docker image definition
URL: https://github.com/apache/hadoop-ozone/pull/407
## What changes were proposed in this pull request?
Move definition of insecure Ozone KDC image (for security tests) to a common location for both `ozonesecure` and `ozonesecure-mr` to reuse.
* Fix: `[Warning] One or more build-args [buildno] were not consumed`
* Tag the image built for reuse in same acceptance test run
* Squash `apk add` calls
* No need to `rm` cache since using `--no-cache`
https://issues.apache.org/jira/browse/HDDS-2829
## How was this patch tested?
Built image locally, verified that:
* warning is gone
* image size did not increase from previous version
Verified that the image is created for `ozonesecure-mr` and then reused for `ozonesecure` in CI.
https://github.com/adoroszlai/hadoop-ozone/runs/370732273
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] xiaoyuyao commented on issue #407: HDDS-2829.
Deduplicate KDC docker image definition
Posted by GitBox <gi...@apache.org>.
xiaoyuyao commented on issue #407: HDDS-2829. Deduplicate KDC docker image definition
URL: https://github.com/apache/hadoop-ozone/pull/407#issuecomment-571217291
Thanks @adoroszlai for the improvement. The change LGTM, +1. I will merge it shortly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on issue #407: HDDS-2829.
Deduplicate KDC docker image definition
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on issue #407: HDDS-2829. Deduplicate KDC docker image definition
URL: https://github.com/apache/hadoop-ozone/pull/407#issuecomment-571224806
Thanks @xiaoyuyao for reviewing and merging it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] xiaoyuyao merged pull request #407: HDDS-2829.
Deduplicate KDC docker image definition
Posted by GitBox <gi...@apache.org>.
xiaoyuyao merged pull request #407: HDDS-2829. Deduplicate KDC docker image definition
URL: https://github.com/apache/hadoop-ozone/pull/407
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org