You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "Patrick0308 (GitHub)" <gi...@apache.org> on 2020/01/10 02:10:21 UTC
[GitHub] [dubbo-go] Patrick0308 opened pull request #314: When
service don't have right protocol config, remind user to check.
**What this PR does**:
When service don't have right protocol config, remind user to check.
**Which issue(s) this PR fixes**:
Fixes #308
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
[ Full content available at: https://github.com/apache/dubbo-go/pull/314 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks closed pull request #314: When service
don't have right protocol config, remind user to check.
Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
[ pull request closed by AlexStocks ]
[ Full content available at: https://github.com/apache/dubbo-go/pull/314 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #314: When service
don't have right protocol config, remind user to check.
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/314?src=pr&el=h1) Report
> Merging [#314](https://codecov.io/gh/apache/dubbo-go/pull/314?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/4bd28510f3a07c0238026101bcf2a2ef988c6f55?src=pr&el=desc) will **increase** coverage by `0.11%`.
> The diff coverage is `100%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/314/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/314?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #314 +/- ##
==========================================
+ Coverage 65.69% 65.8% +0.11%
==========================================
Files 113 113
Lines 7255 7259 +4
==========================================
+ Hits 4766 4777 +11
+ Misses 2013 2007 -6
+ Partials 476 475 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/314?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/314/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `71.15% <100%> (+1.15%)` | :arrow_up: |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/314/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `64.45% <0%> (+0.57%)` | :arrow_up: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/314/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `47.93% <0%> (+1.03%)` | :arrow_up: |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/314/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `58.53% <0%> (+3.65%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/314?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/314?src=pr&el=footer). Last update [4bd2851...d01b5ee](https://codecov.io/gh/apache/dubbo-go/pull/314?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/314 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org