You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zookeeper.apache.org by "Raul Gutierrez Segales (JIRA)" <ji...@apache.org> on 2015/05/09 05:53:59 UTC

[jira] [Created] (ZOOKEEPER-2187) remove duplicated code between CreateRequest{,2}

Raul Gutierrez Segales created ZOOKEEPER-2187:
-------------------------------------------------

             Summary: remove duplicated code between CreateRequest{,2}
                 Key: ZOOKEEPER-2187
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2187
             Project: ZooKeeper
          Issue Type: Bug
          Components: server
            Reporter: Raul Gutierrez Segales
            Assignee: Raul Gutierrez Segales
            Priority: Minor
             Fix For: 3.5.2, 3.6.0


To avoid cargo culting and reducing duplicated code we can merge most of CreateRequest & CreateRequest2 given that only the Response object is actually different.

This will improve readability of the code plus make it less confusing for people adding new opcodes in the future (i.e.: copying a request definition vs reusing what's already there, etc.). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)