You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/08/06 18:30:37 UTC
[GitHub] [cloudstack] nvazquez opened a new pull request #4250: [VMware] OVF Full properties support
nvazquez opened a new pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250
## Description
WIP
## Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-678017246
@blueorangutan test centos7 vmware-67u3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-684741288
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-675535633
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1781
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-688474956
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1910
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-673492309
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-680007132
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1822
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-678078831
@andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-677944077
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-675915230
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1783
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-672568463
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-683264873
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-673754888
Packaging result: ✔centos7 ✔debian. JID-1747
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on a change in pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on a change in pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#discussion_r471426035
##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql
##########
@@ -181,4 +181,121 @@ UPDATE `cloud`.`roles` SET `is_default` = 1 WHERE id IN (1, 2, 3, 4);
INSERT INTO `cloud`.`roles` (`uuid`, `name`, `role_type`, `description`, `is_default`) VALUES (UUID(), 'Read-Only Admin - Default', 'Admin', 'Default read-only admin role', 1);
INSERT INTO `cloud`.`roles` (`uuid`, `name`, `role_type`, `description`, `is_default`) VALUES (UUID(), 'Read-Only User - Default', 'User', 'Default read-only user role', 1);
INSERT INTO `cloud`.`roles` (`uuid`, `name`, `role_type`, `description`, `is_default`) VALUES (UUID(), 'Support Admin - Default', 'Admin', 'Default support admin role', 1);
-INSERT INTO `cloud`.`roles` (`uuid`, `name`, `role_type`, `description`, `is_default`) VALUES (UUID(), 'Support User - Default', 'User', 'Default support user role', 1);
\ No newline at end of file
+INSERT INTO `cloud`.`roles` (`uuid`, `name`, `role_type`, `description`, `is_default`) VALUES (UUID(), 'Support User - Default', 'User', 'Default support user role', 1);
+
+-- Add passthrough instruction for appliance deployments
+ALTER TABLE `cloud`.`vm_template` ADD COLUMN `deploy_as_is` tinyint(1) NOT NULL DEFAULT '0' COMMENT 'True if the template should be deployed with disks and networks as defined';
Review comment:
```suggestion
ALTER TABLE `cloud`.`vm_template` ADD COLUMN `deploy_as_is` tinyint(1) NOT NULL DEFAULT '0' COMMENT 'True if the template should be deployed with disks and networks as defined by OVF';
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670167687
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-675512548
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-684921719
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-674033856
Ping @rhtyd @DaanHoogland @shwstppr @harikrishna-patnala please review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-678646748
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd removed a comment on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd removed a comment on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-671064854
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-684565374
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-682457712
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-1844
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-673156647
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-674789338
LGTM - any outstanding issues with tests, will have to be resolved for 4.15 anyways.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-673987488
@blueorangutan test centos7 vmware-67u3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-672795246
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-672568141
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-673970439
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-674431129
Packaging result: ✔centos7 ✔debian. JID-1761
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-671083302
@rhtyd a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware67, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-671078362
re-kicked centos7 pkg manually
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-673970161
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-678757509
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-678076807
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-677962296
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1799
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-679001011
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1811
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-678092108
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1800
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-677953039
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-682355838
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-671068098
Packaging result: ✖centos7 ✖debian. JID-1681
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670377662
@nvazquez still many failures in travis/simulator hinting at general regressions
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-673990217
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670824887
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez removed a comment on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
nvazquez removed a comment on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670145874
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-671162418
@blueorangutan test matrix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670167974
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-688459529
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670824970
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-671072545
Packaging result: ✖centos7 ✔debian. JID-1684
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-671528667
@blueorangutan test matrix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on a change in pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on a change in pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#discussion_r472795090
##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql
##########
@@ -181,4 +181,121 @@ UPDATE `cloud`.`roles` SET `is_default` = 1 WHERE id IN (1, 2, 3, 4);
INSERT INTO `cloud`.`roles` (`uuid`, `name`, `role_type`, `description`, `is_default`) VALUES (UUID(), 'Read-Only Admin - Default', 'Admin', 'Default read-only admin role', 1);
INSERT INTO `cloud`.`roles` (`uuid`, `name`, `role_type`, `description`, `is_default`) VALUES (UUID(), 'Read-Only User - Default', 'User', 'Default read-only user role', 1);
INSERT INTO `cloud`.`roles` (`uuid`, `name`, `role_type`, `description`, `is_default`) VALUES (UUID(), 'Support Admin - Default', 'Admin', 'Default support admin role', 1);
-INSERT INTO `cloud`.`roles` (`uuid`, `name`, `role_type`, `description`, `is_default`) VALUES (UUID(), 'Support User - Default', 'User', 'Default support user role', 1);
\ No newline at end of file
+INSERT INTO `cloud`.`roles` (`uuid`, `name`, `role_type`, `description`, `is_default`) VALUES (UUID(), 'Support User - Default', 'User', 'Default support user role', 1);
+
+-- Add passthrough instruction for appliance deployments
+ALTER TABLE `cloud`.`vm_template` ADD COLUMN `deploy_as_is` tinyint(1) NOT NULL DEFAULT '0' COMMENT 'True if the template should be deployed with disks and networks as defined';
+
+ALTER TABLE `cloud`.`vm_template_details` MODIFY COLUMN `value` varchar(8192) CHARACTER SET utf8 COLLATE utf8_general_ci NOT NULL;
+
+-- Changes to template_view for both deploying multidisk OVA/vApp as is
+DROP VIEW IF EXISTS `cloud`.`template_view`;
+CREATE VIEW `cloud`.`template_view` AS
+ SELECT
+ `vm_template`.`id` AS `id`,
+ `vm_template`.`uuid` AS `uuid`,
+ `vm_template`.`unique_name` AS `unique_name`,
+ `vm_template`.`name` AS `name`,
+ `vm_template`.`public` AS `public`,
+ `vm_template`.`featured` AS `featured`,
+ `vm_template`.`type` AS `type`,
+ `vm_template`.`hvm` AS `hvm`,
+ `vm_template`.`bits` AS `bits`,
+ `vm_template`.`url` AS `url`,
+ `vm_template`.`format` AS `format`,
+ `vm_template`.`created` AS `created`,
+ `vm_template`.`checksum` AS `checksum`,
+ `vm_template`.`display_text` AS `display_text`,
+ `vm_template`.`enable_password` AS `enable_password`,
+ `vm_template`.`dynamically_scalable` AS `dynamically_scalable`,
+ `vm_template`.`state` AS `template_state`,
+ `vm_template`.`guest_os_id` AS `guest_os_id`,
+ `guest_os`.`uuid` AS `guest_os_uuid`,
+ `guest_os`.`display_name` AS `guest_os_name`,
+ `vm_template`.`bootable` AS `bootable`,
+ `vm_template`.`prepopulate` AS `prepopulate`,
+ `vm_template`.`cross_zones` AS `cross_zones`,
+ `vm_template`.`hypervisor_type` AS `hypervisor_type`,
+ `vm_template`.`extractable` AS `extractable`,
+ `vm_template`.`template_tag` AS `template_tag`,
+ `vm_template`.`sort_key` AS `sort_key`,
+ `vm_template`.`removed` AS `removed`,
+ `vm_template`.`enable_sshkey` AS `enable_sshkey`,
+ `parent_template`.`id` AS `parent_template_id`,
+ `parent_template`.`uuid` AS `parent_template_uuid`,
+ `source_template`.`id` AS `source_template_id`,
+ `source_template`.`uuid` AS `source_template_uuid`,
+ `account`.`id` AS `account_id`,
+ `account`.`uuid` AS `account_uuid`,
+ `account`.`account_name` AS `account_name`,
+ `account`.`type` AS `account_type`,
+ `domain`.`id` AS `domain_id`,
+ `domain`.`uuid` AS `domain_uuid`,
+ `domain`.`name` AS `domain_name`,
+ `domain`.`path` AS `domain_path`,
+ `projects`.`id` AS `project_id`,
+ `projects`.`uuid` AS `project_uuid`,
+ `projects`.`name` AS `project_name`,
+ `data_center`.`id` AS `data_center_id`,
+ `data_center`.`uuid` AS `data_center_uuid`,
+ `data_center`.`name` AS `data_center_name`,
+ `launch_permission`.`account_id` AS `lp_account_id`,
+ `template_store_ref`.`store_id` AS `store_id`,
+ `image_store`.`scope` AS `store_scope`,
+ `template_store_ref`.`state` AS `state`,
+ `template_store_ref`.`download_state` AS `download_state`,
+ `template_store_ref`.`download_pct` AS `download_pct`,
+ `template_store_ref`.`error_str` AS `error_str`,
+ `template_store_ref`.`size` AS `size`,
+ `template_store_ref`.physical_size AS `physical_size`,
+ `template_store_ref`.`destroyed` AS `destroyed`,
+ `template_store_ref`.`created` AS `created_on_store`,
+ `vm_template_details`.`name` AS `detail_name`,
+ `vm_template_details`.`value` AS `detail_value`,
+ `resource_tags`.`id` AS `tag_id`,
+ `resource_tags`.`uuid` AS `tag_uuid`,
+ `resource_tags`.`key` AS `tag_key`,
+ `resource_tags`.`value` AS `tag_value`,
+ `resource_tags`.`domain_id` AS `tag_domain_id`,
+ `domain`.`uuid` AS `tag_domain_uuid`,
+ `domain`.`name` AS `tag_domain_name`,
+ `resource_tags`.`account_id` AS `tag_account_id`,
+ `account`.`account_name` AS `tag_account_name`,
+ `resource_tags`.`resource_id` AS `tag_resource_id`,
+ `resource_tags`.`resource_uuid` AS `tag_resource_uuid`,
+ `resource_tags`.`resource_type` AS `tag_resource_type`,
+ `resource_tags`.`customer` AS `tag_customer`,
+ CONCAT(`vm_template`.`id`,
+ '_',
+ IFNULL(`data_center`.`id`, 0)) AS `temp_zone_pair`,
+ `vm_template`.`direct_download` AS `direct_download`,
+ `vm_template`.`deploy_as_is` AS `deploy_as_is`
+ FROM
+ (((((((((((((`vm_template`
+ JOIN `guest_os` ON ((`guest_os`.`id` = `vm_template`.`guest_os_id`)))
+ JOIN `account` ON ((`account`.`id` = `vm_template`.`account_id`)))
+ JOIN `domain` ON ((`domain`.`id` = `account`.`domain_id`)))
+ LEFT JOIN `projects` ON ((`projects`.`project_account_id` = `account`.`id`)))
+ LEFT JOIN `vm_template_details` ON ((`vm_template_details`.`template_id` = `vm_template`.`id`)))
+ LEFT JOIN `vm_template` `source_template` ON ((`source_template`.`id` = `vm_template`.`source_template_id`)))
+ LEFT JOIN `template_store_ref` ON (((`template_store_ref`.`template_id` = `vm_template`.`id`)
+ AND (`template_store_ref`.`store_role` = 'Image')
+ AND (`template_store_ref`.`destroyed` = 0))))
+ LEFT JOIN `vm_template` `parent_template` ON ((`parent_template`.`id` = `vm_template`.`parent_template_id`)))
+ LEFT JOIN `image_store` ON ((ISNULL(`image_store`.`removed`)
+ AND (`template_store_ref`.`store_id` IS NOT NULL)
+ AND (`image_store`.`id` = `template_store_ref`.`store_id`))))
+ LEFT JOIN `template_zone_ref` ON (((`template_zone_ref`.`template_id` = `vm_template`.`id`)
+ AND ISNULL(`template_store_ref`.`store_id`)
+ AND ISNULL(`template_zone_ref`.`removed`))))
+ LEFT JOIN `data_center` ON (((`image_store`.`data_center_id` = `data_center`.`id`)
+ OR (`template_zone_ref`.`zone_id` = `data_center`.`id`))))
+ LEFT JOIN `launch_permission` ON ((`launch_permission`.`template_id` = `vm_template`.`id`)))
+ LEFT JOIN `resource_tags` ON (((`resource_tags`.`resource_id` = `vm_template`.`id`)
+ AND ((`resource_tags`.`resource_type` = 'Template')
+ OR (`resource_tags`.`resource_type` = 'ISO')))));
+
+DROP TABLE IF EXISTS `cloud`.`template_ovf_properties`;
Review comment:
ok, we agree the table can't be removed, but the documentation will have to say it's deprecated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-673514933
Packaging result: ✔centos7 ✔debian. JID-1745
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-679977113
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-673984442
Packaging result: ✔centos7 ✔debian. JID-1754
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-682374816
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-1835
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#discussion_r470522804
##########
File path: test/integration/smoke/test_vm_life_cycle.py
##########
@@ -27,7 +27,7 @@
migrateVirtualMachine,
migrateVirtualMachineWithVolume,
unmanageVirtualMachine,
- listUnmanagedInstances
+ listUnmanagedInstances,
Review comment:
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-687619225
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-674427834
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-678017596
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-677944314
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb removed a comment on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
andrijapanicsb removed a comment on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-674789338
LGTM - any outstanding issues with tests, will have to be resolved for 4.15 anyways.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-677937661
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670190201
@blueorangutan test centos7 vmware-67u3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-672795701
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a change in pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
nvazquez commented on a change in pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#discussion_r471434949
##########
File path: api/src/main/java/org/apache/cloudstack/api/ApiConstants.java
##########
@@ -260,7 +260,8 @@
public static final String OUTOFBANDMANAGEMENT_POWERSTATE = "outofbandmanagementpowerstate";
public static final String OUTOFBANDMANAGEMENT_ENABLED = "outofbandmanagementenabled";
public static final String OUTPUT = "output";
- public static final String OVF_PROPERTIES = "ovfproperties";
+ public static final String PROPERTIES = "properties";
+ public static final String ACS_PROPERTY = "ACS-property";
Review comment:
No, thanks. Moved its usage to the property prefix defined on ImageStore class
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-674431569
@blueorangutan test matrix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-685675347
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-683270581
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1850
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-674312721
<b>Trillian test result (tid-2448)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44357 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4250-t2448-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Smoke tests completed. 84 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_07_reboot_ssvm | `Failure` | 41.96 | test_ssvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-677937947
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-674884400
Packaging result: ✔centos7 ✔debian. JID-1770
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-687628603
@blueorangutan test matrix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670417333
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-677952770
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-674744303
Frontend PR merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-684922358
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-671754961
<b>Trillian test result (tid-2347)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39722 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4250-t2347-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Smoke tests completed. 80 look OK, 3 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_3d_gpu_support | `Error` | 198.96 | test_deploy_vgpu_enabled_vm.py
test_01_add_delete_kubernetes_supported_version | `Error` | 1807.40 | test_kubernetes_supported_versions.py
test_07_reboot_ssvm | `Failure` | 22.47 | test_ssvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-674862835
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670100956
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-678757584
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-671064854
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-684739978
@blueorangutan test centos7 vmware-67u3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-678758797
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-1804
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670438522
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-688459397
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a change in pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
nvazquez commented on a change in pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#discussion_r471440583
##########
File path: core/src/main/java/com/cloud/resource/ServerResource.java
##########
@@ -31,6 +31,9 @@
* ServerResource is a generic container to execute commands sent
*/
public interface ServerResource extends Manager {
+
+ String ORIGINAL_FILE_EXTENSION = ".orig";
Review comment:
Thanks, was used on NfsSecondaryStorageResource only, moved it there
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-673165996
Packaging result: ✔centos7 ✔debian. JID-1732
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-673988137
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-674427958
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-674018124
Vmware smoketest started on backend (job/acs-pr-trillian/2448)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-671744958
<b>Trillian test result (tid-2346)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37924 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4250-t2346-kvm-centos7.zip
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670145874
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-675511988
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-674007434
Packaging result: ✔centos7 ✔debian. JID-1756
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-673928379
<b>Trillian test result (tid-2410)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 51770 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4250-t2410-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 78 look OK, 4 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_3d_gpu_support | `Error` | 353.76 | test_deploy_vgpu_enabled_vm.py
test_00_deploy_vm_root_resize | `Failure` | 254.03 | test_deploy_vm_root_resize.py
test_01_add_delete_kubernetes_supported_version | `Error` | 125.91 | test_kubernetes_supported_versions.py
test_07_reboot_ssvm | `Failure` | 46.95 | test_ssvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-673515472
@blueorangutan test centos7 vmware-67u3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-671065054
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-680415697
@rhtyd a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware67, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez closed pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
nvazquez closed pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a change in pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
nvazquez commented on a change in pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#discussion_r471448614
##########
File path: tools/marvin/marvin/config/test_data.py
##########
@@ -986,7 +986,60 @@
"ispublic": "True"
}
},
-
+ "test_ovf_templates": [
+ {
+ "name": "test-ovf",
+ "displaytext": "test-ovf",
+ "format": "ova",
+ "hypervisor": "vmware",
+ "ostype": "Other Linux (64-bit)",
+ "url": "http://172.17.0.1/machina-2dd-iso.ova",
Review comment:
Thanks, this needs to be public - TODO
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-673967186
Packaging result: ✔centos7 ✖debian. JID-1753
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670416413
@nvazquez I triaged the issues for simulator/Travis, they are limited to `test_vm_life_cycle` and `test_reset_vm_on_reboot` failures now.
1. For the `test_vm_life_cycle` the following tests fail:
```
=== TestName: test_01_unmanage_vm_cycle | Status : EXCEPTION ===
```
Error log: (we probably should skip test/setup if hypervisor is not vmware?)
```
ERROR: test suite for <class 'integration.smoke.test_vm_life_cycle.TestVAppsVM'>
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/local/lib/python2.7/dist-packages/nose/suite.py", line 209, in run
self.setUp()
File "/usr/local/lib/python2.7/dist-packages/nose/suite.py", line 292, in setUp
self.setupContext(ancestor)
File "/usr/local/lib/python2.7/dist-packages/nose/suite.py", line 315, in setupContext
try_run(context, names)
File "/usr/local/lib/python2.7/dist-packages/nose/util.py", line 471, in try_run
return func()
File "/home/rohit/lab/apache/cloudstack/test/integration/smoke/test_vm_life_cycle.py", line 1696, in setUpClass
assert False, "get_test_ovf_templates() failed to return templates"
AssertionError: get_test_ovf_templates() failed to return templates
```
...
```
2020-08-07 14:28:20,461 - DEBUG - ========Sending GET Cmd : createEgressFirewallRule=======
2020-08-07 14:28:20,484 - ERROR - Exception:['Traceback (most recent call last):\n', ' File "/usr/local/lib/python2.7/dist-packages/marvin/cloudstackConnection.py", line 308, in __parseAndGetResponse\n response_cls)\n', ' File "/usr/local/lib/python2.7/dist-packages/marvin/jsonHelper.py", line 156, in getResultObj\n raise cloudstackException.CloudstackAPIException(respname, errMsg)\n', 'CloudstackAPIException: Execute cmd: createegressfirewallrule failed, due to: errorCode: 537, errorText:There is already a firewall rule specified with protocol = all and no ports\n']
```
2. For `test_reset_vm_on_reboot` failure, I checked against master looks like this is failing on master as well due to:
```
java.lang.NullPointerException
at com.cloud.vm.VirtualMachineManagerImpl.logBootModeParameters(VirtualMachineManagerImpl.java:1339)
```
I'll send a separate PR for this issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-686907321
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-672888676
Packaging result: ✔centos7 ✔debian. JID-1728
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-674493776
<b>Trillian test result (tid-2462)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46706 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4250-t2462-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 72 look OK, 13 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_add_delete_kubernetes_supported_version | `Error` | 1806.79 | test_kubernetes_supported_versions.py
ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 0.14 | test_routers_network_ops.py
test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 0.14 | test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 1.29 | test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.14 | test_service_offerings.py
ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
test_04_rvpc_network_garbage_collector_nics | `Error` | 3899.66 | test_vpc_redundant.py
test_hostha_kvm_host_fencing | `Error` | 166.75 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-687628653
@rhtyd a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware67, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-683264771
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-675989648
no need to start regression testing until QA finishes - there are a number of bugs atm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a change in pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
nvazquez commented on a change in pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#discussion_r471446525
##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql
##########
@@ -181,4 +181,121 @@ UPDATE `cloud`.`roles` SET `is_default` = 1 WHERE id IN (1, 2, 3, 4);
INSERT INTO `cloud`.`roles` (`uuid`, `name`, `role_type`, `description`, `is_default`) VALUES (UUID(), 'Read-Only Admin - Default', 'Admin', 'Default read-only admin role', 1);
INSERT INTO `cloud`.`roles` (`uuid`, `name`, `role_type`, `description`, `is_default`) VALUES (UUID(), 'Read-Only User - Default', 'User', 'Default read-only user role', 1);
INSERT INTO `cloud`.`roles` (`uuid`, `name`, `role_type`, `description`, `is_default`) VALUES (UUID(), 'Support Admin - Default', 'Admin', 'Default support admin role', 1);
-INSERT INTO `cloud`.`roles` (`uuid`, `name`, `role_type`, `description`, `is_default`) VALUES (UUID(), 'Support User - Default', 'User', 'Default support user role', 1);
\ No newline at end of file
+INSERT INTO `cloud`.`roles` (`uuid`, `name`, `role_type`, `description`, `is_default`) VALUES (UUID(), 'Support User - Default', 'User', 'Default support user role', 1);
+
+-- Add passthrough instruction for appliance deployments
+ALTER TABLE `cloud`.`vm_template` ADD COLUMN `deploy_as_is` tinyint(1) NOT NULL DEFAULT '0' COMMENT 'True if the template should be deployed with disks and networks as defined';
+
+ALTER TABLE `cloud`.`vm_template_details` MODIFY COLUMN `value` varchar(8192) CHARACTER SET utf8 COLLATE utf8_general_ci NOT NULL;
Review comment:
Thanks, it was below. Unifying this in a single line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-679976928
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-673491778
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-680415374
@blueorangutan test matrix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-687717530
<b>Trillian test result (tid-2668)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 53601 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4250-t2668-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 80 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 597.71 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | `Error` | 3844.22 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | `Error` | 3844.25 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Error` | 0.02 | test_vpc_redundant.py
ContextSuite context=TestVPCRedundancy>:teardown | `Error` | 0.03 | test_vpc_redundant.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on a change in pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on a change in pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#discussion_r471431547
##########
File path: ui/scripts/instanceWizard.js
##########
@@ -1054,8 +1054,8 @@
}
});
for (var k = 0; k < deployOvfProperties.length; k++) {
- deployVmData["ovfproperties[" + k + "].key"] = deployOvfProperties[k].key;
- deployVmData["ovfproperties[" + k + "].value"] = deployOvfProperties[k].value;
+ deployVmData["properties[" + k + "].key"] = deployOvfProperties[k].key;
+ deployVmData["properties[" + k + "].value"] = deployOvfProperties[k].value;
Review comment:
I might be wrong - but did we agreed no changes in old UI for any new features etc?
##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql
##########
@@ -181,4 +181,121 @@ UPDATE `cloud`.`roles` SET `is_default` = 1 WHERE id IN (1, 2, 3, 4);
INSERT INTO `cloud`.`roles` (`uuid`, `name`, `role_type`, `description`, `is_default`) VALUES (UUID(), 'Read-Only Admin - Default', 'Admin', 'Default read-only admin role', 1);
INSERT INTO `cloud`.`roles` (`uuid`, `name`, `role_type`, `description`, `is_default`) VALUES (UUID(), 'Read-Only User - Default', 'User', 'Default read-only user role', 1);
INSERT INTO `cloud`.`roles` (`uuid`, `name`, `role_type`, `description`, `is_default`) VALUES (UUID(), 'Support Admin - Default', 'Admin', 'Default support admin role', 1);
-INSERT INTO `cloud`.`roles` (`uuid`, `name`, `role_type`, `description`, `is_default`) VALUES (UUID(), 'Support User - Default', 'User', 'Default support user role', 1);
\ No newline at end of file
+INSERT INTO `cloud`.`roles` (`uuid`, `name`, `role_type`, `description`, `is_default`) VALUES (UUID(), 'Support User - Default', 'User', 'Default support user role', 1);
+
+-- Add passthrough instruction for appliance deployments
+ALTER TABLE `cloud`.`vm_template` ADD COLUMN `deploy_as_is` tinyint(1) NOT NULL DEFAULT '0' COMMENT 'True if the template should be deployed with disks and networks as defined';
+
+ALTER TABLE `cloud`.`vm_template_details` MODIFY COLUMN `value` varchar(8192) CHARACTER SET utf8 COLLATE utf8_general_ci NOT NULL;
+
+-- Changes to template_view for both deploying multidisk OVA/vApp as is
+DROP VIEW IF EXISTS `cloud`.`template_view`;
+CREATE VIEW `cloud`.`template_view` AS
+ SELECT
+ `vm_template`.`id` AS `id`,
+ `vm_template`.`uuid` AS `uuid`,
+ `vm_template`.`unique_name` AS `unique_name`,
+ `vm_template`.`name` AS `name`,
+ `vm_template`.`public` AS `public`,
+ `vm_template`.`featured` AS `featured`,
+ `vm_template`.`type` AS `type`,
+ `vm_template`.`hvm` AS `hvm`,
+ `vm_template`.`bits` AS `bits`,
+ `vm_template`.`url` AS `url`,
+ `vm_template`.`format` AS `format`,
+ `vm_template`.`created` AS `created`,
+ `vm_template`.`checksum` AS `checksum`,
+ `vm_template`.`display_text` AS `display_text`,
+ `vm_template`.`enable_password` AS `enable_password`,
+ `vm_template`.`dynamically_scalable` AS `dynamically_scalable`,
+ `vm_template`.`state` AS `template_state`,
+ `vm_template`.`guest_os_id` AS `guest_os_id`,
+ `guest_os`.`uuid` AS `guest_os_uuid`,
+ `guest_os`.`display_name` AS `guest_os_name`,
+ `vm_template`.`bootable` AS `bootable`,
+ `vm_template`.`prepopulate` AS `prepopulate`,
+ `vm_template`.`cross_zones` AS `cross_zones`,
+ `vm_template`.`hypervisor_type` AS `hypervisor_type`,
+ `vm_template`.`extractable` AS `extractable`,
+ `vm_template`.`template_tag` AS `template_tag`,
+ `vm_template`.`sort_key` AS `sort_key`,
+ `vm_template`.`removed` AS `removed`,
+ `vm_template`.`enable_sshkey` AS `enable_sshkey`,
+ `parent_template`.`id` AS `parent_template_id`,
+ `parent_template`.`uuid` AS `parent_template_uuid`,
+ `source_template`.`id` AS `source_template_id`,
+ `source_template`.`uuid` AS `source_template_uuid`,
+ `account`.`id` AS `account_id`,
+ `account`.`uuid` AS `account_uuid`,
+ `account`.`account_name` AS `account_name`,
+ `account`.`type` AS `account_type`,
+ `domain`.`id` AS `domain_id`,
+ `domain`.`uuid` AS `domain_uuid`,
+ `domain`.`name` AS `domain_name`,
+ `domain`.`path` AS `domain_path`,
+ `projects`.`id` AS `project_id`,
+ `projects`.`uuid` AS `project_uuid`,
+ `projects`.`name` AS `project_name`,
+ `data_center`.`id` AS `data_center_id`,
+ `data_center`.`uuid` AS `data_center_uuid`,
+ `data_center`.`name` AS `data_center_name`,
+ `launch_permission`.`account_id` AS `lp_account_id`,
+ `template_store_ref`.`store_id` AS `store_id`,
+ `image_store`.`scope` AS `store_scope`,
+ `template_store_ref`.`state` AS `state`,
+ `template_store_ref`.`download_state` AS `download_state`,
+ `template_store_ref`.`download_pct` AS `download_pct`,
+ `template_store_ref`.`error_str` AS `error_str`,
+ `template_store_ref`.`size` AS `size`,
+ `template_store_ref`.physical_size AS `physical_size`,
+ `template_store_ref`.`destroyed` AS `destroyed`,
+ `template_store_ref`.`created` AS `created_on_store`,
+ `vm_template_details`.`name` AS `detail_name`,
+ `vm_template_details`.`value` AS `detail_value`,
+ `resource_tags`.`id` AS `tag_id`,
+ `resource_tags`.`uuid` AS `tag_uuid`,
+ `resource_tags`.`key` AS `tag_key`,
+ `resource_tags`.`value` AS `tag_value`,
+ `resource_tags`.`domain_id` AS `tag_domain_id`,
+ `domain`.`uuid` AS `tag_domain_uuid`,
+ `domain`.`name` AS `tag_domain_name`,
+ `resource_tags`.`account_id` AS `tag_account_id`,
+ `account`.`account_name` AS `tag_account_name`,
+ `resource_tags`.`resource_id` AS `tag_resource_id`,
+ `resource_tags`.`resource_uuid` AS `tag_resource_uuid`,
+ `resource_tags`.`resource_type` AS `tag_resource_type`,
+ `resource_tags`.`customer` AS `tag_customer`,
+ CONCAT(`vm_template`.`id`,
+ '_',
+ IFNULL(`data_center`.`id`, 0)) AS `temp_zone_pair`,
+ `vm_template`.`direct_download` AS `direct_download`,
+ `vm_template`.`deploy_as_is` AS `deploy_as_is`
+ FROM
+ (((((((((((((`vm_template`
+ JOIN `guest_os` ON ((`guest_os`.`id` = `vm_template`.`guest_os_id`)))
+ JOIN `account` ON ((`account`.`id` = `vm_template`.`account_id`)))
+ JOIN `domain` ON ((`domain`.`id` = `account`.`domain_id`)))
+ LEFT JOIN `projects` ON ((`projects`.`project_account_id` = `account`.`id`)))
+ LEFT JOIN `vm_template_details` ON ((`vm_template_details`.`template_id` = `vm_template`.`id`)))
+ LEFT JOIN `vm_template` `source_template` ON ((`source_template`.`id` = `vm_template`.`source_template_id`)))
+ LEFT JOIN `template_store_ref` ON (((`template_store_ref`.`template_id` = `vm_template`.`id`)
+ AND (`template_store_ref`.`store_role` = 'Image')
+ AND (`template_store_ref`.`destroyed` = 0))))
+ LEFT JOIN `vm_template` `parent_template` ON ((`parent_template`.`id` = `vm_template`.`parent_template_id`)))
+ LEFT JOIN `image_store` ON ((ISNULL(`image_store`.`removed`)
+ AND (`template_store_ref`.`store_id` IS NOT NULL)
+ AND (`image_store`.`id` = `template_store_ref`.`store_id`))))
+ LEFT JOIN `template_zone_ref` ON (((`template_zone_ref`.`template_id` = `vm_template`.`id`)
+ AND ISNULL(`template_store_ref`.`store_id`)
+ AND ISNULL(`template_zone_ref`.`removed`))))
+ LEFT JOIN `data_center` ON (((`image_store`.`data_center_id` = `data_center`.`id`)
+ OR (`template_zone_ref`.`zone_id` = `data_center`.`id`))))
+ LEFT JOIN `launch_permission` ON ((`launch_permission`.`template_id` = `vm_template`.`id`)))
+ LEFT JOIN `resource_tags` ON (((`resource_tags`.`resource_id` = `vm_template`.`id`)
+ AND ((`resource_tags`.`resource_type` = 'Template')
+ OR (`resource_tags`.`resource_type` = 'ISO')))));
+
+DROP TABLE IF EXISTS `cloud`.`template_ovf_properties`;
Review comment:
What if users have some templates that populated this table - i.e. how are ACS upgrades handled?
##########
File path: tools/marvin/marvin/config/test_data.py
##########
@@ -986,7 +986,60 @@
"ispublic": "True"
}
},
-
+ "test_ovf_templates": [
+ {
+ "name": "test-ovf",
+ "displaytext": "test-ovf",
+ "format": "ova",
+ "hypervisor": "vmware",
+ "ostype": "Other Linux (64-bit)",
+ "url": "http://172.17.0.1/machina-2dd-iso.ova",
Review comment:
Um - IP hardcoded?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-678985501
The previous centos7 build failed due to:
`From https://github.com/apache/cloudstack
* [new ref] refs/pull/4141/head -> pr/4141
Auto-merging server/src/main/resources/META-INF/cloudstack/core/spring-server-core-managers-context.xml
Auto-merging server/src/main/java/com/cloud/server/ManagementServerImpl.java
Auto-merging server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
Auto-merging server/src/main/java/com/cloud/api/ApiResponseHelper.java
Auto-merging engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql
CONFLICT (content): Merge conflict in engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql
Auto-merging engine/schema/src/main/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml
Auto-merging api/src/main/java/org/apache/cloudstack/api/BaseCmd.java
Auto-merging api/src/main/java/org/apache/cloudstack/api/ApiConstants.java
Auto-merging api/src/main/java/com/cloud/event/EventTypes.java
Automatic merge failed; fix conflicts and then commit the result.
ERROR: Merge failed, aborting.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670827908
Packaging result: ✔centos7 ✔debian. JID-1678
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-673745411
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-673937617
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez removed a comment on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
nvazquez removed a comment on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-677937255
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670181963
Packaging result: ✔centos7 ✔debian. JID-1669
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a change in pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
nvazquez commented on a change in pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#discussion_r471442102
##########
File path: core/src/main/java/com/cloud/storage/resource/StorageProcessor.java
##########
@@ -33,6 +33,10 @@
import com.cloud.agent.api.Answer;
public interface StorageProcessor {
+
+ String REQUEST_TEMPLATE_RELOAD = "request template reload";
+ String COPY_NOT_NEEDED_FOR_DEPLOY_AS_IS = "copy volume not needed for deploy as is";
Review comment:
Used on the volume orchestrator answers from hypervisor to check if volume creation from template needs to be retried
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670190524
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-675899156
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670793645
<b>Trillian test result (tid-2298)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 49508 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4250-t2298-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 79 look OK, 4 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_3d_gpu_support | `Error` | 302.48 | test_deploy_vgpu_enabled_vm.py
test_01_reset_vm_on_reboot | `Error` | 5.20 | test_reset_vm_on_reboot.py
test_11_migrate_vm | `Error` | 50.96 | test_vm_life_cycle.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 487.90 | test_vpc_redundant.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670439062
@nvazquez I've fixed issue #2 7707d3fd92c8aa9dc181e635183e20818aed93cd which was due to a fwd-merge I did yesterday
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670438181
@blueorangutan test centos7 vmware-67u3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a change in pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
nvazquez commented on a change in pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#discussion_r475041891
##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql
##########
@@ -309,3 +309,86 @@ INSERT IGNORE INTO `cloud`.`hypervisor_capabilities`(uuid, hypervisor_type, hype
-- Copy XenServer 8.0 hypervisor guest OS mappings to XenServer8.1
INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) SELECT UUID(),'Xenserver', '8.1.0', guest_os_name, guest_os_id, utc_timestamp(), 0 FROM `cloud`.`guest_os_hypervisor` WHERE hypervisor_type='Xenserver' AND hypervisor_version='8.0.0';
+
+-- Add mincpu, maxcpu, minmemory and maxmemory to the view supporting constrained offerings
+ALTER VIEW `cloud`.`service_offering_view` AS
Review comment:
Thanks, fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-675917525
Kicking regression testing
@blueorangutan test centos7 vmware-67u3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a change in pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
nvazquez commented on a change in pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#discussion_r471436427
##########
File path: api/src/main/java/com/cloud/storage/ImageStore.java
##########
@@ -21,6 +21,13 @@
public interface ImageStore extends Identity, InternalIdentity {
+ String ACS_PROPERTY_PREFIX = "ACS-property-";
+ String REQUIRED_NETWORK_PREFIX = "ACS-network-";
+ String DISK_DEFINITION_PREFIX = "ACS-disk-";
+ String OVF_HARDWARE_CONFIGURATION_PREFIX = "ACS-configuration-";
+ String OVF_HARDWARE_ITEM_PREFIX = "ACS-hardware-item-";
+ String OVF_EULA_SECTION_PREFIX = "ACS-eula-";
+
Review comment:
The only pushback is that changing these keys will need a new Primate PR as the deployment wizard filters the details by these keys. If required I'll proceed with both
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-674863174
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-682425025
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez closed pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
nvazquez closed pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-673989878
@blueorangutan package
@rhtyd fixed syntax issue with test_vm_life_cylcle.py file.
Last test run shouldn't be affected by this change as tests will be overridden by Trillian there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-674516620
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670435611
Packaging result: ✔centos7 ✔debian. JID-1674
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez removed a comment on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
nvazquez removed a comment on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-677937947
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-671162587
@rhtyd a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware67, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-673652564
<b>Trillian test result (tid-2396)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41668 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4250-t2396-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 81 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_add_delete_kubernetes_supported_version | `Error` | 1809.29 | test_kubernetes_supported_versions.py
test_hostha_enable_ha_when_host_disabled | `Error` | 1.88 | test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance | `Error` | 302.36 | test_hostha_kvm.py
test_hostha_kvm_host_recovering | `Error` | 15.19 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-674431662
@rhtyd a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware67, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-684679445
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1862
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#discussion_r469772225
##########
File path: api/src/main/java/org/apache/cloudstack/api/command/user/template/ListTemplatesCmd.java
##########
@@ -99,7 +99,7 @@
public EnumSet<ApiConstants.DomainDetails> getDetails() throws InvalidParameterValueException {
EnumSet<ApiConstants.DomainDetails> dv;
if (CollectionUtils.isEmpty(viewDetails)) {
- dv = EnumSet.of(ApiConstants.DomainDetails.min);
+ dv = EnumSet.of(ApiConstants.DomainDetails.all);
Review comment:
@nvazquez any particular reason, we are listing all details by default? We can set it min and call API with details=all in UI when needed like DeployVM or template view
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on a change in pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on a change in pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#discussion_r471427044
##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql
##########
@@ -181,4 +181,121 @@ UPDATE `cloud`.`roles` SET `is_default` = 1 WHERE id IN (1, 2, 3, 4);
INSERT INTO `cloud`.`roles` (`uuid`, `name`, `role_type`, `description`, `is_default`) VALUES (UUID(), 'Read-Only Admin - Default', 'Admin', 'Default read-only admin role', 1);
INSERT INTO `cloud`.`roles` (`uuid`, `name`, `role_type`, `description`, `is_default`) VALUES (UUID(), 'Read-Only User - Default', 'User', 'Default read-only user role', 1);
INSERT INTO `cloud`.`roles` (`uuid`, `name`, `role_type`, `description`, `is_default`) VALUES (UUID(), 'Support Admin - Default', 'Admin', 'Default support admin role', 1);
-INSERT INTO `cloud`.`roles` (`uuid`, `name`, `role_type`, `description`, `is_default`) VALUES (UUID(), 'Support User - Default', 'User', 'Default support user role', 1);
\ No newline at end of file
+INSERT INTO `cloud`.`roles` (`uuid`, `name`, `role_type`, `description`, `is_default`) VALUES (UUID(), 'Support User - Default', 'User', 'Default support user role', 1);
+
+-- Add passthrough instruction for appliance deployments
+ALTER TABLE `cloud`.`vm_template` ADD COLUMN `deploy_as_is` tinyint(1) NOT NULL DEFAULT '0' COMMENT 'True if the template should be deployed with disks and networks as defined';
+
+ALTER TABLE `cloud`.`vm_template_details` MODIFY COLUMN `value` varchar(8192) CHARACTER SET utf8 COLLATE utf8_general_ci NOT NULL;
Review comment:
Does this hold 64K of data/text, as per the spec/agreed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-682356260
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-684948788
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1880
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-689279878
<b>Trillian test result (tid-2666)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 298535 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4250-t2666-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups.py
Intermittent failure detected: /marvin/tests/smoke/test_async_job.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_extra_config_data.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_with_userdata.py
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_domain_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_domain_vpc_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermittent failure detected: /marvin/tests/smoke/test_metrics_api.py
Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
Intermittent failure detected: /marvin/tests/smoke/test_network_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_nic.py
Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement.py
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_portforwardingrules.py
Intermittent failure detected: /marvin/tests/smoke/test_primary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_deployment_planner.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 37 look OK, 48 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 2708.70 | test_accounts.py
test_DeleteDomain | `Error` | 2706.00 | test_accounts.py
test_forceDeleteDomain | `Failure` | 2703.48 | test_accounts.py
test_forceDeleteDomain | `Error` | 2713.18 | test_accounts.py
test_01_user_remove_VM_running | `Error` | 2713.44 | test_accounts.py
test_DeployVmAntiAffinityGroup_in_project | `Error` | 2701.46 | test_affinity_groups_projects.py
test_query_async_job_result | `Error` | 2692.80 | test_async_job.py
test_07_deploy_vm_with_extraconfig_xenserver | `Error` | 2697.85 | test_deploy_vm_extra_config_data.py
test_deploy_vm_from_iso | `Error` | 2719.81 | test_deploy_vm_iso.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 1346.23 | test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 1351.36 | test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Failure` | 1348.30 | test_internal_lb.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Failure` | 1347.83 | test_internal_lb.py
test_00_deploy_vm_root_resize | `Error` | 2709.42 | test_deploy_vm_root_resize.py
test_deployvm_firstfit | `Error` | 2708.31 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentrated | `Error` | 2702.43 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdispersing | `Error` | 2701.31 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata | `Error` | 2694.40 | test_deploy_vm_with_userdata.py
ContextSuite context=TestLoadBalance>:setup | `Error` | 0.00 | test_loadbalance.py
ContextSuite context=TestRemoteDiagnostics>:setup | `Error` | 0.00 | test_diagnostics.py
test_03_deploy_vm_domain_service_offering | `Error` | 2706.25 | test_domain_service_offerings.py
test_03_create_vpc_domain_vpc_offering | `Error` | 1347.48 | test_domain_vpc_offerings.py
test_01_deploy_kubernetes_cluster | `Error` | 1348.62 | test_kubernetes_clusters.py
test_02_deploy_kubernetes_ha_cluster | `Error` | 1347.80 | test_kubernetes_clusters.py
test_04_deploy_and_upgrade_kubernetes_cluster | `Error` | 1354.75 | test_kubernetes_clusters.py
test_05_deploy_and_upgrade_kubernetes_ha_cluster | `Error` | 1351.98 | test_kubernetes_clusters.py
test_06_deploy_and_invalid_upgrade_kubernetes_cluster | `Error` | 1345.67 | test_kubernetes_clusters.py
test_07_deploy_and_scale_kubernetes_cluster | `Error` | 1351.71 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 1387.63 | test_kubernetes_clusters.py
ContextSuite context=TestListIdsParams>:setup | `Error` | 0.00 | test_list_ids_parameter.py
test_list_vms_metrics | `Error` | 2717.97 | test_metrics_api.py
test_nic_secondaryip_add_remove | `Error` | 2734.39 | test_multipleips_per_nic.py
test_network_acl | `Error` | 1355.86 | test_network_acl.py
test_delete_account | `Error` | 2720.52 | test_network.py
ContextSuite context=TestPortForwarding>:setup | `Error` | 2777.17 | test_network.py
ContextSuite context=TestPublicIP>:setup | `Error` | 2705.06 | test_network.py
test_reboot_router | `Error` | 2692.40 | test_network.py
test_releaseIP | `Error` | 2691.88 | test_network.py
ContextSuite context=TestRouterRules>:setup | `Error` | 5390.47 | test_network.py
test_01_nic | `Error` | 2847.72 | test_nic.py
test_oobm_zchange_password | `Error` | 5.75 | test_outofbandmanagement.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:setup | `Error` | 0.00 | test_password_server.py
test_01_create_delete_portforwarding_fornonvpc | `Error` | 2743.91 | test_portforwardingrules.py
test_01_add_primary_storage_disabled_host | `Error` | 16.53 | test_primary_storage.py
ContextSuite context=TestStorageTags>:setup | `Error` | 2917.97 | test_primary_storage.py
test_01_vpc_privategw_acl | `Failure` | 1349.11 | test_privategw_acl.py
test_02_vpc_privategw_static_routes | `Failure` | 1349.41 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 1352.97 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 1352.87 | test_privategw_acl.py
test_09_project_suspend | `Error` | 2742.88 | test_projects.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
ContextSuite context=TestScaleVm>:setup | `Error` | 0.00 | test_scale_vm.py
test_01_sys_vm_start | `Failure` | 0.09 | test_secondary_storage.py
ContextSuite context=TestServiceOfferings>:setup | `Error` | 1520.24 | test_service_offerings.py
ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
test_01_list_sec_storage_vm | `Failure` | 0.10 | test_ssvm.py
test_02_list_cpvm_vm | `Failure` | 0.08 | test_ssvm.py
test_03_ssvm_internals | `Failure` | 0.07 | test_ssvm.py
test_04_cpvm_internals | `Failure` | 0.06 | test_ssvm.py
test_05_stop_ssvm | `Failure` | 0.06 | test_ssvm.py
test_06_stop_cpvm | `Failure` | 0.07 | test_ssvm.py
test_07_reboot_ssvm | `Failure` | 0.05 | test_ssvm.py
test_08_reboot_cpvm | `Failure` | 0.04 | test_ssvm.py
test_09_destroy_ssvm | `Failure` | 0.07 | test_ssvm.py
test_10_destroy_cpvm | `Failure` | 0.07 | test_ssvm.py
test_02_create_template_with_checksum_sha1 | `Error` | 66.14 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 66.19 | test_templates.py
test_04_create_template_with_checksum_md5 | `Error` | 65.77 | test_templates.py
test_05_create_template_with_no_checksum | `Error` | 65.92 | test_templates.py
ContextSuite context=TestTemplates>:setup | `Error` | 2.52 | test_templates.py
ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestLBRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestNatRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestPublicIPUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestSnapshotUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVmUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVolumeUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVpnUsage>:setup | `Error` | 0.00 | test_usage.py
test_01_deploy_vm_on_specific_host | `Error` | 1348.91 | test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster | `Error` | 1347.72 | test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod | `Error` | 1353.82 | test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 1418.40 | test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod | `Error` | 1356.44 | test_vm_deployment_planner.py
ContextSuite context=Test01DeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py
ContextSuite context=Test02VMLifeCycle>:setup | `Error` | 0.00 | test_vm_life_cycle.py
ContextSuite context=TestChangeServiceOfferingForVmWithSnapshots>:setup | `Error` | 0.00 | test_vm_snapshots.py
ContextSuite context=TestVmSnapshot>:setup | `Error` | 0.00 | test_vm_snapshots.py
ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | test_volumes.py
ContextSuite context=TestVolumes>:setup | `Error` | 0.00 | test_volumes.py
ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py
ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-672406575
Packaging result: ✖centos7 ✖debian. JID-1716
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-671083060
@blueorangutan test matrix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670965667
@rhtyd a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware67, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#discussion_r471344055
##########
File path: api/src/main/java/com/cloud/storage/ImageStore.java
##########
@@ -21,6 +21,13 @@
public interface ImageStore extends Identity, InternalIdentity {
+ String ACS_PROPERTY_PREFIX = "ACS-property-";
+ String REQUIRED_NETWORK_PREFIX = "ACS-network-";
+ String DISK_DEFINITION_PREFIX = "ACS-disk-";
+ String OVF_HARDWARE_CONFIGURATION_PREFIX = "ACS-configuration-";
+ String OVF_HARDWARE_ITEM_PREFIX = "ACS-hardware-item-";
+ String OVF_EULA_SECTION_PREFIX = "ACS-eula-";
+
Review comment:
Minor nit - @nvazquez could this use a lowererd-case dot-joined like many other cloudstack such as `acs.property.`?
##########
File path: api/src/main/java/com/cloud/agent/api/storage/OVFHelper.java
##########
@@ -138,103 +155,88 @@ protected OVFPropertyTO createOVFPropertyFromNode(Node node) {
}
/**
- * Get properties from OVF file located on ovfFilePath
+ * Get properties from OVF XML string
*/
- public List<OVFPropertyTO> getOVFPropertiesFromFile(String ovfFilePath) throws ParserConfigurationException, IOException, SAXException {
- if (StringUtils.isBlank(ovfFilePath)) {
- return new ArrayList<>();
- }
- File ovfFile = new File(ovfFilePath);
- final Document doc = DocumentBuilderFactory.newInstance().newDocumentBuilder().parse(ovfFile);
+ protected List<OVFPropertyTO> getOVFPropertiesFromXmlString(final String ovfString) throws ParserConfigurationException, IOException, SAXException {
+ InputSource is = new InputSource(new StringReader(ovfString));
+ final Document doc = DocumentBuilderFactory.newInstance().newDocumentBuilder().parse(is);
return getConfigurableOVFPropertiesFromDocument(doc);
}
- /**
- * Get properties from OVF XML string
- */
- protected List<OVFPropertyTO> getOVFPropertiesXmlString(final String ovfFilePath) throws ParserConfigurationException, IOException, SAXException {
- InputSource is = new InputSource(new StringReader(ovfFilePath));
+ protected List<OVFConfigurationTO> getOVFDeploymentOptionsFromXmlString(final String ovfString) throws ParserConfigurationException, IOException, SAXException {
+ InputSource is = new InputSource(new StringReader(ovfString));
final Document doc = DocumentBuilderFactory.newInstance().newDocumentBuilder().parse(is);
- return getConfigurableOVFPropertiesFromDocument(doc);
+ return getDeploymentOptionsFromDocumentTree(doc);
}
- public List<DatadiskTO> getOVFVolumeInfo(final String ovfFilePath) {
+ protected List<OVFVirtualHardwareItemTO> getOVFVirtualHardwareSectionFromXmlString(final String ovfString) throws ParserConfigurationException, IOException, SAXException {
+ InputSource is = new InputSource(new StringReader(ovfString));
+ final Document doc = DocumentBuilderFactory.newInstance().newDocumentBuilder().parse(is);
+ return getVirtualHardwareItemsFromDocumentTree(doc);
+ }
+
+ protected List<OVFEulaSectionTO> getOVFEulaSectionFromXmlString(final String ovfString) throws ParserConfigurationException, IOException, SAXException {
+ InputSource is = new InputSource(new StringReader(ovfString));
+ final Document doc = DocumentBuilderFactory.newInstance().newDocumentBuilder().parse(is);
+ return getEulaSectionsFromDocument(doc);
+ }
+
+ public List<DatadiskTO> getOVFVolumeInfoFromFile(final String ovfFilePath) throws InternalErrorException {
if (StringUtils.isBlank(ovfFilePath)) {
- return new ArrayList<DatadiskTO>();
+ return new ArrayList<>();
+ }
+ Document doc = getDocumentFromFile(ovfFilePath);
+
+ return getOVFVolumeInfoFromFile(ovfFilePath, doc);
+ }
+
+ public List<DatadiskTO> getOVFVolumeInfoFromFile(String ovfFilePath, Document doc) throws InternalErrorException {
+ if (org.apache.commons.lang.StringUtils.isBlank(ovfFilePath)) {
+ return null;
}
- ArrayList<OVFFile> vf = new ArrayList<OVFFile>();
- ArrayList<OVFDisk> vd = new ArrayList<OVFDisk>();
File ovfFile = new File(ovfFilePath);
- try {
- final Document doc = DocumentBuilderFactory.newInstance().newDocumentBuilder().parse(new File(ovfFilePath));
- NodeList disks = doc.getElementsByTagName("Disk");
- NodeList files = doc.getElementsByTagName("File");
- NodeList items = doc.getElementsByTagName("Item");
- boolean toggle = true;
- for (int j = 0; j < files.getLength(); j++) {
- Element file = (Element)files.item(j);
- OVFFile of = new OVFFile();
- of._href = file.getAttribute("ovf:href");
- if (of._href.endsWith("vmdk") || of._href.endsWith("iso")) {
- of._id = file.getAttribute("ovf:id");
- String size = file.getAttribute("ovf:size");
- if (StringUtils.isNotBlank(size)) {
- of._size = Long.parseLong(size);
- } else {
- String dataDiskPath = ovfFile.getParent() + File.separator + of._href;
- File this_file = new File(dataDiskPath);
- of._size = this_file.length();
- }
- of.isIso = of._href.endsWith("iso");
- if (toggle && !of.isIso) {
- of._bootable = true;
- toggle = !toggle;
- }
- vf.add(of);
- }
- }
- for (int i = 0; i < disks.getLength(); i++) {
- Element disk = (Element)disks.item(i);
- OVFDisk od = new OVFDisk();
- String virtualSize = disk.getAttribute("ovf:capacity");
- od._capacity = NumberUtils.toLong(virtualSize, 0L);
- String allocationUnits = disk.getAttribute("ovf:capacityAllocationUnits");
- od._diskId = disk.getAttribute("ovf:diskId");
- od._fileRef = disk.getAttribute("ovf:fileRef");
- od._populatedSize = NumberUtils.toLong(disk.getAttribute("ovf:populatedSize"));
-
- if ((od._capacity != 0) && (allocationUnits != null)) {
-
- long units = 1;
- if (allocationUnits.equalsIgnoreCase("KB") || allocationUnits.equalsIgnoreCase("KiloBytes") || allocationUnits.equalsIgnoreCase("byte * 2^10")) {
- units = ResourceType.bytesToKiB;
- } else if (allocationUnits.equalsIgnoreCase("MB") || allocationUnits.equalsIgnoreCase("MegaBytes") || allocationUnits.equalsIgnoreCase("byte * 2^20")) {
- units = ResourceType.bytesToMiB;
- } else if (allocationUnits.equalsIgnoreCase("GB") || allocationUnits.equalsIgnoreCase("GigaBytes") || allocationUnits.equalsIgnoreCase("byte * 2^30")) {
- units = ResourceType.bytesToGiB;
- }
- od._capacity = od._capacity * units;
- }
- od._controller = getControllerType(items, od._diskId);
- vd.add(od);
- }
+ NodeList disks = doc.getElementsByTagName("Disk");
+ NodeList files = doc.getElementsByTagName("File");
+ NodeList items = doc.getElementsByTagName("Item");
+ List<OVFFile> vf = extractFilesFromOvfDocumentTree(ovfFile, files);
- } catch (SAXException | IOException | ParserConfigurationException e) {
- s_logger.error("Unexpected exception caught while parsing ovf file:" + ovfFilePath, e);
- throw new CloudRuntimeException(e);
+ List<OVFDisk> vd = extractDisksFromOvfDocumentTree(disks, items);
+
+ List<DatadiskTO> diskTOs = matchDisksToFilesAndGenerateDiskTOs(ovfFile, vf, vd);
+
+ moveFirstIsoToEndOfDiskList(diskTOs);
+
+ return diskTOs;
+ }
+
+ /**
+ * check if first disk is an iso move it to the end. the semantics of this are not complete as more than one ISO may be there and theoretically an OVA may only contain ISOs
+ *
+ */
+ private void moveFirstIsoToEndOfDiskList(List<DatadiskTO> diskTOs) {
+ DatadiskTO fd = diskTOs.get(0);
Review comment:
Should we check for diskTOs for NPE?
##########
File path: api/src/main/java/org/apache/cloudstack/api/net/NetworkPrerequisiteTO.java
##########
@@ -0,0 +1,124 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.net;
+
+/**
+ * container for the network prerequisites as found in the appliance template
+ *
+ * for OVA:
+ * {code}
+ * <Network ovf:name="Management0-0">
+ * <Description>Management Network Interface</Description>
+ * </Network>
+ * {code}
+ * {code}
+ * <Item>
+ * <rasd:AddressOnParent>7</rasd:AddressOnParent>
+ * <rasd:AutomaticAllocation>true</rasd:AutomaticAllocation>
+ * <rasd:Connection>Management0-0</rasd:Connection>
+ * <rasd:Description>E1000 Ethernet adapter on "Management Network"</rasd:Description>
+ * <rasd:ElementName>Network adapter 1</rasd:ElementName>
+ * <rasd:InstanceID>6</rasd:InstanceID>
+ * <rasd:ResourceSubType>E1000</rasd:ResourceSubType>
+ * <rasd:ResourceType>10</rasd:ResourceType>
+ * </Item>
+ * {code}
+ */
+public class NetworkPrerequisiteTO {
+ String name; // attribute on Network should match <rasd:Connection> on Item (virtual hardware)
+ String networkDescription;
+
+ int addressOnParent; // or String?
+ boolean automaticAllocation;
+ String nicDescription;
+ String elementName;
+ int InstanceID; // or String?
+ String resourceSubType;
+ String resourceType; // or int?
Review comment:
@nvazquez can you cleanup comments?
##########
File path: api/src/main/java/com/cloud/agent/api/storage/OVFHelper.java
##########
@@ -404,6 +488,270 @@ OVFDisk getDisk(String fileRef, List<OVFDisk> disks) {
return null;
}
+ public List<NetworkPrerequisiteTO> getNetPrerequisitesFromDocument(Document doc) throws InternalErrorException {
+ if (doc == null) {
+ if (s_logger.isTraceEnabled()) {
+ s_logger.trace("no document to parse; returning no prerequiste networks");
+ }
+ return Collections.emptyList();
+ }
+
+ Map<String, NetworkPrerequisiteTO> nets = getNetworksFromDocumentTree(doc);
+
+ checkForOnlyOneSystemNode(doc);
+
+ matchNicsToNets(nets, doc);
+
+ return new ArrayList<>(nets.values());
+ }
+
+ private void matchNicsToNets(Map<String, NetworkPrerequisiteTO> nets, Node systemElement) {
+ final DocumentTraversal traversal = (DocumentTraversal) systemElement;
+ final NodeIterator iterator = traversal.createNodeIterator(systemElement, NodeFilter.SHOW_ELEMENT, null, true);
+ if (s_logger.isTraceEnabled()) {
+ s_logger.trace(String.format("starting out with %d network-prerequisites, parsing hardware",nets.size()));
+ }
+ int nicCount = 0;
+ for (Node n = iterator.nextNode(); n != null; n = iterator.nextNode()) {
+ final Element e = (Element) n;
+ if ("rasd:Connection".equals(e.getTagName())) {
+ nicCount++;
+ String name = e.getTextContent(); // should be in our nets
+ if(nets.get(name) == null) {
+ if(s_logger.isInfoEnabled()) {
+ s_logger.info(String.format("found a nic definition without a network definition byname %s, adding it to the list.", name));
+ }
+ nets.put(name, new NetworkPrerequisiteTO());
+ }
+ NetworkPrerequisiteTO thisNet = nets.get(name);
+ if (e.getParentNode() != null) {
+ fillNicPrerequisites(thisNet,e.getParentNode());
+ }
+ }
+ }
+ if (s_logger.isTraceEnabled()) {
+ s_logger.trace(String.format("ending up with %d network-prerequisites, parsed %d nics", nets.size(), nicCount));
+ }
+ }
+
+ /**
+ * get all the stuff from parent node
+ * TODO check for completeness and optionality
+ *
+ * @param nic the object to carry through the system
+ * @param parentNode the xml container node for nic data
+ */
+ private void fillNicPrerequisites(NetworkPrerequisiteTO nic, Node parentNode) {
+// * <rasd:AddressOnParent>7</rasd:AddressOnParent>
+ try {
Review comment:
@nvazquez can you fix the comments indents or remove if not necessary
##########
File path: api/src/main/java/org/apache/cloudstack/api/command/user/template/ListTemplatesCmd.java
##########
@@ -99,7 +99,7 @@
public EnumSet<ApiConstants.DomainDetails> getDetails() throws InvalidParameterValueException {
EnumSet<ApiConstants.DomainDetails> dv;
if (CollectionUtils.isEmpty(viewDetails)) {
- dv = EnumSet.of(ApiConstants.DomainDetails.min);
+ dv = EnumSet.of(ApiConstants.DomainDetails.all);
Review comment:
@nvazquez can we use `min` when we don't want details by default, otherwise return all details like old behaviour?
##########
File path: api/src/main/java/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java
##########
@@ -221,10 +224,16 @@
@Parameter(name = ApiConstants.COPY_IMAGE_TAGS, type = CommandType.BOOLEAN, since = "4.13", description = "if true the image tags (if any) will be copied to the VM, default value is false")
private Boolean copyImageTags;
- @Parameter(name = ApiConstants.OVF_PROPERTIES, type = CommandType.MAP, since = "4.13",
- description = "used to specify the OVF properties.")
+ @Parameter(name = ApiConstants.PROPERTIES, type = CommandType.MAP, since = "4.15",
+ description = "used to specify the vApp properties.")
@LogLevel(LogLevel.Log4jLevel.Off)
- private Map vmOvfProperties;
+ private Map vAppProperties;
+
+ @Parameter(name = ApiConstants.NIC_NETWORK_LIST, type = CommandType.MAP, since = "4.15",
+ description = "used to specify the vApp network mapping." +
Review comment:
Should add an extra line to explain what we mean by vApp (i.e. network mapping of a vApp VMware template?)
##########
File path: core/src/main/java/com/cloud/storage/resource/StorageProcessor.java
##########
@@ -33,6 +33,10 @@
import com.cloud.agent.api.Answer;
public interface StorageProcessor {
+
+ String REQUEST_TEMPLATE_RELOAD = "request template reload";
+ String COPY_NOT_NEEDED_FOR_DEPLOY_AS_IS = "copy volume not needed for deploy as is";
Review comment:
@nvazquez where and how is this used?
##########
File path: core/src/main/java/com/cloud/storage/template/OVAProcessor.java
##########
@@ -53,73 +64,142 @@ public FormatInfo process(String templatePath, ImageFormat format, String templa
@Override
public FormatInfo process(String templatePath, ImageFormat format, String templateName, long processTimeout) throws InternalErrorException {
- if (format != null) {
- if (s_logger.isInfoEnabled()) {
- s_logger.info("We currently don't handle conversion from " + format + " to OVA.");
- }
+ if (! conversionChecks(format)){
return null;
}
- s_logger.info("Template processing. templatePath: " + templatePath + ", templateName: " + templateName);
+ LOGGER.info("Template processing. templatePath: " + templatePath + ", templateName: " + templateName);
String templateFilePath = templatePath + File.separator + templateName + "." + ImageFormat.OVA.getFileExtension();
if (!_storage.exists(templateFilePath)) {
- if (s_logger.isInfoEnabled()) {
- s_logger.info("Unable to find the vmware template file: " + templateFilePath);
+ if (LOGGER.isInfoEnabled()) {
+ LOGGER.info("Unable to find the vmware template file: " + templateFilePath);
}
return null;
}
- s_logger.info("Template processing - untar OVA package. templatePath: " + templatePath + ", templateName: " + templateName);
- String templateFileFullPath = templatePath + File.separator + templateName + "." + ImageFormat.OVA.getFileExtension();
- File templateFile = new File(templateFileFullPath);
- Script command = new Script("tar", processTimeout, s_logger);
- command.add("--no-same-owner");
- command.add("--no-same-permissions");
- command.add("-xf", templateFileFullPath);
- command.setWorkDir(templateFile.getParent());
- String result = command.execute();
- if (result != null) {
- s_logger.info("failed to untar OVA package due to " + result + ". templatePath: " + templatePath + ", templateName: " + templateName);
- throw new InternalErrorException("failed to untar OVA package");
+ String templateFileFullPath = unpackOva(templatePath, templateName, processTimeout);
+
+ setFileSystemAccessRights(templatePath);
+
+ FormatInfo info = createFormatInfo(templatePath, templateName, templateFilePath, templateFileFullPath);
+
+ // The intention is to use the ova file as is for deployment and use processing result only for
+ // - property assessment and
+ // - reconsiliation of
+ // - - disks,
+ // - - networks and
+ // - - compute dimensions.
Review comment:
@nvazquez check and remove comments
##########
File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
##########
@@ -745,87 +749,169 @@ public void doInTransactionWithoutResult(final TransactionStatus status) {
@Override
@DB
public void allocate(final VirtualMachineProfile vm, final LinkedHashMap<? extends Network, List<? extends NicProfile>> networks, final Map<String, Map<Integer, String>> extraDhcpOptions) throws InsufficientCapacityException,
- ConcurrentOperationException {
+ ConcurrentOperationException {
Transaction.execute(new TransactionCallbackWithExceptionNoReturn<InsufficientCapacityException>() {
@Override
public void doInTransactionWithoutResult(final TransactionStatus status) throws InsufficientCapacityException {
- int deviceId = 0;
- int size = 0;
- for (final Network ntwk : networks.keySet()) {
- final List<? extends NicProfile> profiles = networks.get(ntwk);
- if (profiles != null && !profiles.isEmpty()) {
- size = size + profiles.size();
- } else {
- size = size + 1;
- }
+ if (s_logger.isTraceEnabled()) {
+ s_logger.trace(String.format("allocating networks for %s(template %s); %d networks",vm.getInstanceName(), vm.getTemplate().getUuid(), networks.size()));
}
+ int deviceId = 0;
+ int size;
+ size = determineNumberOfNicsRequired();
final boolean[] deviceIds = new boolean[size];
Arrays.fill(deviceIds, false);
+ List<Pair<Network, NicProfile>> profilesList = getOrderedNetworkNicProfileMapping(networks);
final List<NicProfile> nics = new ArrayList<NicProfile>(size);
NicProfile defaultNic = null;
+ Network nextNetwork = null;
+ for (Pair <Network, NicProfile> networkNicPair : profilesList) {
+ nextNetwork = networkNicPair.first();
+ Pair<NicProfile, Integer> newDeviceInfo = addRequestedNicToNicListWithDeviceNumberAndRetrieveDefaultDevice(networkNicPair.second(), deviceIds, deviceId, nextNetwork, nics, defaultNic);
+ defaultNic = newDeviceInfo.first();
+ deviceId = newDeviceInfo.second();
+ }
+ createExtraNics(size, nics, nextNetwork);
+
+ if (nics.size() == 1) {
+ nics.get(0).setDefaultNic(true);
+ }
+ }
+ /**
+ * private transaction method to check and add devices to the nic list and update the info
+ */
+ Pair<NicProfile,Integer> addRequestedNicToNicListWithDeviceNumberAndRetrieveDefaultDevice(NicProfile requested, boolean[] deviceIds, int deviceId, Network nextNetwork, List<NicProfile> nics, NicProfile defaultNic)
+ throws InsufficientAddressCapacityException, InsufficientVirtualNetworkCapacityException {
+ Pair<NicProfile, Integer> rc = new Pair<>(null,null);
+ Boolean isDefaultNic = false;
+ if (vm != null && requested != null && requested.isDefaultNic()) {
+ isDefaultNic = true;
+ }
+
+ while (deviceIds[deviceId] && deviceId < deviceIds.length) {
+ deviceId++;
+ }
+
+ final Pair<NicProfile, Integer> vmNicPair = allocateNic(requested, nextNetwork, isDefaultNic, deviceId, vm);
+ NicProfile vmNic = null;
+ if (vmNicPair != null) {
+ vmNic = vmNicPair.first();
+ if (vmNic == null) {
+ return rc;
+ }
+ deviceId = vmNicPair.second();
+ }
+
+ final int devId = vmNic.getDeviceId();
+ if (devId >= deviceIds.length) {
+ throw new IllegalArgumentException("Device id for nic is too large: " + vmNic);
+ }
+ if (deviceIds[devId]) {
+ throw new IllegalArgumentException("Conflicting device id for two different nics: " + vmNic);
+ }
+
+ deviceIds[devId] = true;
+
+ if (vmNic.isDefaultNic()) {
+ if (defaultNic != null) {
+ throw new IllegalArgumentException("You cannot specify two nics as default nics: nic 1 = " + defaultNic + "; nic 2 = " + vmNic);
+ }
+ defaultNic = vmNic;
+ }
+
+ nics.add(vmNic);
+ vm.addNic(vmNic);
+ saveExtraDhcpOptions(nextNetwork.getUuid(), vmNic.getId(), extraDhcpOptions);
+ rc.first(defaultNic);
+ rc.second(deviceId);
+ return rc;
+ }
+
+ /**
+ * private transaction method to get oredered list of Network and NicProfile pair
+ * @return ordered list of Network and NicProfile pair
+ * @param networks the map od networks to nic profiles list
+ */
+ private List<Pair<Network, NicProfile>> getOrderedNetworkNicProfileMapping(final LinkedHashMap<? extends Network, List<? extends NicProfile>> networks) {
+ List<Pair<Network, NicProfile>> profilesList = new ArrayList<>();
for (final Map.Entry<? extends Network, List<? extends NicProfile>> network : networks.entrySet()) {
- final Network config = network.getKey();
List<? extends NicProfile> requestedProfiles = network.getValue();
if (requestedProfiles == null) {
requestedProfiles = new ArrayList<NicProfile>();
}
if (requestedProfiles.isEmpty()) {
requestedProfiles.add(null);
}
-
for (final NicProfile requested : requestedProfiles) {
- Boolean isDefaultNic = false;
- if (vm != null && requested != null && requested.isDefaultNic()) {
- isDefaultNic = true;
- }
-
- while (deviceIds[deviceId] && deviceId < deviceIds.length) {
- deviceId++;
- }
-
- final Pair<NicProfile, Integer> vmNicPair = allocateNic(requested, config, isDefaultNic, deviceId, vm);
- NicProfile vmNic = null;
- if (vmNicPair != null) {
- vmNic = vmNicPair.first();
- if (vmNic == null) {
- continue;
- }
- deviceId = vmNicPair.second();
- }
-
- final int devId = vmNic.getDeviceId();
- if (devId >= deviceIds.length) {
- throw new IllegalArgumentException("Device id for nic is too large: " + vmNic);
- }
- if (deviceIds[devId]) {
- throw new IllegalArgumentException("Conflicting device id for two different nics: " + vmNic);
+ profilesList.add(new Pair<Network, NicProfile>(network.getKey(), requested));
+ }
+ }
+ profilesList.sort(new Comparator<Pair<Network, NicProfile>>() {
+ @Override
+ public int compare(Pair<Network, NicProfile> pair1, Pair<Network, NicProfile> pair2) {
+ int profile1Order = Integer.MAX_VALUE;
+ int profile2Order = Integer.MAX_VALUE;
+ if (pair1 != null && pair1.second() != null && pair1.second().getOrderIndex() != null) {
+ profile1Order = pair1.second().getOrderIndex();
}
-
- deviceIds[devId] = true;
-
- if (vmNic.isDefaultNic()) {
- if (defaultNic != null) {
- throw new IllegalArgumentException("You cannot specify two nics as default nics: nic 1 = " + defaultNic + "; nic 2 = " + vmNic);
- }
- defaultNic = vmNic;
+ if (pair2 != null && pair2.second() != null && pair2.second().getOrderIndex() != null) {
+ profile2Order = pair2.second().getOrderIndex();
}
+ return profile1Order - profile2Order;
+ }
+ });
+ return profilesList;
+ }
- nics.add(vmNic);
- vm.addNic(vmNic);
- saveExtraDhcpOptions(config.getUuid(), vmNic.getId(), extraDhcpOptions);
+ /**
+ * private transaction method to run over the objects and determine nic requirements
+ * @return the total numer of nics required
+ */
+ private int determineNumberOfNicsRequired() {
+ int size = 0;
+ for (final Network ntwk : networks.keySet()) {
+ final List<? extends NicProfile> profiles = networks.get(ntwk);
+ if (profiles != null && !profiles.isEmpty()) {
+ size = size + profiles.size();
+ } else {
+ size = size + 1;
}
}
+
+ List<NetworkPrerequisiteTO> netprereqs = templateDetailsDao.listNetworkRequirementsByTemplateId(vm.getTemplate().getId());
+ // hack: add last network untill enough ids
Review comment:
@nvazquez check and improve or remove the comment
##########
File path: core/src/main/java/com/cloud/resource/ServerResource.java
##########
@@ -31,6 +31,9 @@
* ServerResource is a generic container to execute commands sent
*/
public interface ServerResource extends Manager {
+
+ String ORIGINAL_FILE_EXTENSION = ".orig";
Review comment:
@nvazquez where and how is this used?
##########
File path: api/src/main/java/org/apache/cloudstack/api/ApiConstants.java
##########
@@ -260,7 +260,8 @@
public static final String OUTOFBANDMANAGEMENT_POWERSTATE = "outofbandmanagementpowerstate";
public static final String OUTOFBANDMANAGEMENT_ENABLED = "outofbandmanagementenabled";
public static final String OUTPUT = "output";
- public static final String OVF_PROPERTIES = "ovfproperties";
+ public static final String PROPERTIES = "properties";
+ public static final String ACS_PROPERTY = "ACS-property";
Review comment:
Is ACS_PROPERTY used by any API response?
##########
File path: api/src/main/java/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java
##########
@@ -162,6 +162,13 @@
description = "true if template should bypass Secondary Storage and be downloaded to Primary Storage on deployment")
private Boolean directDownload;
+ @Parameter(name= ApiConstants.DEPLOY_AS_IS,
+ type = CommandType.BOOLEAN,
+ description = "true if template should not strip and define disks and networks but leave those to the template definition",
Review comment:
Should we mention this is for VMware/ova only?
##########
File path: api/src/main/java/org/apache/cloudstack/api/response/TemplateResponse.java
##########
@@ -189,18 +191,28 @@
@Param(description = "KVM Only: true if template is directly downloaded to Primary Storage bypassing Secondary Storage")
private Boolean directDownload;
+ @SerializedName(ApiConstants.DEPLOY_AS_IS)
+ @Param(description = "VMware only: true if template is deployed without orchestrating disks and networks but \"as-is\" defined in the template.")
+ private Boolean deployAsIs;
+
@SerializedName("parenttemplateid")
@Param(description = "if Datadisk template, then id of the root disk template this template belongs to")
+ @Deprecated(since = "4.15")
private String parentTemplateId;
@SerializedName("childtemplates")
@Param(description = "if root disk template, then ids of the datas disk templates this template owns")
+ @Deprecated(since = "4.15")
private Set<ChildTemplateResponse> childTemplates;
Review comment:
@nvazquez did we get rid of child-template design from old multi-disk ova code? Can this be removed?
##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
##########
@@ -1904,7 +1924,22 @@ protected StartAnswer execute(StartCommand cmd) {
}
}
+ // The number of disks changed must be 0 for install as is, as the VM is a clone
+ int disksChanges = !installAsIs ? disks.length : 0;
int totalChangeDevices = disks.length + nics.length;
+ int hackDeviceCount = 0;
+ if (diskInfoBuilder != null) {
+ hackDeviceCount += diskInfoBuilder.getDiskCount();
+ }
+ hackDeviceCount += nicDevices == null ? 0 : nicDevices.length;
+ // vApp cdrom device
+ // HACK ALERT: ovf properties might not be the only or defining feature of vApps; needs checking
Review comment:
@nvazquez this is not necessary if we're cloning a deploy as-is template, there is no need to add the hack to add another cdrom device. Please check and remove this code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-671149338
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-677937255
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez removed a comment on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
nvazquez removed a comment on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670100956
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670828110
@blueorangutan test matrix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-678758797
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-1804
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr edited a comment on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
shwstppr edited a comment on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-673989878
@blueorangutan package
@rhtyd fixed syntax issue with test_vm_life_cycle.py file.
Last test run shouldn't be affected by this change as tests will be overridden by Trillian there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-678983845
@andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-674491471
<b>Trillian test result (tid-2463)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45527 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4250-t2463-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 80 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 505.82 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | `Error` | 3862.80 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | `Error` | 3862.82 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Error` | 0.01 | test_vpc_redundant.py
ContextSuite context=TestVPCRedundancy>:teardown | `Error` | 0.01 | test_vpc_redundant.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670160604
Packaging result: ✔centos7 ✔debian. JID-1668
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-671065054
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-673745797
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-675899773
@andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-671068123
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670270492
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-673220652
@blueorangutan test matrix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-673758305
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-686748026
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670965620
@blueorangutan test matrix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-673156767
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-688474956
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670828151
@nvazquez a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware67, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-687619074
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-677938219
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-677937661
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-682425610
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-673516227
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-671149467
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-671156457
Packaging result: ✔centos7 ✔debian. JID-1685
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-671511729
Packaging result: ✔centos7 ✔debian. JID-1699
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on a change in pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on a change in pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#discussion_r474564204
##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql
##########
@@ -309,3 +309,86 @@ INSERT IGNORE INTO `cloud`.`hypervisor_capabilities`(uuid, hypervisor_type, hype
-- Copy XenServer 8.0 hypervisor guest OS mappings to XenServer8.1
INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) SELECT UUID(),'Xenserver', '8.1.0', guest_os_name, guest_os_id, utc_timestamp(), 0 FROM `cloud`.`guest_os_hypervisor` WHERE hypervisor_type='Xenserver' AND hypervisor_version='8.0.0';
+
+-- Add mincpu, maxcpu, minmemory and maxmemory to the view supporting constrained offerings
+ALTER VIEW `cloud`.`service_offering_view` AS
Review comment:
@nvazquez afaik, we've discussed that we always want to drop/replace view, not alter it, due to whatever issues someone noticed in some cases
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670146341
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-678646621
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-671529013
@rhtyd a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware67, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-672375829
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-674516697
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-674619380
<b>Trillian test result (tid-2468)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 49820 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4250-t2468-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 82 look OK, 3 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_deploy_kubernetes_cluster | `Error` | 0.06 | test_kubernetes_clusters.py
test_02_deploy_kubernetes_ha_cluster | `Error` | 0.04 | test_kubernetes_clusters.py
test_04_deploy_and_upgrade_kubernetes_cluster | `Error` | 0.03 | test_kubernetes_clusters.py
test_05_deploy_and_upgrade_kubernetes_ha_cluster | `Error` | 0.03 | test_kubernetes_clusters.py
test_06_deploy_and_invalid_upgrade_kubernetes_cluster | `Error` | 0.03 | test_kubernetes_clusters.py
test_07_deploy_and_scale_kubernetes_cluster | `Error` | 0.03 | test_kubernetes_clusters.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 597.04 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Error` | 359.07 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | `Error` | 3942.39 | test_vpc_redundant.py
test_hostha_kvm_host_fencing | `Error` | 106.57 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670541616
<b>Trillian test result (tid-2290)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44595 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4250-t2290-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 81 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_reset_vm_on_reboot | `Error` | 6.19 | test_reset_vm_on_reboot.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Error` | 420.63 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | `Failure` | 148.04 | test_vpc_redundant.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-673629031
<b>Trillian test result (tid-2390)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 52414 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4250-t2390-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 77 look OK, 3 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_3d_gpu_support | `Error` | 388.36 | test_deploy_vgpu_enabled_vm.py
test_07_reboot_ssvm | `Failure` | 42.61 | test_ssvm.py
test_11_migrate_vm | `Error` | 59.52 | test_vm_life_cycle.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-673758039
@blueorangutan test centos7 vmware-67u3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-677938219
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-684566033
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670160604
Packaging result: ✔centos7 ✔debian. JID-1668
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-671493719
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-673981136
@nvazquez I kicked travis failing job a few times, looks like a regresion in either marvin or the test :
```
+---------+----------------------+-------+--------------------+
| Test | Result | Time | Test file |
+=========+======================+=======+====================+
| runTest | exceptions.TypeError | 0.001 | test_vm_life_cycle |
+---------+----------------------+-------+--------------------+
```
```
======================================================================
ERROR: Failure: SyntaxError (invalid syntax (test_vm_life_cycle.py, line 31))
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/travis/.local/lib/python2.7/site-packages/nose/case.py", line 132, in run
self.beforeTest(result)
File "/home/travis/.local/lib/python2.7/site-packages/nose/case.py", line 74, in beforeTest
beforeTest(self.test)
File "/home/travis/.local/lib/python2.7/site-packages/nose/proxy.py", line 117, in beforeTest
self.plugins.beforeTest(self.test)
File "/home/travis/.local/lib/python2.7/site-packages/nose/plugins/manager.py", line 99, in __call__
return self.call(*arg, **kw)
File "/home/travis/.local/lib/python2.7/site-packages/nose/plugins/manager.py", line 167, in simple
result = meth(*arg, **kw)
File "/home/travis/.local/lib/python2.7/site-packages/marvin/marvinPlugin.py", line 174, in beforeTest
join([self.__identifier, self.__testName])
TypeError: sequence item 0: expected string, NoneType found
-------------------- >> begin captured logging << --------------------
CSLog: CRITICAL: EXCEPTION: Failure:: ['Traceback (most recent call last):\n', ' File "/home/travis/.local/lib/python2.7/site-packages/nose/case.py", line 132, in run\n self.beforeTest(result)\n', ' File "/home/travis/.local/lib/python2.7/site-packages/nose/case.py", line 74, in beforeTest\n beforeTest(self.test)\n', ' File "/home/travis/.local/lib/python2.7/site-packages/nose/proxy.py", line 117, in beforeTest\n self.plugins.beforeTest(self.test)\n', ' File "/home/travis/.local/lib/python2.7/site-packages/nose/plugins/manager.py", line 99, in __call__\n return self.call(*arg, **kw)\n', ' File "/home/travis/.local/lib/python2.7/site-packages/nose/plugins/manager.py", line 167, in simple\n result = meth(*arg, **kw)\n', ' File "/home/travis/.local/lib/python2.7/site-packages/marvin/marvinPlugin.py", line 174, in beforeTest\n join([self.__identifier, self.__testName])\n', 'TypeError: sequence item 0: expected string, NoneType found\n']
--------------------- >> end captured logging << ---------------------
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670270690
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670417687
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-675917994
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670146341
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-687625701
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1896
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-673938170
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-673395077
@nvazquez @shwstppr can you fix conflicts? thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-673220868
@nvazquez a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware67, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-672894087
Packaging result: ✔centos7 ✔debian. JID-1729
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-671068307
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-672376270
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-688440731
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-678983372
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a change in pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
nvazquez commented on a change in pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#discussion_r471439642
##########
File path: api/src/main/java/org/apache/cloudstack/api/response/TemplateResponse.java
##########
@@ -189,18 +191,28 @@
@Param(description = "KVM Only: true if template is directly downloaded to Primary Storage bypassing Secondary Storage")
private Boolean directDownload;
+ @SerializedName(ApiConstants.DEPLOY_AS_IS)
+ @Param(description = "VMware only: true if template is deployed without orchestrating disks and networks but \"as-is\" defined in the template.")
+ private Boolean deployAsIs;
+
@SerializedName("parenttemplateid")
@Param(description = "if Datadisk template, then id of the root disk template this template belongs to")
+ @Deprecated(since = "4.15")
private String parentTemplateId;
@SerializedName("childtemplates")
@Param(description = "if root disk template, then ids of the datas disk templates this template owns")
+ @Deprecated(since = "4.15")
private Set<ChildTemplateResponse> childTemplates;
Review comment:
Not removed, but unused when templates are registered "as-is"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-677952234
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-1798
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-671493143
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org