You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/02/26 09:04:53 UTC

[GitHub] [incubator-tvm] liangfu commented on issue #3934: [Runtime] MISRA-C compliant TVM runtime

liangfu commented on issue #3934: [Runtime] MISRA-C compliant TVM runtime
URL: https://github.com/apache/incubator-tvm/pull/3934#issuecomment-591315719
 
 
   > is it possible to still expose the current TVM C runtime API?
   
   Yes, I have already made current implement compatible with c_runtime_api.h and dlpack protocol. However, as MISRA C suggests
   * Avoiding possible compiler differences, for example, the size of a C integer may vary but an INT16 is always 16 bits. 
   * Avoiding using functions and constructs that are prone to failure, for example, malloc may fail.
   
   (see https://en.wikipedia.org/wiki/MISRA_C#Categorization ), some exceptions in the MISRA compliance are made to be compatible with current TVM C runtime API.
   
   I think all review comments have been addressed, please take another look. 
   
   cc @tqchen @ajtulloch @nhynes 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services