You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@creadur.apache.org by GitBox <gi...@apache.org> on 2021/04/22 08:25:56 UTC

[GitHub] [creadur-rat] kalgon opened a new pull request #20: RAT-207: Properly report thread safety to Maven

kalgon opened a new pull request #20:
URL: https://github.com/apache/creadur-rat/pull/20


   AFAIK, the rat mojos seem to be thread-safe.
   
   Nevertheless, If that change requires proper testing, I could write some tests (but I would need some guiding on how to do that).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [creadur-rat] khmarbaise commented on pull request #20: RAT-207: Properly report thread safety to Maven

Posted by GitBox <gi...@apache.org>.
khmarbaise commented on pull request #20:
URL: https://github.com/apache/creadur-rat/pull/20#issuecomment-835230117


   No you can't do more. The point is by using threadSafe only a hint that the plugin is being able to run during `mvn -T XXX` and the plugin does not use/need resources from outside which could be a problem in such cases.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [creadur-rat] ottlinger commented on pull request #20: RAT-207: Properly report thread safety to Maven

Posted by GitBox <gi...@apache.org>.
ottlinger commented on pull request #20:
URL: https://github.com/apache/creadur-rat/pull/20#issuecomment-824681613


   @kalgon thanks for reaching out to RAT.
   
   @khmarbaise do you have any suggestions concering this PR? Is there anything else that needs to be done to test this change?
   
   Thanks everybody :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [creadur-rat] ottlinger commented on pull request #20: RAT-207: Properly report thread safety to Maven

Posted by GitBox <gi...@apache.org>.
ottlinger commented on pull request #20:
URL: https://github.com/apache/creadur-rat/pull/20#issuecomment-835474970


   @kalgon thanks for your contribution.
   
   @khmarbaise thanks :)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [creadur-rat] ottlinger merged pull request #20: RAT-207: Properly report thread safety to Maven

Posted by GitBox <gi...@apache.org>.
ottlinger merged pull request #20:
URL: https://github.com/apache/creadur-rat/pull/20


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org