[GitHub] [ozone] amaliujia commented on a change in pull request #1721: HDDS-4567: SCMContext Phase 1 - Raft Related Info

[GitBox <gi...@apache.org>]

amaliujia commented on a change in pull request #1721:
URL: https://github.com/apache/ozone/pull/1721#discussion_r546204324



##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/CloseContainerEventHandler.java
##########
@@ -74,14 +79,13 @@ public void onMessage(ContainerID containerID, EventPublisher publisher) {
           .getContainer(containerID);
       // Send close command to datanodes, if the container is in CLOSING state
       if (container.getState() == LifeCycleState.CLOSING) {
+        SCMCommand<?> command = new CloseContainerCommand(
+            containerID.getId(), container.getPipelineID());
+        command.setTerm(scmContext.getTerm());

Review comment:
       Question:
   when you do decide to throw the NotLeaderException out rather than handling immediately after `scmContext.getTerm()`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org