[GitHub] [trafficserver] masaori335 commented on a diff in pull request #8893: Fix % with PROXY Protocol

[GitBox <gi...@apache.org>]

masaori335 commented on code in PR #8893:
URL: https://github.com/apache/trafficserver/pull/8893#discussion_r892026814


##########
proxy/ProtocolProbeSessionAccept.cc:
##########
@@ -123,7 +123,6 @@ struct ProtocolProbeTrampoline : public Continuation, public ProtocolProbeSessio
 
       if (netvc->has_proxy_protocol(reader)) {
         Debug("proxyprotocol", "ioCompletionEvent: http has proxy protocol header");
-        netvc->set_remote_addr(netvc->get_proxy_protocol_src_addr());

Review Comment:
   This is the main change.



##########
iocore/net/SSLNetVConnection.cc:
##########
@@ -455,7 +454,6 @@ SSLNetVConnection::read_raw_data()
 
     if (this->has_proxy_protocol(buffer, &r)) {
       Debug("proxyprotocol", "ssl has proxy protocol header");
-      set_remote_addr(get_proxy_protocol_src_addr());

Review Comment:
   This is the main change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org