You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/08/03 12:09:35 UTC
[GitHub] [kafka] jlprat opened a new pull request #10784: KAFKA-12862: Update Scala fmt library and apply fixes
jlprat opened a new pull request #10784:
URL: https://github.com/apache/kafka/pull/10784
Updates the scala fmt to the latest stable version
Applies all the style fixes (all source code changes are done by scala
fmt)
Removes setting about dangling parentheses as `true` is already the
default
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat edited a comment on pull request #10784: KAFKA-12862: Update Scala fmt library and apply fixes
Posted by GitBox <gi...@apache.org>.
jlprat edited a comment on pull request #10784:
URL: https://github.com/apache/kafka/pull/10784#issuecomment-887524211
Thanks for the review @vvcephei !
Actually, the spotless task executes the scalafmt in this gradle config, this means running `./gradlew spotlessScalaCheck` will analyze all Scala files and complain about violations in the code. Then running `./gradlew :spotlessScalaApply` will fix any formatting discrepancies.
Alternatively, one can configure IntelliJ or VS Code to run scalafmt and it will pick the existing configuration in the kafka repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #10784: KAFKA-12862: Update Scala fmt library and apply fixes
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #10784:
URL: https://github.com/apache/kafka/pull/10784#issuecomment-850554801
Looks like the formatting changes are on the streams scala module. cc @mjsax @vvcephei @guozhangwang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #10784: KAFKA-12862: Update Scala fmt library and apply fixes
Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10784:
URL: https://github.com/apache/kafka/pull/10784#issuecomment-854078089
Any chance any of you has time to check this? cc @mjsax @vvcephei @guozhangwang
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #10784: KAFKA-12862: Update Scala fmt library and apply fixes
Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10784:
URL: https://github.com/apache/kafka/pull/10784#issuecomment-887524211
Thanks for the review @vvcephei !
Actually, the spotless task executes the scalafmt in this gradle config, this means running `./gradlew spotlessScalaCheck` will analyze all Scala files and complain about violations in the code. Then running `./gradlew :spotlessScalaApply` will fix any formatting discrepancies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna merged pull request #10784: KAFKA-12862: Update Scala fmt library and apply fixes
Posted by GitBox <gi...@apache.org>.
cadonna merged pull request #10784:
URL: https://github.com/apache/kafka/pull/10784
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #10784: KAFKA-12862: Update Scala fmt library and apply fixes
Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10784:
URL: https://github.com/apache/kafka/pull/10784#issuecomment-887529961
As new code has been added I need to re-run scalafmt for those. Pushing those changes in a second.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #10784: KAFKA-12862: Update Scala fmt library and apply fixes
Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10784:
URL: https://github.com/apache/kafka/pull/10784#issuecomment-892521275
Pinging @vvcephei
Would you be able to merger this before more commits get in the way and we need another rebase?
Thanks a ton!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat closed pull request #10784: KAFKA-12862: Update Scala fmt library and apply fixes
Posted by GitBox <gi...@apache.org>.
jlprat closed pull request #10784:
URL: https://github.com/apache/kafka/pull/10784
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #10784: KAFKA-12862: Update Scala fmt library and apply fixes
Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10784:
URL: https://github.com/apache/kafka/pull/10784#issuecomment-854078089
Any chance any of you has time to check this? cc @mjsax @vvcephei @guozhangwang
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #10784: KAFKA-12862: Update Scala fmt library and apply fixes
Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10784:
URL: https://github.com/apache/kafka/pull/10784#issuecomment-892521275
Pinging @vvcephei
Would you be able to merger this before more commits get in the way and we need another rebase?
Thanks a ton!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #10784: KAFKA-12862: Update Scala fmt library and apply fixes
Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10784:
URL: https://github.com/apache/kafka/pull/10784#issuecomment-891795576
I just closed and opened the PR to re-trigger Jenkins build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #10784: KAFKA-12862: Update Scala fmt library and apply fixes
Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10784:
URL: https://github.com/apache/kafka/pull/10784#issuecomment-850550830
Sorry to almost always point at you @ijuma If you would have time, could you take a look at this one? Maybe it's worth change the scala fmt config instead of leaving these deafults.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #10784: KAFKA-12862: Update Scala fmt library and apply fixes
Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10784:
URL: https://github.com/apache/kafka/pull/10784#issuecomment-855781064
@cadonna maybe you can look at this one if you have some time. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vvcephei commented on pull request #10784: KAFKA-12862: Update Scala fmt library and apply fixes
Posted by GitBox <gi...@apache.org>.
vvcephei commented on pull request #10784:
URL: https://github.com/apache/kafka/pull/10784#issuecomment-887513532
It looks like there's a new conflict. Hopefully, we can merge soon after you fix the conflict this time.
By the way, can you let me know the command you used to apply the format? I've been accustomed to using Spotless Scala in this repo; I didn't know about Scala fmt until just now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #10784: KAFKA-12862: Update Scala fmt library and apply fixes
Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10784:
URL: https://github.com/apache/kafka/pull/10784#issuecomment-888398307
Hi @vvcephei feel free to review the tiny commit to fix the code that has been committed since the PR was created.
Also test failure seems unrelated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #10784: KAFKA-12862: Update Scala fmt library and apply fixes
Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10784:
URL: https://github.com/apache/kafka/pull/10784#issuecomment-850556227
Noted, I will ping them when touching that area.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #10784: KAFKA-12862: Update Scala fmt library and apply fixes
Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10784:
URL: https://github.com/apache/kafka/pull/10784#issuecomment-887638986
Something went wrong during the build, can someone re-trigger the build in Jenkins?
Failure was:
> [2021-07-27T14:23:53.802Z] FAILURE: Build failed with an exception.
[2021-07-27T14:23:53.802Z]
[2021-07-27T14:23:53.802Z] * What went wrong:
[2021-07-27T14:23:53.802Z] Execution failed for task ':storage:unitTest'.
[2021-07-27T14:23:53.802Z] > Process 'Gradle Test Executor 68' finished with non-zero exit value 1
[2021-07-27T14:23:53.802Z] This problem might be caused by incorrect test process configuration.
[2021-07-27T14:23:53.802Z] Please refer to the test execution section in the User Manual at https://docs.gradle.org/7.1.1/userguide/java_testing.html#sec:test_execution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #10784: KAFKA-12862: Update Scala fmt library and apply fixes
Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10784:
URL: https://github.com/apache/kafka/pull/10784#issuecomment-855821163
Rebased to resolve conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #10784: KAFKA-12862: Update Scala fmt library and apply fixes
Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10784:
URL: https://github.com/apache/kafka/pull/10784#issuecomment-895105500
Thanks @cadonna !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org