You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/11/18 18:43:35 UTC

[GitHub] [helix] jiajunwang commented on a change in pull request #1542: Fix dependency for some tests

jiajunwang commented on a change in pull request #1542:
URL: https://github.com/apache/helix/pull/1542#discussion_r526332675



##########
File path: helix-core/src/test/java/org/apache/helix/integration/TestPartitionMovementThrottle.java
##########
@@ -278,7 +278,7 @@ public void testThrottleOnlyClusterLevelAnyType() {
     ClusterLiveNodesVerifier liveNodesVerifier =
         new ClusterLiveNodesVerifier(_gZkClient, CLUSTER_NAME,
             Lists.transform(Arrays.asList(_participants), MockParticipantManager::getInstanceName));
-    Assert.assertTrue(liveNodesVerifier.verifyByZkCallback(1000));
+    Assert.assertTrue(liveNodesVerifier.verifyByZkCallback(5000));

Review comment:
       TestHelper.WAIT_DURATION?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org