[GitHub] [iceberg] Fokko commented on issue #4933: Proposal: Rename Python library to `pyiceberg` and remove `src` level in directory

[GitBox <gi...@apache.org>]

Fokko commented on issue #4933:
URL: https://github.com/apache/iceberg/issues/4933#issuecomment-1144165552

   Hey @samredai Thank you for bringing this up.
   
   I fully agree. I went for `apache-iceberg` in the PR #[4844](https://github.com/apache/iceberg/pull/4844/files#diff-1a45bd938160f7761769e7b6fbc819d1cc7f84ce37f1a6a23ef83cc4e214abc8R19), but that wasn't intentional. I got that from `apache-airflow` on which I also did a lot of work. @jun-he thanks for pointing out the vote, I was unaware of it. Since there weren't any releases (yet), I figured it was TBD.
   
   I also think that `pyiceberg` is a great pypi package name as it matches the internal name. This will prevent a lot of confusion, and frustration in the end. It also nicely aligns with `pyarrow` and `pyspark`.
   
   With respect to dropping the `src`; a big `+1` from my side. It doesn't add any value in my opinion. It will simplify some things such as being able to import the source without having to install it. Also, I had to explicitly tell this to poetry, since it defaults to non-src projects: https://github.com/apache/iceberg/pull/4844/files#diff-1a45bd938160f7761769e7b6fbc819d1cc7f84ce37f1a6a23ef83cc4e214abc8R36-R38


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org