You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Arun Suresh (JIRA)" <ji...@apache.org> on 2014/09/30 00:57:35 UTC
[jira] [Commented] (HADOOP-11122) Fix findbugs and order of key
updates Abstract/ZK DelegationTokenSecretManagers
[ https://issues.apache.org/jira/browse/HADOOP-11122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14152467#comment-14152467 ]
Arun Suresh commented on HADOOP-11122:
--------------------------------------
[~jianhe],
wrt to your comment here : https://issues.apache.org/jira/browse/HADOOP-11017?focusedCommentId=14145388&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14145388,
The {{rollMasterKey()}} method first resets the expiry on the {{currentKey}} (and thus the call is first made to {{updateDelegationKey(currentKey)}}) and then calls {{updateCurrentKey()}} which creates a new {{currentKey}} itself (which calls {{storeDelegationKey(newKey)}})
Do you still think we should move {{updateMasterKey(key)}} inside {{updateCurrentKey()}} ??
> Fix findbugs and order of key updates Abstract/ZK DelegationTokenSecretManagers
> --------------------------------------------------------------------------------
>
> Key: HADOOP-11122
> URL: https://issues.apache.org/jira/browse/HADOOP-11122
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Karthik Kambatla
> Assignee: Arun Suresh
> Priority: Blocker
>
> HADOOP-11017 adds ZK implementation for DelegationTokenSecretManager. This is a follow-up JIRA to address review comments there - findbugs and order of updates to the {{currentKey}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)