You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Colin Patrick McCabe (JIRA)" <ji...@apache.org> on 2012/07/10 21:24:34 UTC
[jira] [Created] (HADOOP-8584) test-patch.sh should not immediately
exit when no tests are added or modified
Colin Patrick McCabe created HADOOP-8584:
--------------------------------------------
Summary: test-patch.sh should not immediately exit when no tests are added or modified
Key: HADOOP-8584
URL: https://issues.apache.org/jira/browse/HADOOP-8584
Project: Hadoop Common
Issue Type: Bug
Reporter: Colin Patrick McCabe
Assignee: Colin Patrick McCabe
test-patch.sh should not immediately exit when no tests are added or modified.
Although it's good to note whether or not a patch introduces or modifies tests, it's not good to abort the Jenkins patch process if it did not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HADOOP-8584) test-patch.sh should not
immediately exit when no tests are added or modified
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins resolved HADOOP-8584.
---------------------------------
Resolution: Fixed
Fix Version/s: 3.0.0
Hadoop Flags: Reviewed
I've committed this to trunk.
> test-patch.sh should not immediately exit when no tests are added or modified
> -----------------------------------------------------------------------------
>
> Key: HADOOP-8584
> URL: https://issues.apache.org/jira/browse/HADOOP-8584
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.0.0-alpha, 3.0.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Fix For: 3.0.0
>
> Attachments: HADOOP-8584.001.patch
>
>
> test-patch.sh should not immediately exit when no tests are added or modified.
> Although it's good to note whether or not a patch introduces or modifies tests, it's not good to abort the Jenkins patch process if it did not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8584) test-patch.sh should not
immediately exit when no tests are added or modified
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411529#comment-13411529 ]
Hudson commented on HADOOP-8584:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #1133 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1133/])
HADOOP-8584. test-patch.sh should not immediately exit when no tests are added or modified. Contributed by Colin Patrick McCabe (Revision 1359902)
Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1359902
Files :
* /hadoop/common/trunk/dev-support/test-patch.sh
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
> test-patch.sh should not immediately exit when no tests are added or modified
> -----------------------------------------------------------------------------
>
> Key: HADOOP-8584
> URL: https://issues.apache.org/jira/browse/HADOOP-8584
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.0.0-alpha, 3.0.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Fix For: 3.0.0
>
> Attachments: HADOOP-8584.001.patch
>
>
> test-patch.sh should not immediately exit when no tests are added or modified.
> Although it's good to note whether or not a patch introduces or modifies tests, it's not good to abort the Jenkins patch process if it did not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8584) test-patch.sh should not
immediately exit when no tests are added or modified
Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410740#comment-13410740 ]
Colin Patrick McCabe commented on HADOOP-8584:
----------------------------------------------
bq. Btw, was this change made to demand that all patches, unless doc or log changes, be provided with a patch?
No. It seems to have been an unintented issue introduced by the patch for HADOOP-8523.
> test-patch.sh should not immediately exit when no tests are added or modified
> -----------------------------------------------------------------------------
>
> Key: HADOOP-8584
> URL: https://issues.apache.org/jira/browse/HADOOP-8584
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
>
> test-patch.sh should not immediately exit when no tests are added or modified.
> Although it's good to note whether or not a patch introduces or modifies tests, it's not good to abort the Jenkins patch process if it did not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8584) test-patch.sh should not immediately
exit when no tests are added or modified
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-8584:
--------------------------------
Affects Version/s: 3.0.0
2.0.0-alpha
> test-patch.sh should not immediately exit when no tests are added or modified
> -----------------------------------------------------------------------------
>
> Key: HADOOP-8584
> URL: https://issues.apache.org/jira/browse/HADOOP-8584
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.0.0-alpha, 3.0.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Fix For: 3.0.0
>
> Attachments: HADOOP-8584.001.patch
>
>
> test-patch.sh should not immediately exit when no tests are added or modified.
> Although it's good to note whether or not a patch introduces or modifies tests, it's not good to abort the Jenkins patch process if it did not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8584) test-patch.sh should not immediately
exit when no tests are added or modified
Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colin Patrick McCabe updated HADOOP-8584:
-----------------------------------------
Attachment: HADOOP-8584.001.patch
> test-patch.sh should not immediately exit when no tests are added or modified
> -----------------------------------------------------------------------------
>
> Key: HADOOP-8584
> URL: https://issues.apache.org/jira/browse/HADOOP-8584
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HADOOP-8584.001.patch
>
>
> test-patch.sh should not immediately exit when no tests are added or modified.
> Although it's good to note whether or not a patch introduces or modifies tests, it's not good to abort the Jenkins patch process if it did not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8584) test-patch.sh should not
immediately exit when no tests are added or modified
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411414#comment-13411414 ]
Hudson commented on HADOOP-8584:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #1100 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1100/])
HADOOP-8584. test-patch.sh should not immediately exit when no tests are added or modified. Contributed by Colin Patrick McCabe (Revision 1359902)
Result = FAILURE
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1359902
Files :
* /hadoop/common/trunk/dev-support/test-patch.sh
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
> test-patch.sh should not immediately exit when no tests are added or modified
> -----------------------------------------------------------------------------
>
> Key: HADOOP-8584
> URL: https://issues.apache.org/jira/browse/HADOOP-8584
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.0.0-alpha, 3.0.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Fix For: 3.0.0
>
> Attachments: HADOOP-8584.001.patch
>
>
> test-patch.sh should not immediately exit when no tests are added or modified.
> Although it's good to note whether or not a patch introduces or modifies tests, it's not good to abort the Jenkins patch process if it did not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8584) test-patch.sh should not
immediately exit when no tests are added or modified
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410898#comment-13410898 ]
Eli Collins commented on HADOOP-8584:
-------------------------------------
+1
> test-patch.sh should not immediately exit when no tests are added or modified
> -----------------------------------------------------------------------------
>
> Key: HADOOP-8584
> URL: https://issues.apache.org/jira/browse/HADOOP-8584
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HADOOP-8584.001.patch
>
>
> test-patch.sh should not immediately exit when no tests are added or modified.
> Although it's good to note whether or not a patch introduces or modifies tests, it's not good to abort the Jenkins patch process if it did not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8584) test-patch.sh should not
immediately exit when no tests are added or modified
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410736#comment-13410736 ]
Harsh J commented on HADOOP-8584:
---------------------------------
Btw, was this change made to demand that all patches, unless doc or log changes, be provided with a patch?
> test-patch.sh should not immediately exit when no tests are added or modified
> -----------------------------------------------------------------------------
>
> Key: HADOOP-8584
> URL: https://issues.apache.org/jira/browse/HADOOP-8584
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
>
> test-patch.sh should not immediately exit when no tests are added or modified.
> Although it's good to note whether or not a patch introduces or modifies tests, it's not good to abort the Jenkins patch process if it did not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira