You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org> on 2024/10/04 16:39:01 UTC
[kudu-CR](branch-1.18.x) [build] Fix the directory creation
Abhishek Chennaka has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21889
Change subject: [build] Fix the directory creation
......................................................................
[build] Fix the directory creation
Fixes the recursive directory creation which according to
python documentation [1] should be os.makedirs() and not
os.path.makedirs() which results in the below error:
AttributeError: module 'posixpath' has no attribute 'makedirs'
1.
https://docs.python.org/2.6/library/os.html#os.makedirs
https://docs.python.org/3.11/library/os.html#os.makedirs
Change-Id: Ifef12fd681050c5d1e6841070fdd754a7d436f8f
Reviewed-on: http://gerrit.cloudera.org:8080/21883
Reviewed-by: Alexey Serbin <al...@apache.org>
Tested-by: Marton Greber <gr...@gmail.com>
Reviewed-by: Marton Greber <gr...@gmail.com>
(cherry picked from commit c32708d5b957514420aaa13953c25db8940fe7cb)
---
M build-support/build_source_release.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/21889/1
--
To view, visit http://gerrit.cloudera.org:8080/21889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifef12fd681050c5d1e6841070fdd754a7d436f8f
Gerrit-Change-Number: 21889
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
[kudu-CR](branch-1.18.x) [build] Fix the directory creation
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21889 )
Change subject: [build] Fix the directory creation
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/570/
--
To view, visit http://gerrit.cloudera.org:8080/21889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifef12fd681050c5d1e6841070fdd754a7d436f8f
Gerrit-Change-Number: 21889
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 04 Oct 2024 16:39:09 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.18.x) [build] Fix the directory creation
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has removed a vote on this change.
Change subject: [build] Fix the directory creation
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/21889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ifef12fd681050c5d1e6841070fdd754a7d436f8f
Gerrit-Change-Number: 21889
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.18.x) [build] Fix the directory creation
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21889 )
Change subject: [build] Fix the directory creation
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifef12fd681050c5d1e6841070fdd754a7d436f8f
Gerrit-Change-Number: 21889
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 04 Oct 2024 17:14:39 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.18.x) [build] Fix the directory creation
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21889 )
Change subject: [build] Fix the directory creation
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/570/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/21889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifef12fd681050c5d1e6841070fdd754a7d436f8f
Gerrit-Change-Number: 21889
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 04 Oct 2024 19:59:28 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.18.x) [build] Fix the directory creation
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21889 )
Change subject: [build] Fix the directory creation
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/21889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifef12fd681050c5d1e6841070fdd754a7d436f8f
Gerrit-Change-Number: 21889
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 04 Oct 2024 23:48:22 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.18.x) [build] Fix the directory creation
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21889 )
Change subject: [build] Fix the directory creation
......................................................................
[build] Fix the directory creation
Fixes the recursive directory creation which according to
python documentation [1] should be os.makedirs() and not
os.path.makedirs() which results in the below error:
AttributeError: module 'posixpath' has no attribute 'makedirs'
1.
https://docs.python.org/2.6/library/os.html#os.makedirs
https://docs.python.org/3.11/library/os.html#os.makedirs
Change-Id: Ifef12fd681050c5d1e6841070fdd754a7d436f8f
Reviewed-on: http://gerrit.cloudera.org:8080/21883
Reviewed-by: Alexey Serbin <al...@apache.org>
Tested-by: Marton Greber <gr...@gmail.com>
Reviewed-by: Marton Greber <gr...@gmail.com>
(cherry picked from commit c32708d5b957514420aaa13953c25db8940fe7cb)
Reviewed-on: http://gerrit.cloudera.org:8080/21889
Tested-by: Abhishek Chennaka <ac...@cloudera.com>
---
M build-support/build_source_release.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Abhishek Chennaka: Verified
--
To view, visit http://gerrit.cloudera.org:8080/21889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifef12fd681050c5d1e6841070fdd754a7d436f8f
Gerrit-Change-Number: 21889
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)