You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "James Holmes (JIRA)" <ji...@apache.org> on 2007/08/23 17:59:34 UTC
[jira] Created: (WW-2132) Add support for JSP tag library dynamic
attributes
Add support for JSP tag library dynamic attributes
--------------------------------------------------
Key: WW-2132
URL: https://issues.apache.org/struts/browse/WW-2132
Project: Struts 2
Issue Type: Improvement
Components: Views
Affects Versions: 2.1.0
Reporter: James Holmes
Assignee: James Holmes
Fix For: 2.1.0
Based on the discussion in WW-2092, I am working on adding support for JSP dynamic attributes to Struts 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2132) Add support for JSP tag library dynamic
attributes
Posted by "Rajeev kumar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47120#action_47120 ]
Rajeev kumar commented on WW-2132:
----------------------------------
As ww-2092 contains patch.txt, can someone please provide me patch for src for struts 2.0.11 for above mentioned 1-7 steps.
> Add support for JSP tag library dynamic attributes
> --------------------------------------------------
>
> Key: WW-2132
> URL: https://issues.apache.org/struts/browse/WW-2132
> Project: Struts 2
> Issue Type: Improvement
> Components: Documentation
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Assignee: James Holmes
> Fix For: 2.1.3
>
>
> Based on the discussion in WW-2092, I am working on adding support for JSP dynamic attributes to Struts 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2132) Add support for JSP tag library dynamic
attributes
Posted by "James Holmes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42134 ]
James Holmes commented on WW-2132:
----------------------------------
7) Done
Checked in to the trunk in SVN revision 572756.
> Add support for JSP tag library dynamic attributes
> --------------------------------------------------
>
> Key: WW-2132
> URL: https://issues.apache.org/struts/browse/WW-2132
> Project: Struts 2
> Issue Type: Improvement
> Components: Views
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Assignee: James Holmes
> Fix For: 2.1.0
>
>
> Based on the discussion in WW-2092, I am working on adding support for JSP dynamic attributes to Struts 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2132) Add support for JSP tag library dynamic
attributes
Posted by "Ted Husted (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42464 ]
Ted Husted commented on WW-2132:
--------------------------------
Evidentially, we're down to
8 ) Update documentation.
> Add support for JSP tag library dynamic attributes
> --------------------------------------------------
>
> Key: WW-2132
> URL: https://issues.apache.org/struts/browse/WW-2132
> Project: Struts 2
> Issue Type: Improvement
> Components: Views
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Assignee: James Holmes
> Fix For: 2.1.3
>
>
> Based on the discussion in WW-2092, I am working on adding support for JSP dynamic attributes to Struts 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2132) Add support for JSP tag library dynamic
attributes
Posted by "James Holmes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42002 ]
James Holmes commented on WW-2132:
----------------------------------
I can't think of any drawbacks off the top of my head other than the fact that the dynamic attributes feature will not prevent users from arbitrarily adding attributes. Some users may want to be "warned" that they are using "non-standard" attributes.
> Add support for JSP tag library dynamic attributes
> --------------------------------------------------
>
> Key: WW-2132
> URL: https://issues.apache.org/struts/browse/WW-2132
> Project: Struts 2
> Issue Type: Improvement
> Components: Views
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Assignee: James Holmes
> Fix For: 2.1.0
>
>
> Based on the discussion in WW-2092, I am working on adding support for JSP dynamic attributes to Struts 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2132) Add support for JSP tag library dynamic
attributes
Posted by "James Holmes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44165#action_44165 ]
James Holmes commented on WW-2132:
----------------------------------
zhouyanming,
Not every tag in the Struts 2 tag library is configured to support dynamic attributes. However, the ones that are configured (via annotation) to allow dynamic attributes are indeed doing so according to the struts-tags.tld file in the Struts 2.1.2 beta release (I just verified this). If there is a tag we missed, feel free to open up a new JIRA ticket to report it. I'm about to close out this ticket.
> Add support for JSP tag library dynamic attributes
> --------------------------------------------------
>
> Key: WW-2132
> URL: https://issues.apache.org/struts/browse/WW-2132
> Project: Struts 2
> Issue Type: Improvement
> Components: Documentation
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Assignee: James Holmes
> Fix For: 2.1.3
>
>
> Based on the discussion in WW-2092, I am working on adding support for JSP dynamic attributes to Struts 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2132) Add support for JSP tag library dynamic
attributes
Posted by "James Holmes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42133 ]
James Holmes commented on WW-2132:
----------------------------------
1) Done
Checked in to the trunk in SVN revision 572764.
> Add support for JSP tag library dynamic attributes
> --------------------------------------------------
>
> Key: WW-2132
> URL: https://issues.apache.org/struts/browse/WW-2132
> Project: Struts 2
> Issue Type: Improvement
> Components: Views
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Assignee: James Holmes
> Fix For: 2.1.0
>
>
> Based on the discussion in WW-2092, I am working on adding support for JSP dynamic attributes to Struts 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2132) Add support for JSP tag library dynamic
attributes
Posted by "James Holmes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42003 ]
James Holmes commented on WW-2132:
----------------------------------
Another question: should we allow the dynamic attributes to specify OGNL expressions? Right now the implementation I have does not support that, but I could add OGNL support.
> Add support for JSP tag library dynamic attributes
> --------------------------------------------------
>
> Key: WW-2132
> URL: https://issues.apache.org/struts/browse/WW-2132
> Project: Struts 2
> Issue Type: Improvement
> Components: Views
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Assignee: James Holmes
> Fix For: 2.1.0
>
>
> Based on the discussion in WW-2092, I am working on adding support for JSP dynamic attributes to Struts 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2132) Add support for JSP tag library dynamic
attributes
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42005 ]
Paul Benedict commented on WW-2132:
-----------------------------------
There was heavy opposition from two committers in S1 against dynamic attributes (STR-2502 and STR-2810). I am not one of them. If S2 is going this route, I see no further reason to block S1. Integrating S1 with Dojo attributes would be fabulous.
> Add support for JSP tag library dynamic attributes
> --------------------------------------------------
>
> Key: WW-2132
> URL: https://issues.apache.org/struts/browse/WW-2132
> Project: Struts 2
> Issue Type: Improvement
> Components: Views
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Assignee: James Holmes
> Fix For: 2.1.0
>
>
> Based on the discussion in WW-2092, I am working on adding support for JSP dynamic attributes to Struts 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WW-2132) Add support for JSP tag
library dynamic attributes
Posted by "James Holmes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42004 ]
jholmes edited comment on WW-2132 at 8/28/07 12:50 PM:
------------------------------------------------------------
2) Done
3) Done
4) Done
5) Done
6) Done
Checked in to the trunk in SVN revision 570496.
was (Author: jholmes):
2) Done
3) Done
4) Done
5) Done
6) Done
Checked in tp the trunk in SVN revision 570496.
> Add support for JSP tag library dynamic attributes
> --------------------------------------------------
>
> Key: WW-2132
> URL: https://issues.apache.org/struts/browse/WW-2132
> Project: Struts 2
> Issue Type: Improvement
> Components: Views
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Assignee: James Holmes
> Fix For: 2.1.0
>
>
> Based on the discussion in WW-2092, I am working on adding support for JSP dynamic attributes to Struts 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WW-2132) Add support for JSP tag
library dynamic attributes
Posted by "James Holmes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42000 ]
jholmes edited comment on WW-2132 at 8/23/07 10:04 AM:
------------------------------------------------------------
There are several changes that need to be made to support this. Here is the list:
+ Update struts-annotation project to support generating a <dynamic-attributes> entry in TLD files.
+ Update StrutsTag annotation to have an allowDynamicAttributes field.
+ Update UI tags to specify an allowDynamicAttributes on their StrutsTag annotations.
+ Update org.apache.struts2.views.jsp.ui.AbstractUITag to implement javax.servlet.jsp.tagext.DynamicAttributes.
+ Add JUnit tests for new allowDynamicAttributes annotation property.
+ Update FreeMarker templates to output dynamic attributes if present.
+ Update struts2/core/pom.xml to output 2 TLDs: struts-tags.tld and struts-tags-dynamic.tld.
+ Update documentation.
Feedback is welcome and encouraged. My design is based around how Stripes implements this. Stripes provides a dynamic and non-dynamic version of the TLD and leaves it up to the user to decide which to use. We can follow that approach or simply have dynamic be the only option.
was (Author: jholmes):
There are several changes that need to be made to support this. Here is the list:
+ Update struts-annotation project to support generating a <dynamic-attributes> entry in TLD files.
+ Update StrutsTag annotation to have an allowDynamicAttributes field.
+ Update UI tags to specify an allowDynamicAttributes on their StrutsTag annotations.
+ Update org.apache.struts2.views.jsp.ui.AbstractUITag to implement javax.servlet.jsp.tagext.DynamicAttributes.
+ Update FreeMarker templates to output dynamic attributes if present.
+ Update struts2/core/pom.xml to output 2 TLDs: struts-tags.tld and struts-tags-dynamic.tld.
+ Update documentation.
Feedback is welcome and encouraged. My design is based around how Stripes implements this. Stripes provides a dynamic and non-dynamic version of the TLD and leaves it up to the user to decide which to use. We can follow that approach or simply have dynamic be the only option.
> Add support for JSP tag library dynamic attributes
> --------------------------------------------------
>
> Key: WW-2132
> URL: https://issues.apache.org/struts/browse/WW-2132
> Project: Struts 2
> Issue Type: Improvement
> Components: Views
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Assignee: James Holmes
> Fix For: 2.1.0
>
>
> Based on the discussion in WW-2092, I am working on adding support for JSP dynamic attributes to Struts 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WW-2132) Add support for JSP tag
library dynamic attributes
Posted by "James Holmes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42000 ]
jholmes edited comment on WW-2132 at 9/4/07 11:18 AM:
-----------------------------------------------------------
There are several changes that need to be made to support this. Here is the list:
1) Update struts-annotation project to support generating a <dynamic-attributes> entry in TLD files.
2) Update StrutsTag annotation to have an allowDynamicAttributes field.
3) Update UI tags to specify an allowDynamicAttributes on their StrutsTag annotations.
4) Update org.apache.struts2.views.jsp.ui.AbstractUITag to implement javax.servlet.jsp.tagext.DynamicAttributes.
5) Add JUnit tests for new allowDynamicAttributes annotation property.
6) Update FreeMarker templates to output dynamic attributes if present.
7) Update struts2/core/pom.xml to set the struts-tags.tld JSP version to 2.0.
8) Update documentation.
Feedback is welcome and encouraged. My design is based around how Stripes implements this. Stripes provides a dynamic and non-dynamic version of the TLD and leaves it up to the user to decide which to use. We can follow that approach or simply have dynamic be the only option.
was (Author: jholmes):
There are several changes that need to be made to support this. Here is the list:
1) Update struts-annotation project to support generating a <dynamic-attributes> entry in TLD files.
2) Update StrutsTag annotation to have an allowDynamicAttributes field.
3) Update UI tags to specify an allowDynamicAttributes on their StrutsTag annotations.
4) Update org.apache.struts2.views.jsp.ui.AbstractUITag to implement javax.servlet.jsp.tagext.DynamicAttributes.
5) Add JUnit tests for new allowDynamicAttributes annotation property.
6) Update FreeMarker templates to output dynamic attributes if present.
7) Update struts2/core/pom.xml to output 2 TLDs: struts-tags.tld and struts-tags-dynamic.tld.
8) Update documentation.
Feedback is welcome and encouraged. My design is based around how Stripes implements this. Stripes provides a dynamic and non-dynamic version of the TLD and leaves it up to the user to decide which to use. We can follow that approach or simply have dynamic be the only option.
> Add support for JSP tag library dynamic attributes
> --------------------------------------------------
>
> Key: WW-2132
> URL: https://issues.apache.org/struts/browse/WW-2132
> Project: Struts 2
> Issue Type: Improvement
> Components: Views
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Assignee: James Holmes
> Fix For: 2.1.0
>
>
> Based on the discussion in WW-2092, I am working on adding support for JSP dynamic attributes to Struts 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WW-2132) Add support for JSP tag
library dynamic attributes
Posted by "James Holmes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42004 ]
jholmes edited comment on WW-2132 at 8/28/07 10:42 AM:
------------------------------------------------------------
2) Done
3) Done
4) Done
5) Done
6) Done
Checked in tp the trunk in SVN revision 570496.
was (Author: jholmes):
2) Done
3) Done
4) Done
5) Done
6) Done
> Add support for JSP tag library dynamic attributes
> --------------------------------------------------
>
> Key: WW-2132
> URL: https://issues.apache.org/struts/browse/WW-2132
> Project: Struts 2
> Issue Type: Improvement
> Components: Views
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Assignee: James Holmes
> Fix For: 2.1.0
>
>
> Based on the discussion in WW-2092, I am working on adding support for JSP dynamic attributes to Struts 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WW-2132) Add support for JSP tag
library dynamic attributes
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42005 ]
paul4christ79 edited comment on WW-2132 at 8/23/07 4:41 PM:
------------------------------------------------------------
There was heavy opposition from two committers in S1 against dynamic attributes (STR-2502 and STR-2810). I am not one of them. If S2 is going this route, I see no further reason to block S1. Integrating S1 with Dojo attributes would be fabulous. My compromise would be to nest a <html:attribute> tag.
was (Author: paul4christ79):
There was heavy opposition from two committers in S1 against dynamic attributes (STR-2502 and STR-2810). I am not one of them. If S2 is going this route, I see no further reason to block S1. Integrating S1 with Dojo attributes would be fabulous.
> Add support for JSP tag library dynamic attributes
> --------------------------------------------------
>
> Key: WW-2132
> URL: https://issues.apache.org/struts/browse/WW-2132
> Project: Struts 2
> Issue Type: Improvement
> Components: Views
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Assignee: James Holmes
> Fix For: 2.1.0
>
>
> Based on the discussion in WW-2092, I am working on adding support for JSP dynamic attributes to Struts 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2132) Add support for JSP tag library dynamic
attributes
Posted by "zhouyanming (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=42992#action_42992 ]
zhouyanming commented on WW-2132:
---------------------------------
struts-tags.tld in struts2-core-2.1.1-SNAPSHOT-20080115.jar still has problems
1.didn't use schema but dtd
<?xml version="1.0" encoding="UTF-8"?>
<taglib xmlns="http://java.sun.com/xml/ns/j2ee"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://java.sun.com/xml/ns/j2ee http://java.sun.com/xml/ns/j2ee/web-jsptaglibrary_2_0.xsd"
version="2.0">
2.didn't add '<dynamic-attributes>true</dynamic-attributes>' for each UI tag.
> Add support for JSP tag library dynamic attributes
> --------------------------------------------------
>
> Key: WW-2132
> URL: https://issues.apache.org/struts/browse/WW-2132
> Project: Struts 2
> Issue Type: Improvement
> Components: Documentation
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Assignee: James Holmes
> Fix For: 2.1.3
>
>
> Based on the discussion in WW-2092, I am working on adding support for JSP dynamic attributes to Struts 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2132) Add support for JSP tag library dynamic
attributes
Posted by "zhouyanming (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45560#action_45560 ]
zhouyanming commented on WW-2132:
---------------------------------
does freemarker view support this feature?it seems doesn't work.
like this
<@s.form test="test">
</...@s.form>
> Add support for JSP tag library dynamic attributes
> --------------------------------------------------
>
> Key: WW-2132
> URL: https://issues.apache.org/struts/browse/WW-2132
> Project: Struts 2
> Issue Type: Improvement
> Components: Documentation
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Assignee: James Holmes
> Fix For: 2.1.3
>
>
> Based on the discussion in WW-2092, I am working on adding support for JSP dynamic attributes to Struts 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WW-2132) Add support for JSP tag library dynamic
attributes
Posted by "Ted Husted (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Husted updated WW-2132:
---------------------------
Component/s: (was: Views)
Documentation
> Add support for JSP tag library dynamic attributes
> --------------------------------------------------
>
> Key: WW-2132
> URL: https://issues.apache.org/struts/browse/WW-2132
> Project: Struts 2
> Issue Type: Improvement
> Components: Documentation
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Assignee: James Holmes
> Fix For: 2.1.3
>
>
> Based on the discussion in WW-2092, I am working on adding support for JSP dynamic attributes to Struts 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2132) Add support for JSP tag library dynamic
attributes
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42051 ]
Paul Benedict commented on WW-2132:
-----------------------------------
I think the allowDynamicAttributes attribute is great. I will hopefully be doing the same with S1.
> Add support for JSP tag library dynamic attributes
> --------------------------------------------------
>
> Key: WW-2132
> URL: https://issues.apache.org/struts/browse/WW-2132
> Project: Struts 2
> Issue Type: Improvement
> Components: Views
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Assignee: James Holmes
> Fix For: 2.1.0
>
>
> Based on the discussion in WW-2092, I am working on adding support for JSP dynamic attributes to Struts 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2132) Add support for JSP tag library dynamic
attributes
Posted by "James Holmes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44194#action_44194 ]
James Holmes commented on WW-2132:
----------------------------------
zhouyanming,
How do you propose the dynamic attributes on the checkboxlist tag be used? Would the dynamic attributes be added to every <input type="checkbox"> tag that is generated?
> Add support for JSP tag library dynamic attributes
> --------------------------------------------------
>
> Key: WW-2132
> URL: https://issues.apache.org/struts/browse/WW-2132
> Project: Struts 2
> Issue Type: Improvement
> Components: Documentation
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Assignee: James Holmes
> Fix For: 2.1.3
>
>
> Based on the discussion in WW-2092, I am working on adding support for JSP dynamic attributes to Struts 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2132) Add support for JSP tag library dynamic
attributes
Posted by "Musachy Barroso (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42001 ]
Musachy Barroso commented on WW-2132:
-------------------------------------
Is there any drawback to just using the dynamic one?
> Add support for JSP tag library dynamic attributes
> --------------------------------------------------
>
> Key: WW-2132
> URL: https://issues.apache.org/struts/browse/WW-2132
> Project: Struts 2
> Issue Type: Improvement
> Components: Views
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Assignee: James Holmes
> Fix For: 2.1.0
>
>
> Based on the discussion in WW-2092, I am working on adding support for JSP dynamic attributes to Struts 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WW-2132) Add support for JSP tag library dynamic
attributes
Posted by "Don Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Don Brown resolved WW-2132.
---------------------------
Resolution: Fixed
> Add support for JSP tag library dynamic attributes
> --------------------------------------------------
>
> Key: WW-2132
> URL: https://issues.apache.org/struts/browse/WW-2132
> Project: Struts 2
> Issue Type: Improvement
> Components: Documentation
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Assignee: James Holmes
> Fix For: 2.1.3
>
>
> Based on the discussion in WW-2092, I am working on adding support for JSP dynamic attributes to Struts 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WW-2132) Add support for JSP tag
library dynamic attributes
Posted by "James Holmes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42000 ]
jholmes edited comment on WW-2132 at 8/23/07 1:15 PM:
-----------------------------------------------------------
There are several changes that need to be made to support this. Here is the list:
1) Update struts-annotation project to support generating a <dynamic-attributes> entry in TLD files.
2) Update StrutsTag annotation to have an allowDynamicAttributes field.
3) Update UI tags to specify an allowDynamicAttributes on their StrutsTag annotations.
4) Update org.apache.struts2.views.jsp.ui.AbstractUITag to implement javax.servlet.jsp.tagext.DynamicAttributes.
5) Add JUnit tests for new allowDynamicAttributes annotation property.
6) Update FreeMarker templates to output dynamic attributes if present.
7) Update struts2/core/pom.xml to output 2 TLDs: struts-tags.tld and struts-tags-dynamic.tld.
8) Update documentation.
Feedback is welcome and encouraged. My design is based around how Stripes implements this. Stripes provides a dynamic and non-dynamic version of the TLD and leaves it up to the user to decide which to use. We can follow that approach or simply have dynamic be the only option.
was (Author: jholmes):
There are several changes that need to be made to support this. Here is the list:
+ Update struts-annotation project to support generating a <dynamic-attributes> entry in TLD files.
+ Update StrutsTag annotation to have an allowDynamicAttributes field.
+ Update UI tags to specify an allowDynamicAttributes on their StrutsTag annotations.
+ Update org.apache.struts2.views.jsp.ui.AbstractUITag to implement javax.servlet.jsp.tagext.DynamicAttributes.
+ Add JUnit tests for new allowDynamicAttributes annotation property.
+ Update FreeMarker templates to output dynamic attributes if present.
+ Update struts2/core/pom.xml to output 2 TLDs: struts-tags.tld and struts-tags-dynamic.tld.
+ Update documentation.
Feedback is welcome and encouraged. My design is based around how Stripes implements this. Stripes provides a dynamic and non-dynamic version of the TLD and leaves it up to the user to decide which to use. We can follow that approach or simply have dynamic be the only option.
> Add support for JSP tag library dynamic attributes
> --------------------------------------------------
>
> Key: WW-2132
> URL: https://issues.apache.org/struts/browse/WW-2132
> Project: Struts 2
> Issue Type: Improvement
> Components: Views
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Assignee: James Holmes
> Fix For: 2.1.0
>
>
> Based on the discussion in WW-2092, I am working on adding support for JSP dynamic attributes to Struts 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WW-2132) Add support for JSP tag
library dynamic attributes
Posted by "Rajeev kumar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47120#action_47120 ]
Rajeev kumar edited comment on WW-2132 at 11/29/09 4:33 PM:
------------------------------------------------------------
As ww-2092 contains patch.txt, can someone please provide me patch for src struts 2.0.11 for above mentioned 1-7 steps.
At present I can't migrate to 2.1 series. So, please provide me patch for 1-7 steps.
was (Author: rajeev):
As ww-2092 contains patch.txt, can someone please provide me patch for src for struts 2.0.11 for above mentioned 1-7 steps.
> Add support for JSP tag library dynamic attributes
> --------------------------------------------------
>
> Key: WW-2132
> URL: https://issues.apache.org/struts/browse/WW-2132
> Project: Struts 2
> Issue Type: Improvement
> Components: Documentation
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Assignee: James Holmes
> Fix For: 2.1.3
>
>
> Based on the discussion in WW-2092, I am working on adding support for JSP dynamic attributes to Struts 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2132) Add support for JSP tag library dynamic
attributes
Posted by "zhouyanming (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44195#action_44195 ]
zhouyanming commented on WW-2132:
---------------------------------
yes,but i don't tink it's necessary,so you can close this issue.
> Add support for JSP tag library dynamic attributes
> --------------------------------------------------
>
> Key: WW-2132
> URL: https://issues.apache.org/struts/browse/WW-2132
> Project: Struts 2
> Issue Type: Improvement
> Components: Documentation
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Assignee: James Holmes
> Fix For: 2.1.3
>
>
> Based on the discussion in WW-2092, I am working on adding support for JSP dynamic attributes to Struts 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2132) Add support for JSP tag library dynamic
attributes
Posted by "James Holmes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42004 ]
James Holmes commented on WW-2132:
----------------------------------
2) Done
3) Done
4) Done
5) Done
6) Done
> Add support for JSP tag library dynamic attributes
> --------------------------------------------------
>
> Key: WW-2132
> URL: https://issues.apache.org/struts/browse/WW-2132
> Project: Struts 2
> Issue Type: Improvement
> Components: Views
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Assignee: James Holmes
> Fix For: 2.1.0
>
>
> Based on the discussion in WW-2092, I am working on adding support for JSP dynamic attributes to Struts 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2132) Add support for JSP tag library dynamic
attributes
Posted by "James Holmes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44166#action_44166 ]
James Holmes commented on WW-2132:
----------------------------------
Ok, I have updated the Struts Annotations code to add dynamic attributes information to the snippet that is pulled in by the Struts 2 wiki.
Don, I just need you to do the magic to make Struts 2 make use of the latest version of the Struts annotations project and then we can close this ticket out.
> Add support for JSP tag library dynamic attributes
> --------------------------------------------------
>
> Key: WW-2132
> URL: https://issues.apache.org/struts/browse/WW-2132
> Project: Struts 2
> Issue Type: Improvement
> Components: Documentation
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Assignee: James Holmes
> Fix For: 2.1.3
>
>
> Based on the discussion in WW-2092, I am working on adding support for JSP dynamic attributes to Struts 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2132) Add support for JSP tag library dynamic
attributes
Posted by "James Holmes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42000 ]
James Holmes commented on WW-2132:
----------------------------------
There are several changes that need to be made to support this. Here is the list:
+ Update struts-annotation project to support generating a <dynamic-attributes> entry in TLD files.
+ Update StrutsTag annotation to have an allowDynamicAttributes field.
+ Update UI tags to specify an allowDynamicAttributes on their StrutsTag annotations.
+ Update org.apache.struts2.views.jsp.ui.AbstractUITag to implement javax.servlet.jsp.tagext.DynamicAttributes.
+ Update FreeMarker templates to output dynamic attributes if present.
+ Update struts2/core/pom.xml to output 2 TLDs: struts-tags.tld and struts-tags-dynamic.tld.
+ Update documentation.
Feedback is welcome and encouraged. My design is based around how Stripes implements this. Stripes provides a dynamic and non-dynamic version of the TLD and leaves it up to the user to decide which to use. We can follow that approach or simply have dynamic be the only option.
> Add support for JSP tag library dynamic attributes
> --------------------------------------------------
>
> Key: WW-2132
> URL: https://issues.apache.org/struts/browse/WW-2132
> Project: Struts 2
> Issue Type: Improvement
> Components: Views
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Assignee: James Holmes
> Fix For: 2.1.0
>
>
> Based on the discussion in WW-2092, I am working on adding support for JSP dynamic attributes to Struts 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2132) Add support for JSP tag library dynamic
attributes
Posted by "zhouyanming (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44193#action_44193 ]
zhouyanming commented on WW-2132:
---------------------------------
James,
please consider checkboxlist.
> Add support for JSP tag library dynamic attributes
> --------------------------------------------------
>
> Key: WW-2132
> URL: https://issues.apache.org/struts/browse/WW-2132
> Project: Struts 2
> Issue Type: Improvement
> Components: Documentation
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Assignee: James Holmes
> Fix For: 2.1.3
>
>
> Based on the discussion in WW-2092, I am working on adding support for JSP dynamic attributes to Struts 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2132) Add support for JSP tag library dynamic
attributes
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42007 ]
Paul Benedict commented on WW-2132:
-----------------------------------
Isn't most markup XHTML nowadays? Forgive me if I am misunderstanding, but I imagine XHTML and Dojo are not incompatible.
> Add support for JSP tag library dynamic attributes
> --------------------------------------------------
>
> Key: WW-2132
> URL: https://issues.apache.org/struts/browse/WW-2132
> Project: Struts 2
> Issue Type: Improvement
> Components: Views
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Assignee: James Holmes
> Fix For: 2.1.0
>
>
> Based on the discussion in WW-2092, I am working on adding support for JSP dynamic attributes to Struts 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2132) Add support for JSP tag library dynamic
attributes
Posted by "James Holmes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42006 ]
James Holmes commented on WW-2132:
----------------------------------
I had forgotten I was a part of those discussions Paul. Interesting to read back through stuff from the past. Since we have a democracy here, we can hold a vote if their is opposition to adding dynamic attributes. It's not a unilateral decison for or against.
I think Craig's idea of ommitting the dynamic attributes when in XHTML mode is a good idea. In S2 that is easily accomplished via the XHTML theme overriding the dynamic-attributes.ftl file that I created.
> Add support for JSP tag library dynamic attributes
> --------------------------------------------------
>
> Key: WW-2132
> URL: https://issues.apache.org/struts/browse/WW-2132
> Project: Struts 2
> Issue Type: Improvement
> Components: Views
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Assignee: James Holmes
> Fix For: 2.1.0
>
>
> Based on the discussion in WW-2092, I am working on adding support for JSP dynamic attributes to Struts 2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.