You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "PragmaTwice (via GitHub)" <gi...@apache.org> on 2023/04/29 07:25:52 UTC
[GitHub] [incubator-kvrocks] PragmaTwice opened a new pull request, #1408: Rename internal macro ENABLE_NEW_ENCODING to KVROCKS_ENCODING_VERSION
PragmaTwice opened a new pull request, #1408:
URL: https://github.com/apache/incubator-kvrocks/pull/1408
As described in [the document](https://kvrocks.apache.org/community/data-structure-on-rocksdb), `KVROCKS_ENCODING_VERSION` seems to be a more scalable name than `ENABLE_NEW_ENCODING`, since the NEW encoding can become a OLD encoding, but the encoding version can be a definite number.
BTW, I move two test file from `cppunit/types` to `cppunit/`, since they are both not related to types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] mapleFU commented on pull request #1408: Rename internal macro ENABLE_NEW_ENCODING to KVROCKS_ENCODING_VERSION
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #1408:
URL: https://github.com/apache/incubator-kvrocks/pull/1408#issuecomment-1528720267
Seems ok, RocksDB also use way like that https://rocksdb.org/blog/2019/03/08/format-version-4.html
Should we mark extract for "metadata encoding version"? Or just "encoding version" is ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #1408: Rename internal macro ENABLE_NEW_ENCODING to KVROCKS_ENCODING_VERSION
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on PR #1408:
URL: https://github.com/apache/incubator-kvrocks/pull/1408#issuecomment-1528740141
> Seems ok, RocksDB also use way like that https://rocksdb.org/blog/2019/03/08/format-version-4.html Should we mark extract for "metadata encoding version"? Or just "encoding version" is ok?
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice merged pull request #1408: Rename internal macro ENABLE_NEW_ENCODING to METADATA_ENCODING_VERSION
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice merged PR #1408:
URL: https://github.com/apache/incubator-kvrocks/pull/1408
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org