You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/09/27 09:35:46 UTC
[GitHub] [nifi] Lehel44 opened a new pull request, #6452: NIFI-10551: Improve GetHubSpot documentation
Lehel44 opened a new pull request, #6452:
URL: https://github.com/apache/nifi/pull/6452
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-10551](https://issues.apache.org/jira/browse/NIFI-10551)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI-10551) issue created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [ ] JDK 8
- [ ] JDK 11
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] turcsanyip commented on a diff in pull request #6452: NIFI-10551: Improve GetHubSpot documentation
Posted by GitBox <gi...@apache.org>.
turcsanyip commented on code in PR #6452:
URL: https://github.com/apache/nifi/pull/6452#discussion_r981024048
##########
nifi-nar-bundles/nifi-hubspot-bundle/nifi-hubspot-processors/src/main/resources/docs/org.apache.nifi.processors.hubspot.GetHubSpot/additionalDetails.html:
##########
@@ -32,5 +32,13 @@ <h2>Incremental Loading</h2>
last run time of the processor are processed. The processor state can be reset in the context menu. The incremental loading
is based on the objects last modified time.
</p>
+<p>
+ There is no deletion tolerance in the current implementation. Some objects may be omitted if any object is deleted between fetching two pages.
Review Comment:
I think it rather belongs to the `Paging` section so I would move it there.
Also, I would mention that the deletion tolerance issue is due to the limitations of the HubSpot API. Something like this:
```suggestion
<p>
Due to the page handling mechanism of the HubSpot API, parallel deletions are not supported. Some objects may be omitted if any object is deleted between fetching two pages.
```
##########
nifi-nar-bundles/nifi-hubspot-bundle/nifi-hubspot-processors/src/main/java/org/apache/nifi/processors/hubspot/GetHubSpot.java:
##########
@@ -116,17 +116,18 @@ public class GetHubSpot extends AbstractProcessor {
" the previous run time and the current time (optionally adjusted by the Incremental Delay property).")
.required(true)
.allowableValues("true", "false")
- .defaultValue("false")
+ .defaultValue("true")
.build();
static final PropertyDescriptor INCREMENTAL_DELAY = new PropertyDescriptor.Builder()
.name("incremental-delay")
.displayName("Incremental Delay")
.description(("The ending timestamp of the time window will be adjusted earlier by the amount configured in this property." +
" For example, with a property value of 10 seconds, an ending timestamp of 12:30:45 would be changed to 12:30:35." +
- " Set this property to avoid missing objects when the clock of your local machines and HubSpot servers' clock are not in sync."))
+ " Set this property to avoid missing objects when the clock of your local machines and HubSpot servers' clock are not in sync" +
+ " and to protect against HubSpot's mechanism that changes last updated dates after object creation."))
Review Comment:
```suggestion
" and to protect against HubSpot's mechanism that changes last updated timestamps after object creation."))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] asfgit closed pull request #6452: NIFI-10551: Improve GetHubSpot documentation
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #6452: NIFI-10551: Improve GetHubSpot documentation
URL: https://github.com/apache/nifi/pull/6452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org