You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@wicket.apache.org by duesenklipper <gi...@git.apache.org> on 2016/11/07 15:48:43 UTC

[GitHub] wicket pull request #189: make NoRecordsToolbar use onConfigure/setVisible i...

GitHub user duesenklipper opened a pull request:

    https://github.com/apache/wicket/pull/189

    make NoRecordsToolbar use onConfigure/setVisible instead of overridin\u2026

    \u2026g isVisible
    
    Overriding isVisible is discouraged, visibility should be set just once. I know the rowcount is cached nowadays, but some time ago this actually bit us (admittedly in some way that I don't remember now, but I think by getRowCount being called too early in a request).
    
    If this one is accepted, I'll to the port to 8.x myself.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/duesenklipper/wicket feature/fix-no-records-toolbar

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/wicket/pull/189.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #189
    
----
commit 944bad39d95d1d0e02f7ede225e49d4746938f83
Author: Carl-Eric Menzel <cm...@apache.org>
Date:   2016-11-07T12:00:51Z

    make NoRecordsToolbar use onConfigure/setVisible instead of overriding isVisible

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] wicket pull request #189: make NoRecordsToolbar use onConfigure/setVisible i...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/wicket/pull/189


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] wicket issue #189: make NoRecordsToolbar use onConfigure/setVisible instead ...

Posted by martin-g <gi...@git.apache.org>.

Github user martin-g commented on the issue:

    https://github.com/apache/wicket/pull/189
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---