You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/30 02:18:19 UTC

[GitHub] [pulsar] freeznet opened a new pull request #12246: [pulsar-io-kinesis] add missing dependency

freeznet opened a new pull request #12246:
URL: https://github.com/apache/pulsar/pull/12246


   ### Motivation
   
   Kinesis connector throws `java.lang.NoClassDefFoundError: javax/xml/bind/DatatypeConverter` exception while init.
   
   According to https://github.com/awslabs/amazon-kinesis-producer/issues/242, added the missing dependency to `pom.xml`
   
   ### Modifications
   
   - add `javax.xml.bind` `jaxb-api` to `pom.xml`
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API: (yes / no)
     - The schema: (yes / no / don't know)
     - The default values of configurations: (yes / no)
     - The wire protocol: (yes / no)
     - The rest endpoints: (yes / no)
     - The admin cli options: (yes / no)
     - Anything that affects deployment: (yes / no / don't know)
   
   ### Documentation
   
   Check the box below and label this PR (if you have committer privilege).
   
   Need to update docs? 
   
   - [ ] doc-required 
     
     (If you need help on updating docs, create a doc issue)
     
   - [ ] no-need-doc 
     
     (Please explain why)
     
   - [ ] doc 
     
     (If this PR contains doc changes)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] freeznet merged pull request #12246: [pulsar-io-kinesis] add missing dependency

Posted by GitBox <gi...@apache.org>.
freeznet merged pull request #12246:
URL: https://github.com/apache/pulsar/pull/12246


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] david-streamlio commented on pull request #12246: [pulsar-io-kinesis] add missing dependency

Posted by GitBox <gi...@apache.org>.
david-streamlio commented on pull request #12246:
URL: https://github.com/apache/pulsar/pull/12246#issuecomment-931311633


   LGTM +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org