You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@amaterasu.apache.org by GitBox <gi...@apache.org> on 2019/01/13 22:55:16 UTC

[GitHub] roadan commented on a change in pull request #39: [AMATERASU-52] Implement AmaContext.datastores

roadan commented on a change in pull request #39: [AMATERASU-52] Implement AmaContext.datastores
URL: https://github.com/apache/incubator-amaterasu/pull/39#discussion_r247366504
 
 

 ##########
 File path: leader-common/src/main/kotlin/org/apache/amaterasu/leader/common/configuration/ConfigManager.kt
 ##########
 @@ -18,6 +18,10 @@ package org.apache.amaterasu.leader.common.configuration
 
 import com.uchuhimo.konf.Config
 import com.uchuhimo.konf.source.yaml.toYaml
+import org.apache.amaterasu.leader.common.configuration.dataset.DataSetsSpec
 
 Review comment:
   This should be in its own class (maybe DatasetsManager?) and not a part of the ConfigurationManager. In addition, this should be under the frameworks/jvm-common or frameworks/java-common however we choose to name it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services