You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "morningman (via GitHub)" <gi...@apache.org> on 2023/01/31 04:03:59 UTC
[GitHub] [doris] morningman commented on a diff in pull request #16268: [improvement](session variable)Add enable_file_cache session variable.
morningman commented on code in PR #16268:
URL: https://github.com/apache/doris/pull/16268#discussion_r1091410963
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -675,6 +676,9 @@ public class SessionVariable implements Serializable, Writable {
@VariableMgr.VarAttr(name = TWO_PHASE_READ_OPT_LIMIT_THRESHOLD)
public long twoPhaseReadLimitThreshold = 512;
+ @VariableMgr.VarAttr(name = ENABLE_FILE_CACHE)
Review Comment:
```suggestion
@VariableMgr.VarAttr(name = ENABLE_FILE_CACHE, needForward = true)
```
##########
be/src/vec/exec/format/orc/vorc_reader.h:
##########
@@ -70,11 +70,12 @@ class OrcReader : public GenericReader {
OrcReader(RuntimeProfile* profile, const TFileScanRangeParams& params,
const TFileRangeDesc& range, const std::vector<std::string>& column_names,
- size_t batch_size, const std::string& ctz, IOContext* io_ctx);
+ size_t batch_size, const std::string& ctz, IOContext* io_ctx,
+ bool enable_file_cache = true);
OrcReader(const TFileScanRangeParams& params, const TFileRangeDesc& range,
const std::vector<std::string>& column_names, const std::string& ctz,
- IOContext* io_ctx);
+ IOContext* io_ctx, bool enable_file_cache = true);
Review Comment:
better move `enable_file_cache` into `IOContext`
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -675,6 +676,9 @@ public class SessionVariable implements Serializable, Writable {
@VariableMgr.VarAttr(name = TWO_PHASE_READ_OPT_LIMIT_THRESHOLD)
public long twoPhaseReadLimitThreshold = 512;
+ @VariableMgr.VarAttr(name = ENABLE_FILE_CACHE)
Review Comment:
Please update the doc: https://doris.apache.org/zh-CN/docs/dev/advanced/variables
en and zh-CN
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org