[jira] [Commented] (CALCITE-4171) Support named parameters for table window functions

["Julian Hyde (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-4171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17174963#comment-17174963 ] 

Julian Hyde commented on CALCITE-4171:
--------------------------------------

I removed 'fixVersion = 1.25'. 1.25 has shipped.

Did you test parameters in different orders, and with values missing for earlier parameters? 
Permuting parameters is tricky.

What was your rationale for making the parameter names for HOP etc. lower-case? Most built-in SQL objects are upper-case so that people can use them without double-quoting. (I couldn't find examples of parameter names in the SQL standard, but in any case, we should do as the standard does.)

Did named parameters work for table functions before this? In other words, did you just get it to work for the 3 table functions HOP, TUMBLE, SESSION? If so, you should change the subject to clarify.

> Support named parameters for table window functions
> ---------------------------------------------------
>
>                 Key: CALCITE-4171
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4171
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.23.0, 1.24.0
>            Reporter: Danny Chen
>            Assignee: Danny Chen
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Supports window functions like named params style:
> {code:sql}
> select *
> from table(
> session(
>   data => table Shipments,
>   timecol => descriptor(rowtime),
>   key => descriptor(orderId),
>   size => INTERVAL '10' MINUTE))
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)