You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/11/13 03:12:26 UTC
[GitHub] [hudi] alexeykudinkin opened a new pull request #3986: [HUDI-2550][WIP] Expand File-Group candidates list for appending for MOR tables
alexeykudinkin opened a new pull request #3986:
URL: https://github.com/apache/hudi/pull/3986
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
Addressing [HUDI-2550](https://issues.apache.org/jira/browse/HUDI-2550)
## Brief change log
- Cleaned up small-file FileSlice candidates picking for bin-packing
- Added config property for small file-group candidates limit
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3986: [HUDI-2550][WIP] Expand File-Group candidates list for appending for MOR tables
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3986:
URL: https://github.com/apache/hudi/pull/3986#issuecomment-969258298
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3345",
"triggerID" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"triggerType" : "PUSH"
}, {
"hash" : "786d593265ce66cff0167261dc34fceeeeb9310f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3387",
"triggerID" : "786d593265ce66cff0167261dc34fceeeeb9310f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bec502451cdffe7c4ff8d86aec27482397c28991 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3345)
* 786d593265ce66cff0167261dc34fceeeeb9310f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3387)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #3986: [HUDI-2550][WIP] Expand File-Group candidates list for appending for MOR tables
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3986:
URL: https://github.com/apache/hudi/pull/3986#issuecomment-967770318
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bec502451cdffe7c4ff8d86aec27482397c28991 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3986: [HUDI-2550][WIP] Expand File-Group candidates list for appending for MOR tables
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3986:
URL: https://github.com/apache/hudi/pull/3986#issuecomment-967770318
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bec502451cdffe7c4ff8d86aec27482397c28991 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #3986: [HUDI-2550][WIP] Expand File-Group candidates list for appending for MOR tables
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3986:
URL: https://github.com/apache/hudi/pull/3986#issuecomment-969861810
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3345",
"triggerID" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"triggerType" : "PUSH"
}, {
"hash" : "786d593265ce66cff0167261dc34fceeeeb9310f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3387",
"triggerID" : "786d593265ce66cff0167261dc34fceeeeb9310f",
"triggerType" : "PUSH"
}, {
"hash" : "d6873a12f5a3d16b4e3505243780ea56339b3d2e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3388",
"triggerID" : "d6873a12f5a3d16b4e3505243780ea56339b3d2e",
"triggerType" : "PUSH"
}, {
"hash" : "d6873a12f5a3d16b4e3505243780ea56339b3d2e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3405",
"triggerID" : "969861249",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* d6873a12f5a3d16b4e3505243780ea56339b3d2e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3388) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3405)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] alexeykudinkin commented on a change in pull request #3986: [HUDI-2550][WIP] Expand File-Group candidates list for appending for MOR tables
Posted by GitBox <gi...@apache.org>.
alexeykudinkin commented on a change in pull request #3986:
URL: https://github.com/apache/hudi/pull/3986#discussion_r749626727
##########
File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/deltacommit/SparkUpsertDeltaCommitPartitioner.java
##########
@@ -51,68 +52,70 @@ public SparkUpsertDeltaCommitPartitioner(WorkloadProfile profile, HoodieSparkEng
@Override
protected List<SmallFile> getSmallFiles(String partitionPath) {
-
- // smallFiles only for partitionPath
- List<SmallFile> smallFileLocations = new ArrayList<>();
-
// Init here since this class (and member variables) might not have been initialized
HoodieTimeline commitTimeline = table.getCompletedCommitsTimeline();
- // Find out all eligible small file slices
- if (!commitTimeline.empty()) {
- HoodieInstant latestCommitTime = commitTimeline.lastInstant().get();
- // find smallest file in partition and append to it
- List<FileSlice> allSmallFileSlices = new ArrayList<>();
- // If we cannot index log files, then we choose the smallest parquet file in the partition and add inserts to
- // it. Doing this overtime for a partition, we ensure that we handle small file issues
- if (!table.getIndex().canIndexLogFiles()) {
- // TODO : choose last N small files since there can be multiple small files written to a single partition
- // by different spark partitions in a single batch
- Option<FileSlice> smallFileSlice = Option.fromJavaOptional(table.getSliceView()
- .getLatestFileSlicesBeforeOrOn(partitionPath, latestCommitTime.getTimestamp(), false)
- .filter(
- fileSlice -> fileSlice.getLogFiles().count() < 1 && fileSlice.getBaseFile().get().getFileSize() < config
- .getParquetSmallFileLimit())
- .min((FileSlice left, FileSlice right) ->
- left.getBaseFile().get().getFileSize() < right.getBaseFile().get().getFileSize() ? -1 : 1));
- if (smallFileSlice.isPresent()) {
- allSmallFileSlices.add(smallFileSlice.get());
- }
+ if (commitTimeline.empty()) {
+ return Collections.emptyList();
+ }
+
+ HoodieInstant latestCommitTime = commitTimeline.lastInstant().get();
+
+ // Find out all eligible small file slices, looking for
+ // smallest file in the partition to append to
+ List<FileSlice> smallFileSlicesCandidates = pickSmallFileCandidates(partitionPath, latestCommitTime);
+ List<SmallFile> smallFileLocations = new ArrayList<>();
+
+ // Create SmallFiles from the eligible file slices
+ for (FileSlice smallFileSlice : smallFileSlicesCandidates) {
+ SmallFile sf = new SmallFile();
+ if (smallFileSlice.getBaseFile().isPresent()) {
+ // TODO : Move logic of file name, file id, base commit time handling inside file slice
+ String filename = smallFileSlice.getBaseFile().get().getFileName();
+ sf.location = new HoodieRecordLocation(FSUtils.getCommitTime(filename), FSUtils.getFileId(filename));
+ sf.sizeBytes = getTotalFileSize(smallFileSlice);
+ smallFileLocations.add(sf);
} else {
- // If we can index log files, we can add more inserts to log files for fileIds NOT including those under
- // pending compaction
- List<FileSlice> allFileSlices =
- table.getSliceView().getLatestFileSlicesBeforeOrOn(partitionPath, latestCommitTime.getTimestamp(), false)
- .collect(Collectors.toList());
- for (FileSlice fileSlice : allFileSlices) {
- if (isSmallFile(fileSlice)) {
- allSmallFileSlices.add(fileSlice);
- }
- }
- }
- // Create SmallFiles from the eligible file slices
- for (FileSlice smallFileSlice : allSmallFileSlices) {
- SmallFile sf = new SmallFile();
- if (smallFileSlice.getBaseFile().isPresent()) {
- // TODO : Move logic of file name, file id, base commit time handling inside file slice
- String filename = smallFileSlice.getBaseFile().get().getFileName();
- sf.location = new HoodieRecordLocation(FSUtils.getCommitTime(filename), FSUtils.getFileId(filename));
- sf.sizeBytes = getTotalFileSize(smallFileSlice);
- smallFileLocations.add(sf);
- } else {
- HoodieLogFile logFile = smallFileSlice.getLogFiles().findFirst().get();
- sf.location = new HoodieRecordLocation(FSUtils.getBaseCommitTimeFromLogPath(logFile.getPath()),
- FSUtils.getFileIdFromLogPath(logFile.getPath()));
- sf.sizeBytes = getTotalFileSize(smallFileSlice);
- smallFileLocations.add(sf);
- }
+ HoodieLogFile logFile = smallFileSlice.getLogFiles().findFirst().get();
+ sf.location = new HoodieRecordLocation(FSUtils.getBaseCommitTimeFromLogPath(logFile.getPath()),
+ FSUtils.getFileIdFromLogPath(logFile.getPath()));
+ sf.sizeBytes = getTotalFileSize(smallFileSlice);
+ smallFileLocations.add(sf);
}
}
return smallFileLocations;
}
+ @Nonnull
+ private List<FileSlice> pickSmallFileCandidates(String partitionPath, HoodieInstant latestCommitInstant) {
+ // If we can index log files, we can add more inserts to log files for fileIds NOT including those under
+ // pending compaction
+ if (table.getIndex().canIndexLogFiles()) {
+ return table.getSliceView()
+ .getLatestFileSlicesBeforeOrOn(partitionPath, latestCommitInstant.getTimestamp(), false)
+ .filter(this::isSmallFile)
+ .collect(Collectors.toList());
+ }
+
+ // If we cannot index log files, then we choose the smallest parquet file in the partition and add inserts to
+ // it. Doing this overtime for a partition, we ensure that we handle small file issues
+ // TODO : choose last N small files since there can be multiple small files written to a single partition
Review comment:
Good catch. Forgot to clean up
##########
File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/deltacommit/SparkUpsertDeltaCommitPartitioner.java
##########
@@ -51,68 +52,70 @@ public SparkUpsertDeltaCommitPartitioner(WorkloadProfile profile, HoodieSparkEng
@Override
protected List<SmallFile> getSmallFiles(String partitionPath) {
-
- // smallFiles only for partitionPath
- List<SmallFile> smallFileLocations = new ArrayList<>();
-
// Init here since this class (and member variables) might not have been initialized
HoodieTimeline commitTimeline = table.getCompletedCommitsTimeline();
- // Find out all eligible small file slices
- if (!commitTimeline.empty()) {
- HoodieInstant latestCommitTime = commitTimeline.lastInstant().get();
- // find smallest file in partition and append to it
- List<FileSlice> allSmallFileSlices = new ArrayList<>();
- // If we cannot index log files, then we choose the smallest parquet file in the partition and add inserts to
- // it. Doing this overtime for a partition, we ensure that we handle small file issues
- if (!table.getIndex().canIndexLogFiles()) {
- // TODO : choose last N small files since there can be multiple small files written to a single partition
- // by different spark partitions in a single batch
- Option<FileSlice> smallFileSlice = Option.fromJavaOptional(table.getSliceView()
- .getLatestFileSlicesBeforeOrOn(partitionPath, latestCommitTime.getTimestamp(), false)
- .filter(
- fileSlice -> fileSlice.getLogFiles().count() < 1 && fileSlice.getBaseFile().get().getFileSize() < config
- .getParquetSmallFileLimit())
- .min((FileSlice left, FileSlice right) ->
- left.getBaseFile().get().getFileSize() < right.getBaseFile().get().getFileSize() ? -1 : 1));
- if (smallFileSlice.isPresent()) {
- allSmallFileSlices.add(smallFileSlice.get());
- }
+ if (commitTimeline.empty()) {
+ return Collections.emptyList();
+ }
+
+ HoodieInstant latestCommitTime = commitTimeline.lastInstant().get();
+
+ // Find out all eligible small file slices, looking for
+ // smallest file in the partition to append to
+ List<FileSlice> smallFileSlicesCandidates = pickSmallFileCandidates(partitionPath, latestCommitTime);
+ List<SmallFile> smallFileLocations = new ArrayList<>();
+
+ // Create SmallFiles from the eligible file slices
+ for (FileSlice smallFileSlice : smallFileSlicesCandidates) {
+ SmallFile sf = new SmallFile();
+ if (smallFileSlice.getBaseFile().isPresent()) {
+ // TODO : Move logic of file name, file id, base commit time handling inside file slice
+ String filename = smallFileSlice.getBaseFile().get().getFileName();
+ sf.location = new HoodieRecordLocation(FSUtils.getCommitTime(filename), FSUtils.getFileId(filename));
+ sf.sizeBytes = getTotalFileSize(smallFileSlice);
+ smallFileLocations.add(sf);
} else {
- // If we can index log files, we can add more inserts to log files for fileIds NOT including those under
- // pending compaction
- List<FileSlice> allFileSlices =
- table.getSliceView().getLatestFileSlicesBeforeOrOn(partitionPath, latestCommitTime.getTimestamp(), false)
- .collect(Collectors.toList());
- for (FileSlice fileSlice : allFileSlices) {
- if (isSmallFile(fileSlice)) {
- allSmallFileSlices.add(fileSlice);
- }
- }
- }
- // Create SmallFiles from the eligible file slices
- for (FileSlice smallFileSlice : allSmallFileSlices) {
- SmallFile sf = new SmallFile();
- if (smallFileSlice.getBaseFile().isPresent()) {
- // TODO : Move logic of file name, file id, base commit time handling inside file slice
- String filename = smallFileSlice.getBaseFile().get().getFileName();
- sf.location = new HoodieRecordLocation(FSUtils.getCommitTime(filename), FSUtils.getFileId(filename));
- sf.sizeBytes = getTotalFileSize(smallFileSlice);
- smallFileLocations.add(sf);
- } else {
- HoodieLogFile logFile = smallFileSlice.getLogFiles().findFirst().get();
- sf.location = new HoodieRecordLocation(FSUtils.getBaseCommitTimeFromLogPath(logFile.getPath()),
- FSUtils.getFileIdFromLogPath(logFile.getPath()));
- sf.sizeBytes = getTotalFileSize(smallFileSlice);
- smallFileLocations.add(sf);
- }
+ HoodieLogFile logFile = smallFileSlice.getLogFiles().findFirst().get();
+ sf.location = new HoodieRecordLocation(FSUtils.getBaseCommitTimeFromLogPath(logFile.getPath()),
+ FSUtils.getFileIdFromLogPath(logFile.getPath()));
+ sf.sizeBytes = getTotalFileSize(smallFileSlice);
+ smallFileLocations.add(sf);
}
}
return smallFileLocations;
}
+ @Nonnull
+ private List<FileSlice> pickSmallFileCandidates(String partitionPath, HoodieInstant latestCommitInstant) {
+ // If we can index log files, we can add more inserts to log files for fileIds NOT including those under
+ // pending compaction
+ if (table.getIndex().canIndexLogFiles()) {
+ return table.getSliceView()
+ .getLatestFileSlicesBeforeOrOn(partitionPath, latestCommitInstant.getTimestamp(), false)
+ .filter(this::isSmallFile)
+ .collect(Collectors.toList());
+ }
+
Review comment:
I'm actually deliberately inverting those conditionals to drop some of the else blocks to reduce nesting, by facilitating early returns
##########
File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/deltacommit/SparkUpsertDeltaCommitPartitioner.java
##########
@@ -51,68 +52,70 @@ public SparkUpsertDeltaCommitPartitioner(WorkloadProfile profile, HoodieSparkEng
@Override
protected List<SmallFile> getSmallFiles(String partitionPath) {
-
- // smallFiles only for partitionPath
- List<SmallFile> smallFileLocations = new ArrayList<>();
-
// Init here since this class (and member variables) might not have been initialized
HoodieTimeline commitTimeline = table.getCompletedCommitsTimeline();
- // Find out all eligible small file slices
- if (!commitTimeline.empty()) {
- HoodieInstant latestCommitTime = commitTimeline.lastInstant().get();
- // find smallest file in partition and append to it
- List<FileSlice> allSmallFileSlices = new ArrayList<>();
- // If we cannot index log files, then we choose the smallest parquet file in the partition and add inserts to
- // it. Doing this overtime for a partition, we ensure that we handle small file issues
- if (!table.getIndex().canIndexLogFiles()) {
- // TODO : choose last N small files since there can be multiple small files written to a single partition
- // by different spark partitions in a single batch
- Option<FileSlice> smallFileSlice = Option.fromJavaOptional(table.getSliceView()
- .getLatestFileSlicesBeforeOrOn(partitionPath, latestCommitTime.getTimestamp(), false)
- .filter(
- fileSlice -> fileSlice.getLogFiles().count() < 1 && fileSlice.getBaseFile().get().getFileSize() < config
- .getParquetSmallFileLimit())
- .min((FileSlice left, FileSlice right) ->
- left.getBaseFile().get().getFileSize() < right.getBaseFile().get().getFileSize() ? -1 : 1));
- if (smallFileSlice.isPresent()) {
- allSmallFileSlices.add(smallFileSlice.get());
- }
+ if (commitTimeline.empty()) {
+ return Collections.emptyList();
+ }
+
+ HoodieInstant latestCommitTime = commitTimeline.lastInstant().get();
+
+ // Find out all eligible small file slices, looking for
+ // smallest file in the partition to append to
+ List<FileSlice> smallFileSlicesCandidates = pickSmallFileCandidates(partitionPath, latestCommitTime);
+ List<SmallFile> smallFileLocations = new ArrayList<>();
+
+ // Create SmallFiles from the eligible file slices
+ for (FileSlice smallFileSlice : smallFileSlicesCandidates) {
+ SmallFile sf = new SmallFile();
+ if (smallFileSlice.getBaseFile().isPresent()) {
+ // TODO : Move logic of file name, file id, base commit time handling inside file slice
+ String filename = smallFileSlice.getBaseFile().get().getFileName();
+ sf.location = new HoodieRecordLocation(FSUtils.getCommitTime(filename), FSUtils.getFileId(filename));
+ sf.sizeBytes = getTotalFileSize(smallFileSlice);
+ smallFileLocations.add(sf);
} else {
- // If we can index log files, we can add more inserts to log files for fileIds NOT including those under
- // pending compaction
- List<FileSlice> allFileSlices =
- table.getSliceView().getLatestFileSlicesBeforeOrOn(partitionPath, latestCommitTime.getTimestamp(), false)
- .collect(Collectors.toList());
- for (FileSlice fileSlice : allFileSlices) {
- if (isSmallFile(fileSlice)) {
- allSmallFileSlices.add(fileSlice);
- }
- }
- }
- // Create SmallFiles from the eligible file slices
- for (FileSlice smallFileSlice : allSmallFileSlices) {
- SmallFile sf = new SmallFile();
- if (smallFileSlice.getBaseFile().isPresent()) {
- // TODO : Move logic of file name, file id, base commit time handling inside file slice
- String filename = smallFileSlice.getBaseFile().get().getFileName();
- sf.location = new HoodieRecordLocation(FSUtils.getCommitTime(filename), FSUtils.getFileId(filename));
- sf.sizeBytes = getTotalFileSize(smallFileSlice);
- smallFileLocations.add(sf);
- } else {
- HoodieLogFile logFile = smallFileSlice.getLogFiles().findFirst().get();
- sf.location = new HoodieRecordLocation(FSUtils.getBaseCommitTimeFromLogPath(logFile.getPath()),
- FSUtils.getFileIdFromLogPath(logFile.getPath()));
- sf.sizeBytes = getTotalFileSize(smallFileSlice);
- smallFileLocations.add(sf);
- }
+ HoodieLogFile logFile = smallFileSlice.getLogFiles().findFirst().get();
+ sf.location = new HoodieRecordLocation(FSUtils.getBaseCommitTimeFromLogPath(logFile.getPath()),
+ FSUtils.getFileIdFromLogPath(logFile.getPath()));
+ sf.sizeBytes = getTotalFileSize(smallFileSlice);
+ smallFileLocations.add(sf);
}
}
return smallFileLocations;
}
+ @Nonnull
+ private List<FileSlice> pickSmallFileCandidates(String partitionPath, HoodieInstant latestCommitInstant) {
+ // If we can index log files, we can add more inserts to log files for fileIds NOT including those under
+ // pending compaction
+ if (table.getIndex().canIndexLogFiles()) {
+ return table.getSliceView()
+ .getLatestFileSlicesBeforeOrOn(partitionPath, latestCommitInstant.getTimestamp(), false)
+ .filter(this::isSmallFile)
+ .collect(Collectors.toList());
+ }
+
Review comment:
Here's [good example](https://softwareengineering.stackexchange.com/a/18473/326225) of how early returns streamline control flow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3986: [HUDI-2550] Expand File-Group candidates list for appending for MOR tables
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3986:
URL: https://github.com/apache/hudi/pull/3986#issuecomment-975990782
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3345",
"triggerID" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"triggerType" : "PUSH"
}, {
"hash" : "786d593265ce66cff0167261dc34fceeeeb9310f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3387",
"triggerID" : "786d593265ce66cff0167261dc34fceeeeb9310f",
"triggerType" : "PUSH"
}, {
"hash" : "d6873a12f5a3d16b4e3505243780ea56339b3d2e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3388",
"triggerID" : "d6873a12f5a3d16b4e3505243780ea56339b3d2e",
"triggerType" : "PUSH"
}, {
"hash" : "d6873a12f5a3d16b4e3505243780ea56339b3d2e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3405",
"triggerID" : "969861249",
"triggerType" : "MANUAL"
}, {
"hash" : "1e675d3964b69da921b8d5b68c329094cb4f56b5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3604",
"triggerID" : "1e675d3964b69da921b8d5b68c329094cb4f56b5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d6873a12f5a3d16b4e3505243780ea56339b3d2e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3388) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3405)
* 1e675d3964b69da921b8d5b68c329094cb4f56b5 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3604)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #3986: [HUDI-2550] Expand File-Group candidates list for appending for MOR tables
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3986:
URL: https://github.com/apache/hudi/pull/3986#issuecomment-969897836
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3345",
"triggerID" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"triggerType" : "PUSH"
}, {
"hash" : "786d593265ce66cff0167261dc34fceeeeb9310f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3387",
"triggerID" : "786d593265ce66cff0167261dc34fceeeeb9310f",
"triggerType" : "PUSH"
}, {
"hash" : "d6873a12f5a3d16b4e3505243780ea56339b3d2e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3388",
"triggerID" : "d6873a12f5a3d16b4e3505243780ea56339b3d2e",
"triggerType" : "PUSH"
}, {
"hash" : "d6873a12f5a3d16b4e3505243780ea56339b3d2e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3405",
"triggerID" : "969861249",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* d6873a12f5a3d16b4e3505243780ea56339b3d2e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3388) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3405)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #3986: [HUDI-2550][WIP] Expand File-Group candidates list for appending for MOR tables
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3986:
URL: https://github.com/apache/hudi/pull/3986#issuecomment-969344397
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3345",
"triggerID" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"triggerType" : "PUSH"
}, {
"hash" : "786d593265ce66cff0167261dc34fceeeeb9310f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3387",
"triggerID" : "786d593265ce66cff0167261dc34fceeeeb9310f",
"triggerType" : "PUSH"
}, {
"hash" : "d6873a12f5a3d16b4e3505243780ea56339b3d2e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3388",
"triggerID" : "d6873a12f5a3d16b4e3505243780ea56339b3d2e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d6873a12f5a3d16b4e3505243780ea56339b3d2e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3388)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #3986: [HUDI-2550][WIP] Expand File-Group candidates list for appending for MOR tables
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3986:
URL: https://github.com/apache/hudi/pull/3986#issuecomment-967775890
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3345",
"triggerID" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bec502451cdffe7c4ff8d86aec27482397c28991 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3345)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3986: [HUDI-2550][WIP] Expand File-Group candidates list for appending for MOR tables
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3986:
URL: https://github.com/apache/hudi/pull/3986#issuecomment-969344397
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3345",
"triggerID" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"triggerType" : "PUSH"
}, {
"hash" : "786d593265ce66cff0167261dc34fceeeeb9310f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3387",
"triggerID" : "786d593265ce66cff0167261dc34fceeeeb9310f",
"triggerType" : "PUSH"
}, {
"hash" : "d6873a12f5a3d16b4e3505243780ea56339b3d2e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3388",
"triggerID" : "d6873a12f5a3d16b4e3505243780ea56339b3d2e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d6873a12f5a3d16b4e3505243780ea56339b3d2e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3388)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #3986: [HUDI-2550][WIP] Expand File-Group candidates list for appending for MOR tables
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3986:
URL: https://github.com/apache/hudi/pull/3986#issuecomment-969264702
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3345",
"triggerID" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"triggerType" : "PUSH"
}, {
"hash" : "786d593265ce66cff0167261dc34fceeeeb9310f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3387",
"triggerID" : "786d593265ce66cff0167261dc34fceeeeb9310f",
"triggerType" : "PUSH"
}, {
"hash" : "d6873a12f5a3d16b4e3505243780ea56339b3d2e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d6873a12f5a3d16b4e3505243780ea56339b3d2e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bec502451cdffe7c4ff8d86aec27482397c28991 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3345)
* 786d593265ce66cff0167261dc34fceeeeb9310f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3387)
* d6873a12f5a3d16b4e3505243780ea56339b3d2e UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #3986: [HUDI-2550][WIP] Expand File-Group candidates list for appending for MOR tables
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3986:
URL: https://github.com/apache/hudi/pull/3986#issuecomment-969258298
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3345",
"triggerID" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"triggerType" : "PUSH"
}, {
"hash" : "786d593265ce66cff0167261dc34fceeeeb9310f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3387",
"triggerID" : "786d593265ce66cff0167261dc34fceeeeb9310f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bec502451cdffe7c4ff8d86aec27482397c28991 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3345)
* 786d593265ce66cff0167261dc34fceeeeb9310f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3387)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #3986: [HUDI-2550] Expand File-Group candidates list for appending for MOR tables
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3986:
URL: https://github.com/apache/hudi/pull/3986#issuecomment-975990782
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3345",
"triggerID" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"triggerType" : "PUSH"
}, {
"hash" : "786d593265ce66cff0167261dc34fceeeeb9310f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3387",
"triggerID" : "786d593265ce66cff0167261dc34fceeeeb9310f",
"triggerType" : "PUSH"
}, {
"hash" : "d6873a12f5a3d16b4e3505243780ea56339b3d2e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3388",
"triggerID" : "d6873a12f5a3d16b4e3505243780ea56339b3d2e",
"triggerType" : "PUSH"
}, {
"hash" : "d6873a12f5a3d16b4e3505243780ea56339b3d2e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3405",
"triggerID" : "969861249",
"triggerType" : "MANUAL"
}, {
"hash" : "1e675d3964b69da921b8d5b68c329094cb4f56b5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3604",
"triggerID" : "1e675d3964b69da921b8d5b68c329094cb4f56b5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d6873a12f5a3d16b4e3505243780ea56339b3d2e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3388) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3405)
* 1e675d3964b69da921b8d5b68c329094cb4f56b5 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3604)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a change in pull request #3986: [HUDI-2550] Expand File-Group candidates list for appending for MOR tables
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #3986:
URL: https://github.com/apache/hudi/pull/3986#discussion_r754728246
##########
File path: hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/action/commit/TestUpsertPartitioner.java
##########
@@ -434,6 +434,49 @@ public void testUpsertPartitionerWithSmallFileHandlingWithCanIndexLogFiles() thr
"Insert should be assigned to fg1");
}
+ @Test
+ public void testUpsertPartitionerWithSmallFileHandlingPickingMultipleCandidates() throws Exception {
+ final String partitionPath = DEFAULT_PARTITION_PATHS[0];
+
+ HoodieWriteConfig config =
Review comment:
I will land this for now. But when you get a chance, can you make this test configurable w/ diff values for the config that we just added. Just to make sure the config is honored for diff values. just 2 diff values would suffice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3986: [HUDI-2550][WIP] Expand File-Group candidates list for appending for MOR tables
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3986:
URL: https://github.com/apache/hudi/pull/3986#issuecomment-969861810
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3345",
"triggerID" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"triggerType" : "PUSH"
}, {
"hash" : "786d593265ce66cff0167261dc34fceeeeb9310f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3387",
"triggerID" : "786d593265ce66cff0167261dc34fceeeeb9310f",
"triggerType" : "PUSH"
}, {
"hash" : "d6873a12f5a3d16b4e3505243780ea56339b3d2e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3388",
"triggerID" : "d6873a12f5a3d16b4e3505243780ea56339b3d2e",
"triggerType" : "PUSH"
}, {
"hash" : "d6873a12f5a3d16b4e3505243780ea56339b3d2e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3405",
"triggerID" : "969861249",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* d6873a12f5a3d16b4e3505243780ea56339b3d2e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3388) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3405)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3986: [HUDI-2550][WIP] Expand File-Group candidates list for appending for MOR tables
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3986:
URL: https://github.com/apache/hudi/pull/3986#issuecomment-969897836
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3345",
"triggerID" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"triggerType" : "PUSH"
}, {
"hash" : "786d593265ce66cff0167261dc34fceeeeb9310f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3387",
"triggerID" : "786d593265ce66cff0167261dc34fceeeeb9310f",
"triggerType" : "PUSH"
}, {
"hash" : "d6873a12f5a3d16b4e3505243780ea56339b3d2e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3388",
"triggerID" : "d6873a12f5a3d16b4e3505243780ea56339b3d2e",
"triggerType" : "PUSH"
}, {
"hash" : "d6873a12f5a3d16b4e3505243780ea56339b3d2e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3405",
"triggerID" : "969861249",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* d6873a12f5a3d16b4e3505243780ea56339b3d2e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3388) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3405)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3986: [HUDI-2550][WIP] Expand File-Group candidates list for appending for MOR tables
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3986:
URL: https://github.com/apache/hudi/pull/3986#issuecomment-969266770
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3345",
"triggerID" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"triggerType" : "PUSH"
}, {
"hash" : "786d593265ce66cff0167261dc34fceeeeb9310f",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3387",
"triggerID" : "786d593265ce66cff0167261dc34fceeeeb9310f",
"triggerType" : "PUSH"
}, {
"hash" : "d6873a12f5a3d16b4e3505243780ea56339b3d2e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d6873a12f5a3d16b4e3505243780ea56339b3d2e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 786d593265ce66cff0167261dc34fceeeeb9310f Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3387)
* d6873a12f5a3d16b4e3505243780ea56339b3d2e UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a change in pull request #3986: [HUDI-2550][WIP] Expand File-Group candidates list for appending for MOR tables
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #3986:
URL: https://github.com/apache/hudi/pull/3986#discussion_r749415355
##########
File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/deltacommit/SparkUpsertDeltaCommitPartitioner.java
##########
@@ -51,68 +52,70 @@ public SparkUpsertDeltaCommitPartitioner(WorkloadProfile profile, HoodieSparkEng
@Override
protected List<SmallFile> getSmallFiles(String partitionPath) {
-
- // smallFiles only for partitionPath
- List<SmallFile> smallFileLocations = new ArrayList<>();
-
// Init here since this class (and member variables) might not have been initialized
HoodieTimeline commitTimeline = table.getCompletedCommitsTimeline();
- // Find out all eligible small file slices
- if (!commitTimeline.empty()) {
- HoodieInstant latestCommitTime = commitTimeline.lastInstant().get();
- // find smallest file in partition and append to it
- List<FileSlice> allSmallFileSlices = new ArrayList<>();
- // If we cannot index log files, then we choose the smallest parquet file in the partition and add inserts to
- // it. Doing this overtime for a partition, we ensure that we handle small file issues
- if (!table.getIndex().canIndexLogFiles()) {
- // TODO : choose last N small files since there can be multiple small files written to a single partition
- // by different spark partitions in a single batch
- Option<FileSlice> smallFileSlice = Option.fromJavaOptional(table.getSliceView()
- .getLatestFileSlicesBeforeOrOn(partitionPath, latestCommitTime.getTimestamp(), false)
- .filter(
- fileSlice -> fileSlice.getLogFiles().count() < 1 && fileSlice.getBaseFile().get().getFileSize() < config
- .getParquetSmallFileLimit())
- .min((FileSlice left, FileSlice right) ->
- left.getBaseFile().get().getFileSize() < right.getBaseFile().get().getFileSize() ? -1 : 1));
- if (smallFileSlice.isPresent()) {
- allSmallFileSlices.add(smallFileSlice.get());
- }
+ if (commitTimeline.empty()) {
+ return Collections.emptyList();
+ }
+
+ HoodieInstant latestCommitTime = commitTimeline.lastInstant().get();
+
+ // Find out all eligible small file slices, looking for
+ // smallest file in the partition to append to
+ List<FileSlice> smallFileSlicesCandidates = pickSmallFileCandidates(partitionPath, latestCommitTime);
+ List<SmallFile> smallFileLocations = new ArrayList<>();
+
+ // Create SmallFiles from the eligible file slices
+ for (FileSlice smallFileSlice : smallFileSlicesCandidates) {
+ SmallFile sf = new SmallFile();
+ if (smallFileSlice.getBaseFile().isPresent()) {
+ // TODO : Move logic of file name, file id, base commit time handling inside file slice
+ String filename = smallFileSlice.getBaseFile().get().getFileName();
+ sf.location = new HoodieRecordLocation(FSUtils.getCommitTime(filename), FSUtils.getFileId(filename));
+ sf.sizeBytes = getTotalFileSize(smallFileSlice);
+ smallFileLocations.add(sf);
} else {
- // If we can index log files, we can add more inserts to log files for fileIds NOT including those under
- // pending compaction
- List<FileSlice> allFileSlices =
- table.getSliceView().getLatestFileSlicesBeforeOrOn(partitionPath, latestCommitTime.getTimestamp(), false)
- .collect(Collectors.toList());
- for (FileSlice fileSlice : allFileSlices) {
- if (isSmallFile(fileSlice)) {
- allSmallFileSlices.add(fileSlice);
- }
- }
- }
- // Create SmallFiles from the eligible file slices
- for (FileSlice smallFileSlice : allSmallFileSlices) {
- SmallFile sf = new SmallFile();
- if (smallFileSlice.getBaseFile().isPresent()) {
- // TODO : Move logic of file name, file id, base commit time handling inside file slice
- String filename = smallFileSlice.getBaseFile().get().getFileName();
- sf.location = new HoodieRecordLocation(FSUtils.getCommitTime(filename), FSUtils.getFileId(filename));
- sf.sizeBytes = getTotalFileSize(smallFileSlice);
- smallFileLocations.add(sf);
- } else {
- HoodieLogFile logFile = smallFileSlice.getLogFiles().findFirst().get();
- sf.location = new HoodieRecordLocation(FSUtils.getBaseCommitTimeFromLogPath(logFile.getPath()),
- FSUtils.getFileIdFromLogPath(logFile.getPath()));
- sf.sizeBytes = getTotalFileSize(smallFileSlice);
- smallFileLocations.add(sf);
- }
+ HoodieLogFile logFile = smallFileSlice.getLogFiles().findFirst().get();
+ sf.location = new HoodieRecordLocation(FSUtils.getBaseCommitTimeFromLogPath(logFile.getPath()),
+ FSUtils.getFileIdFromLogPath(logFile.getPath()));
+ sf.sizeBytes = getTotalFileSize(smallFileSlice);
+ smallFileLocations.add(sf);
}
}
return smallFileLocations;
}
+ @Nonnull
+ private List<FileSlice> pickSmallFileCandidates(String partitionPath, HoodieInstant latestCommitInstant) {
Review comment:
minor. getSmallFileCandidates to be in line with how we name other similar methods.
##########
File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/deltacommit/SparkUpsertDeltaCommitPartitioner.java
##########
@@ -51,68 +52,70 @@ public SparkUpsertDeltaCommitPartitioner(WorkloadProfile profile, HoodieSparkEng
@Override
protected List<SmallFile> getSmallFiles(String partitionPath) {
-
- // smallFiles only for partitionPath
- List<SmallFile> smallFileLocations = new ArrayList<>();
-
// Init here since this class (and member variables) might not have been initialized
HoodieTimeline commitTimeline = table.getCompletedCommitsTimeline();
- // Find out all eligible small file slices
- if (!commitTimeline.empty()) {
- HoodieInstant latestCommitTime = commitTimeline.lastInstant().get();
- // find smallest file in partition and append to it
- List<FileSlice> allSmallFileSlices = new ArrayList<>();
- // If we cannot index log files, then we choose the smallest parquet file in the partition and add inserts to
- // it. Doing this overtime for a partition, we ensure that we handle small file issues
- if (!table.getIndex().canIndexLogFiles()) {
- // TODO : choose last N small files since there can be multiple small files written to a single partition
- // by different spark partitions in a single batch
- Option<FileSlice> smallFileSlice = Option.fromJavaOptional(table.getSliceView()
- .getLatestFileSlicesBeforeOrOn(partitionPath, latestCommitTime.getTimestamp(), false)
- .filter(
- fileSlice -> fileSlice.getLogFiles().count() < 1 && fileSlice.getBaseFile().get().getFileSize() < config
- .getParquetSmallFileLimit())
- .min((FileSlice left, FileSlice right) ->
- left.getBaseFile().get().getFileSize() < right.getBaseFile().get().getFileSize() ? -1 : 1));
- if (smallFileSlice.isPresent()) {
- allSmallFileSlices.add(smallFileSlice.get());
- }
+ if (commitTimeline.empty()) {
+ return Collections.emptyList();
+ }
+
+ HoodieInstant latestCommitTime = commitTimeline.lastInstant().get();
+
+ // Find out all eligible small file slices, looking for
+ // smallest file in the partition to append to
+ List<FileSlice> smallFileSlicesCandidates = pickSmallFileCandidates(partitionPath, latestCommitTime);
+ List<SmallFile> smallFileLocations = new ArrayList<>();
+
+ // Create SmallFiles from the eligible file slices
+ for (FileSlice smallFileSlice : smallFileSlicesCandidates) {
+ SmallFile sf = new SmallFile();
+ if (smallFileSlice.getBaseFile().isPresent()) {
+ // TODO : Move logic of file name, file id, base commit time handling inside file slice
+ String filename = smallFileSlice.getBaseFile().get().getFileName();
+ sf.location = new HoodieRecordLocation(FSUtils.getCommitTime(filename), FSUtils.getFileId(filename));
+ sf.sizeBytes = getTotalFileSize(smallFileSlice);
+ smallFileLocations.add(sf);
} else {
- // If we can index log files, we can add more inserts to log files for fileIds NOT including those under
- // pending compaction
- List<FileSlice> allFileSlices =
- table.getSliceView().getLatestFileSlicesBeforeOrOn(partitionPath, latestCommitTime.getTimestamp(), false)
- .collect(Collectors.toList());
- for (FileSlice fileSlice : allFileSlices) {
- if (isSmallFile(fileSlice)) {
- allSmallFileSlices.add(fileSlice);
- }
- }
- }
- // Create SmallFiles from the eligible file slices
- for (FileSlice smallFileSlice : allSmallFileSlices) {
- SmallFile sf = new SmallFile();
- if (smallFileSlice.getBaseFile().isPresent()) {
- // TODO : Move logic of file name, file id, base commit time handling inside file slice
- String filename = smallFileSlice.getBaseFile().get().getFileName();
- sf.location = new HoodieRecordLocation(FSUtils.getCommitTime(filename), FSUtils.getFileId(filename));
- sf.sizeBytes = getTotalFileSize(smallFileSlice);
- smallFileLocations.add(sf);
- } else {
- HoodieLogFile logFile = smallFileSlice.getLogFiles().findFirst().get();
- sf.location = new HoodieRecordLocation(FSUtils.getBaseCommitTimeFromLogPath(logFile.getPath()),
- FSUtils.getFileIdFromLogPath(logFile.getPath()));
- sf.sizeBytes = getTotalFileSize(smallFileSlice);
- smallFileLocations.add(sf);
- }
+ HoodieLogFile logFile = smallFileSlice.getLogFiles().findFirst().get();
+ sf.location = new HoodieRecordLocation(FSUtils.getBaseCommitTimeFromLogPath(logFile.getPath()),
+ FSUtils.getFileIdFromLogPath(logFile.getPath()));
+ sf.sizeBytes = getTotalFileSize(smallFileSlice);
+ smallFileLocations.add(sf);
}
}
return smallFileLocations;
}
+ @Nonnull
+ private List<FileSlice> pickSmallFileCandidates(String partitionPath, HoodieInstant latestCommitInstant) {
+ // If we can index log files, we can add more inserts to log files for fileIds NOT including those under
+ // pending compaction
+ if (table.getIndex().canIndexLogFiles()) {
+ return table.getSliceView()
+ .getLatestFileSlicesBeforeOrOn(partitionPath, latestCommitInstant.getTimestamp(), false)
+ .filter(this::isSmallFile)
+ .collect(Collectors.toList());
+ }
+
Review comment:
can we add in else {} here so that its explicit.
##########
File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/deltacommit/SparkUpsertDeltaCommitPartitioner.java
##########
@@ -51,68 +52,70 @@ public SparkUpsertDeltaCommitPartitioner(WorkloadProfile profile, HoodieSparkEng
@Override
protected List<SmallFile> getSmallFiles(String partitionPath) {
-
- // smallFiles only for partitionPath
- List<SmallFile> smallFileLocations = new ArrayList<>();
-
// Init here since this class (and member variables) might not have been initialized
HoodieTimeline commitTimeline = table.getCompletedCommitsTimeline();
- // Find out all eligible small file slices
- if (!commitTimeline.empty()) {
- HoodieInstant latestCommitTime = commitTimeline.lastInstant().get();
- // find smallest file in partition and append to it
- List<FileSlice> allSmallFileSlices = new ArrayList<>();
- // If we cannot index log files, then we choose the smallest parquet file in the partition and add inserts to
- // it. Doing this overtime for a partition, we ensure that we handle small file issues
- if (!table.getIndex().canIndexLogFiles()) {
- // TODO : choose last N small files since there can be multiple small files written to a single partition
- // by different spark partitions in a single batch
- Option<FileSlice> smallFileSlice = Option.fromJavaOptional(table.getSliceView()
- .getLatestFileSlicesBeforeOrOn(partitionPath, latestCommitTime.getTimestamp(), false)
- .filter(
- fileSlice -> fileSlice.getLogFiles().count() < 1 && fileSlice.getBaseFile().get().getFileSize() < config
- .getParquetSmallFileLimit())
- .min((FileSlice left, FileSlice right) ->
- left.getBaseFile().get().getFileSize() < right.getBaseFile().get().getFileSize() ? -1 : 1));
- if (smallFileSlice.isPresent()) {
- allSmallFileSlices.add(smallFileSlice.get());
- }
+ if (commitTimeline.empty()) {
+ return Collections.emptyList();
+ }
+
+ HoodieInstant latestCommitTime = commitTimeline.lastInstant().get();
+
+ // Find out all eligible small file slices, looking for
+ // smallest file in the partition to append to
+ List<FileSlice> smallFileSlicesCandidates = pickSmallFileCandidates(partitionPath, latestCommitTime);
+ List<SmallFile> smallFileLocations = new ArrayList<>();
+
+ // Create SmallFiles from the eligible file slices
+ for (FileSlice smallFileSlice : smallFileSlicesCandidates) {
+ SmallFile sf = new SmallFile();
+ if (smallFileSlice.getBaseFile().isPresent()) {
+ // TODO : Move logic of file name, file id, base commit time handling inside file slice
+ String filename = smallFileSlice.getBaseFile().get().getFileName();
+ sf.location = new HoodieRecordLocation(FSUtils.getCommitTime(filename), FSUtils.getFileId(filename));
+ sf.sizeBytes = getTotalFileSize(smallFileSlice);
+ smallFileLocations.add(sf);
} else {
- // If we can index log files, we can add more inserts to log files for fileIds NOT including those under
- // pending compaction
- List<FileSlice> allFileSlices =
- table.getSliceView().getLatestFileSlicesBeforeOrOn(partitionPath, latestCommitTime.getTimestamp(), false)
- .collect(Collectors.toList());
- for (FileSlice fileSlice : allFileSlices) {
- if (isSmallFile(fileSlice)) {
- allSmallFileSlices.add(fileSlice);
- }
- }
- }
- // Create SmallFiles from the eligible file slices
- for (FileSlice smallFileSlice : allSmallFileSlices) {
- SmallFile sf = new SmallFile();
- if (smallFileSlice.getBaseFile().isPresent()) {
- // TODO : Move logic of file name, file id, base commit time handling inside file slice
- String filename = smallFileSlice.getBaseFile().get().getFileName();
- sf.location = new HoodieRecordLocation(FSUtils.getCommitTime(filename), FSUtils.getFileId(filename));
- sf.sizeBytes = getTotalFileSize(smallFileSlice);
- smallFileLocations.add(sf);
- } else {
- HoodieLogFile logFile = smallFileSlice.getLogFiles().findFirst().get();
- sf.location = new HoodieRecordLocation(FSUtils.getBaseCommitTimeFromLogPath(logFile.getPath()),
- FSUtils.getFileIdFromLogPath(logFile.getPath()));
- sf.sizeBytes = getTotalFileSize(smallFileSlice);
- smallFileLocations.add(sf);
- }
+ HoodieLogFile logFile = smallFileSlice.getLogFiles().findFirst().get();
+ sf.location = new HoodieRecordLocation(FSUtils.getBaseCommitTimeFromLogPath(logFile.getPath()),
+ FSUtils.getFileIdFromLogPath(logFile.getPath()));
+ sf.sizeBytes = getTotalFileSize(smallFileSlice);
+ smallFileLocations.add(sf);
}
}
return smallFileLocations;
}
+ @Nonnull
+ private List<FileSlice> pickSmallFileCandidates(String partitionPath, HoodieInstant latestCommitInstant) {
+ // If we can index log files, we can add more inserts to log files for fileIds NOT including those under
+ // pending compaction
+ if (table.getIndex().canIndexLogFiles()) {
+ return table.getSliceView()
+ .getLatestFileSlicesBeforeOrOn(partitionPath, latestCommitInstant.getTimestamp(), false)
+ .filter(this::isSmallFile)
+ .collect(Collectors.toList());
+ }
+
+ // If we cannot index log files, then we choose the smallest parquet file in the partition and add inserts to
+ // it. Doing this overtime for a partition, we ensure that we handle small file issues
+ // TODO : choose last N small files since there can be multiple small files written to a single partition
Review comment:
why TODO ? I see we already limit by config.getSmallFileGroupCandidatesLimit() below. is there anything pending still ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3986: [HUDI-2550][WIP] Expand File-Group candidates list for appending for MOR tables
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3986:
URL: https://github.com/apache/hudi/pull/3986#issuecomment-969264702
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3345",
"triggerID" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"triggerType" : "PUSH"
}, {
"hash" : "786d593265ce66cff0167261dc34fceeeeb9310f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3387",
"triggerID" : "786d593265ce66cff0167261dc34fceeeeb9310f",
"triggerType" : "PUSH"
}, {
"hash" : "d6873a12f5a3d16b4e3505243780ea56339b3d2e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d6873a12f5a3d16b4e3505243780ea56339b3d2e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bec502451cdffe7c4ff8d86aec27482397c28991 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3345)
* 786d593265ce66cff0167261dc34fceeeeb9310f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3387)
* d6873a12f5a3d16b4e3505243780ea56339b3d2e UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3986: [HUDI-2550][WIP] Expand File-Group candidates list for appending for MOR tables
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3986:
URL: https://github.com/apache/hudi/pull/3986#issuecomment-969256253
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3345",
"triggerID" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"triggerType" : "PUSH"
}, {
"hash" : "786d593265ce66cff0167261dc34fceeeeb9310f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "786d593265ce66cff0167261dc34fceeeeb9310f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bec502451cdffe7c4ff8d86aec27482397c28991 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3345)
* 786d593265ce66cff0167261dc34fceeeeb9310f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #3986: [HUDI-2550][WIP] Expand File-Group candidates list for appending for MOR tables
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3986:
URL: https://github.com/apache/hudi/pull/3986#issuecomment-967770621
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3345",
"triggerID" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bec502451cdffe7c4ff8d86aec27482397c28991 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3345)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3986: [HUDI-2550][WIP] Expand File-Group candidates list for appending for MOR tables
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3986:
URL: https://github.com/apache/hudi/pull/3986#issuecomment-967775890
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3345",
"triggerID" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bec502451cdffe7c4ff8d86aec27482397c28991 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3345)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3986: [HUDI-2550] Expand File-Group candidates list for appending for MOR tables
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3986:
URL: https://github.com/apache/hudi/pull/3986#issuecomment-975989405
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3345",
"triggerID" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"triggerType" : "PUSH"
}, {
"hash" : "786d593265ce66cff0167261dc34fceeeeb9310f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3387",
"triggerID" : "786d593265ce66cff0167261dc34fceeeeb9310f",
"triggerType" : "PUSH"
}, {
"hash" : "d6873a12f5a3d16b4e3505243780ea56339b3d2e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3388",
"triggerID" : "d6873a12f5a3d16b4e3505243780ea56339b3d2e",
"triggerType" : "PUSH"
}, {
"hash" : "d6873a12f5a3d16b4e3505243780ea56339b3d2e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3405",
"triggerID" : "969861249",
"triggerType" : "MANUAL"
}, {
"hash" : "1e675d3964b69da921b8d5b68c329094cb4f56b5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1e675d3964b69da921b8d5b68c329094cb4f56b5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d6873a12f5a3d16b4e3505243780ea56339b3d2e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3388) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3405)
* 1e675d3964b69da921b8d5b68c329094cb4f56b5 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3986: [HUDI-2550] Expand File-Group candidates list for appending for MOR tables
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3986:
URL: https://github.com/apache/hudi/pull/3986#issuecomment-976014986
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3345",
"triggerID" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"triggerType" : "PUSH"
}, {
"hash" : "786d593265ce66cff0167261dc34fceeeeb9310f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3387",
"triggerID" : "786d593265ce66cff0167261dc34fceeeeb9310f",
"triggerType" : "PUSH"
}, {
"hash" : "d6873a12f5a3d16b4e3505243780ea56339b3d2e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3388",
"triggerID" : "d6873a12f5a3d16b4e3505243780ea56339b3d2e",
"triggerType" : "PUSH"
}, {
"hash" : "d6873a12f5a3d16b4e3505243780ea56339b3d2e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3405",
"triggerID" : "969861249",
"triggerType" : "MANUAL"
}, {
"hash" : "1e675d3964b69da921b8d5b68c329094cb4f56b5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3604",
"triggerID" : "1e675d3964b69da921b8d5b68c329094cb4f56b5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1e675d3964b69da921b8d5b68c329094cb4f56b5 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3604)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on a change in pull request #3986: [HUDI-2550] Expand File-Group candidates list for appending for MOR tables
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #3986:
URL: https://github.com/apache/hudi/pull/3986#discussion_r754789346
##########
File path: hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/action/commit/TestUpsertPartitioner.java
##########
@@ -434,6 +434,49 @@ public void testUpsertPartitionerWithSmallFileHandlingWithCanIndexLogFiles() thr
"Insert should be assigned to fg1");
}
+ @Test
+ public void testUpsertPartitionerWithSmallFileHandlingPickingMultipleCandidates() throws Exception {
+ final String partitionPath = DEFAULT_PARTITION_PATHS[0];
+
+ HoodieWriteConfig config =
Review comment:
@alexeykudinkin let's keep the code styling more consistent with whats there already?
```
HoodieWriteConfig config = makeHoodieClientConfigBuilder()
```
instead of
```
HoodieWriteConfig config =
makeHoodieClientConfigBuilder
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] alexeykudinkin commented on pull request #3986: [HUDI-2550][WIP] Expand File-Group candidates list for appending for MOR tables
Posted by GitBox <gi...@apache.org>.
alexeykudinkin commented on pull request #3986:
URL: https://github.com/apache/hudi/pull/3986#issuecomment-967769897
Test is still pending
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #3986: [HUDI-2550][WIP] Expand File-Group candidates list for appending for MOR tables
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3986:
URL: https://github.com/apache/hudi/pull/3986#issuecomment-969305412
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3345",
"triggerID" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"triggerType" : "PUSH"
}, {
"hash" : "786d593265ce66cff0167261dc34fceeeeb9310f",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3387",
"triggerID" : "786d593265ce66cff0167261dc34fceeeeb9310f",
"triggerType" : "PUSH"
}, {
"hash" : "d6873a12f5a3d16b4e3505243780ea56339b3d2e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3388",
"triggerID" : "d6873a12f5a3d16b4e3505243780ea56339b3d2e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 786d593265ce66cff0167261dc34fceeeeb9310f Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3387)
* d6873a12f5a3d16b4e3505243780ea56339b3d2e Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3388)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3986: [HUDI-2550][WIP] Expand File-Group candidates list for appending for MOR tables
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3986:
URL: https://github.com/apache/hudi/pull/3986#issuecomment-969305412
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3345",
"triggerID" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"triggerType" : "PUSH"
}, {
"hash" : "786d593265ce66cff0167261dc34fceeeeb9310f",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3387",
"triggerID" : "786d593265ce66cff0167261dc34fceeeeb9310f",
"triggerType" : "PUSH"
}, {
"hash" : "d6873a12f5a3d16b4e3505243780ea56339b3d2e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3388",
"triggerID" : "d6873a12f5a3d16b4e3505243780ea56339b3d2e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 786d593265ce66cff0167261dc34fceeeeb9310f Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3387)
* d6873a12f5a3d16b4e3505243780ea56339b3d2e Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3388)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #3986: [HUDI-2550][WIP] Expand File-Group candidates list for appending for MOR tables
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3986:
URL: https://github.com/apache/hudi/pull/3986#issuecomment-969266770
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3345",
"triggerID" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"triggerType" : "PUSH"
}, {
"hash" : "786d593265ce66cff0167261dc34fceeeeb9310f",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3387",
"triggerID" : "786d593265ce66cff0167261dc34fceeeeb9310f",
"triggerType" : "PUSH"
}, {
"hash" : "d6873a12f5a3d16b4e3505243780ea56339b3d2e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d6873a12f5a3d16b4e3505243780ea56339b3d2e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 786d593265ce66cff0167261dc34fceeeeb9310f Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3387)
* d6873a12f5a3d16b4e3505243780ea56339b3d2e UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3986: [HUDI-2550][WIP] Expand File-Group candidates list for appending for MOR tables
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3986:
URL: https://github.com/apache/hudi/pull/3986#issuecomment-967770621
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3345",
"triggerID" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bec502451cdffe7c4ff8d86aec27482397c28991 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3345)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #3986: [HUDI-2550][WIP] Expand File-Group candidates list for appending for MOR tables
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3986:
URL: https://github.com/apache/hudi/pull/3986#issuecomment-969256253
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3345",
"triggerID" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"triggerType" : "PUSH"
}, {
"hash" : "786d593265ce66cff0167261dc34fceeeeb9310f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "786d593265ce66cff0167261dc34fceeeeb9310f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bec502451cdffe7c4ff8d86aec27482397c28991 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3345)
* 786d593265ce66cff0167261dc34fceeeeb9310f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] alexeykudinkin commented on pull request #3986: [HUDI-2550][WIP] Expand File-Group candidates list for appending for MOR tables
Posted by GitBox <gi...@apache.org>.
alexeykudinkin commented on pull request #3986:
URL: https://github.com/apache/hudi/pull/3986#issuecomment-969861249
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #3986: [HUDI-2550] Expand File-Group candidates list for appending for MOR tables
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3986:
URL: https://github.com/apache/hudi/pull/3986#issuecomment-975989405
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3345",
"triggerID" : "bec502451cdffe7c4ff8d86aec27482397c28991",
"triggerType" : "PUSH"
}, {
"hash" : "786d593265ce66cff0167261dc34fceeeeb9310f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3387",
"triggerID" : "786d593265ce66cff0167261dc34fceeeeb9310f",
"triggerType" : "PUSH"
}, {
"hash" : "d6873a12f5a3d16b4e3505243780ea56339b3d2e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3388",
"triggerID" : "d6873a12f5a3d16b4e3505243780ea56339b3d2e",
"triggerType" : "PUSH"
}, {
"hash" : "d6873a12f5a3d16b4e3505243780ea56339b3d2e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3405",
"triggerID" : "969861249",
"triggerType" : "MANUAL"
}, {
"hash" : "1e675d3964b69da921b8d5b68c329094cb4f56b5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1e675d3964b69da921b8d5b68c329094cb4f56b5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d6873a12f5a3d16b4e3505243780ea56339b3d2e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3388) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3405)
* 1e675d3964b69da921b8d5b68c329094cb4f56b5 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan merged pull request #3986: [HUDI-2550] Expand File-Group candidates list for appending for MOR tables
Posted by GitBox <gi...@apache.org>.
nsivabalan merged pull request #3986:
URL: https://github.com/apache/hudi/pull/3986
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org