[superset] branch lyndsi/DndColumnSelect-act-cleanup created (now 3acea8e907)

[ly...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

lyndsi pushed a change to branch lyndsi/DndColumnSelect-act-cleanup
in repository https://gitbox.apache.org/repos/asf/superset.git


      at 3acea8e907 5 act errors removed from DndColumnSelect test

This branch includes the following new commits:

     new 3acea8e907 5 act errors removed from DndColumnSelect test

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.

[superset] 01/01: 5 act errors removed from DndColumnSelect test

[ly...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

lyndsi pushed a commit to branch lyndsi/DndColumnSelect-act-cleanup
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 3acea8e9070a11f7718cae7124a210fa5d769d0a
Author: lyndsiWilliams <kc...@gmail.com>
AuthorDate: Fri Sep 9 15:07:39 2022 -0500

    5 act errors removed from DndColumnSelect test
---
 .../controls/DndColumnSelectControl/DndColumnSelect.test.tsx | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelect.test.tsx b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelect.test.tsx
index bc837203db..13996091e1 100644
--- a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelect.test.tsx
+++ b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelect.test.tsx
@@ -33,23 +33,23 @@ const defaultProps: DndColumnSelectProps = {
   actions: { setControlValue: jest.fn() },
 };
 
-test('renders with default props', () => {
+test('renders with default props', async () => {
   render(<DndColumnSelect {...defaultProps} />, {
     useDnd: true,
     useRedux: true,
   });
-  expect(screen.getByText('Drop columns here')).toBeInTheDocument();
+  expect(await screen.findByText('Drop columns here')).toBeInTheDocument();
 });
 
-test('renders with value', () => {
+test('renders with value', async () => {
   render(<DndColumnSelect {...defaultProps} value="string" />, {
     useDnd: true,
     useRedux: true,
   });
-  expect(screen.getByText('Column A')).toBeInTheDocument();
+  expect(await screen.findByText('Column A')).toBeInTheDocument();
 });
 
-test('renders adhoc column', () => {
+test('renders adhoc column', async () => {
   render(
     <DndColumnSelect
       {...defaultProps}
@@ -61,6 +61,6 @@ test('renders adhoc column', () => {
     />,
     { useDnd: true, useRedux: true },
   );
-  expect(screen.getByText('adhoc column')).toBeVisible();
+  expect(await screen.findByText('adhoc column')).toBeVisible();
   expect(screen.getByLabelText('calculator')).toBeVisible();
 });