You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/12/15 19:16:10 UTC

[GitHub] [pinot] amrishlal commented on pull request #7897: make index readers/loaders pluggable

amrishlal commented on pull request #7897:
URL: https://github.com/apache/pinot/pull/7897#issuecomment-995111000


   Will `BloomFilterReaderFactory` (and other similar classes) be still used after this PR? If not, we should delete these file and migrate the test cases that are using this class.
   
   Also, index readers appear to be tightly coupled with index creators, i.e one cannot be used without the other, so I am wondering if there should be a single interface (`BloomFilterCreatorProvider` from previous PR for example) that provides method for constructing both the index and its corresponding reader?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org