You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2019/10/08 08:55:05 UTC
[GitHub] [servicecomb-service-center] codecov-io commented on issue #592:
[SCB-1512] Allow custom handler chain.
codecov-io commented on issue #592: [SCB-1512] Allow custom handler chain.
URL: https://github.com/apache/servicecomb-service-center/pull/592#issuecomment-539418920
# [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/592?src=pr&el=h1) Report
> Merging [#592](https://codecov.io/gh/apache/servicecomb-service-center/pull/592?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/5c3a16d187733eb13fef522825faf3b84d8eda5d?src=pr&el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/servicecomb-service-center/pull/592?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #592 +/- ##
==========================================
+ Coverage 57.76% 57.85% +0.08%
==========================================
Files 204 204
Lines 15709 15709
==========================================
+ Hits 9075 9089 +14
+ Misses 5986 5974 -12
+ Partials 648 646 -2
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/592?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [syncer/serf/config.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/592/diff?src=pr&el=tree#diff-c3luY2VyL3NlcmYvY29uZmlnLmdv) | `56.75% <0%> (-2.71%)` | :arrow_down: |
| [server/notify/websocket.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/592/diff?src=pr&el=tree#diff-c2VydmVyL25vdGlmeS93ZWJzb2NrZXQuZ28=) | `80.57% <0%> (-0.58%)` | :arrow_down: |
| [server/plugin/pkg/registry/etcd/etcd.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/592/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC9ldGNkLmdv) | `86.53% <0%> (+0.17%)` | :arrow_up: |
| [syncer/plugins/servicecenter/transform.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/592/diff?src=pr&el=tree#diff-c3luY2VyL3BsdWdpbnMvc2VydmljZWNlbnRlci90cmFuc2Zvcm0uZ28=) | `54.28% <0%> (+0.71%)` | :arrow_up: |
| [pkg/tlsutil/tlsutil.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/592/diff?src=pr&el=tree#diff-cGtnL3Rsc3V0aWwvdGxzdXRpbC5nbw==) | `74.52% <0%> (+0.94%)` | :arrow_up: |
| [server/notify/stream.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/592/diff?src=pr&el=tree#diff-c2VydmVyL25vdGlmeS9zdHJlYW0uZ28=) | `73.68% <0%> (+2.63%)` | :arrow_up: |
| [syncer/pkg/syssig/signal.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/592/diff?src=pr&el=tree#diff-c3luY2VyL3BrZy9zeXNzaWcvc2lnbmFsLmdv) | `67.74% <0%> (+3.22%)` | :arrow_up: |
| [server/notify/listwatcher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/592/diff?src=pr&el=tree#diff-c2VydmVyL25vdGlmeS9saXN0d2F0Y2hlci5nbw==) | `79.16% <0%> (+9.72%)` | :arrow_up: |
| [syncer/pkg/ticker/ticker.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/592/diff?src=pr&el=tree#diff-c3luY2VyL3BrZy90aWNrZXIvdGlja2VyLmdv) | `100% <0%> (+19.04%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/592?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/592?src=pr&el=footer). Last update [5c3a16d...c888aba](https://codecov.io/gh/apache/servicecomb-service-center/pull/592?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services