You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Nikhil P <np...@gmail.com> on 2019/12/09 12:51:50 UTC
Re: Review Request 71616: RANGER-2660 : Option to create missing
users/groups/roles while creating/updating/importing policies
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71616/
-----------------------------------------------------------
(Updated Dec. 9, 2019, 6:21 p.m.)
Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-2660
https://issues.apache.org/jira/browse/RANGER-2660
Repository: ranger
Description
-------
provide an option to create missing users/groups/roles which are not present in ranger admin while creating/updating/importing policies
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerRoleValidator.java beeb888e5
security-admin/src/main/java/org/apache/ranger/biz/PolicyRefUpdater.java 7b2356bfd
security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java abb1b1013
Diff: https://reviews.apache.org/r/71616/diff/2/
Testing
-------
1.Tested with create/update/import policies for user/group/roles.
Thanks,
Nikhil P
Re: Review Request 71616: RANGER-2660 : Option to create missing
users/groups/roles while creating/updating/importing policies
Posted by Nikhil P <np...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71616/
-----------------------------------------------------------
(Updated Dec. 16, 2019, 6:38 p.m.)
Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-2660
https://issues.apache.org/jira/browse/RANGER-2660
Repository: ranger
Description
-------
provide an option to create missing users/groups/roles which are not present in ranger admin while creating/updating/importing policies
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerRoleValidator.java beeb888e5
security-admin/src/main/java/org/apache/ranger/biz/PolicyRefUpdater.java 3846d008c
security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java e8b58d1fd
Diff: https://reviews.apache.org/r/71616/diff/3/
Changes: https://reviews.apache.org/r/71616/diff/2-3/
Testing
-------
1.Tested with create/update/import policies for user/group/roles.
Thanks,
Nikhil P
Re: Review Request 71616: RANGER-2660 : Option to create missing
users/groups/roles while creating/updating/importing policies
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71616/#review218998
-----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java
Line 62 (original), 62 (patched)
<https://reviews.apache.org/r/71616/#comment306999>
Can you please rebase this patch? This is not getting applied in master branch.
```
$ git apply --check -v < ~/Downloads/0001-RANGER-2660-Option-to-create-missing-users-groups-ro.patch
Checking patch agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerRoleValidator.java...
Checking patch security-admin/src/main/java/org/apache/ranger/biz/PolicyRefUpdater.java...
Checking patch security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java...
error: while searching for:
import org.apache.ranger.plugin.model.RangerBaseModelObject;
import org.apache.ranger.plugin.model.RangerService;
import org.apache.ranger.plugin.store.EmbeddedServiceDefsUtil;
import org.apache.ranger.view.VXPortalUser;
import org.apache.ranger.view.VXResource;
import org.apache.ranger.view.VXResponse;
error: patch failed: security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java:62
error: security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java: patch does not apply
```
- Velmurugan Periasamy
On Dec. 9, 2019, 12:51 p.m., Nikhil P wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71616/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2019, 12:51 p.m.)
>
>
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2660
> https://issues.apache.org/jira/browse/RANGER-2660
>
>
> Repository: ranger
>
>
> Description
> -------
>
> provide an option to create missing users/groups/roles which are not present in ranger admin while creating/updating/importing policies
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerRoleValidator.java beeb888e5
> security-admin/src/main/java/org/apache/ranger/biz/PolicyRefUpdater.java 7b2356bfd
> security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java abb1b1013
>
>
> Diff: https://reviews.apache.org/r/71616/diff/2/
>
>
> Testing
> -------
>
> 1.Tested with create/update/import policies for user/group/roles.
>
>
> Thanks,
>
> Nikhil P
>
>