You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/30 09:04:54 UTC
[GitHub] [spark] yaooqinn commented on a change in pull request #26190:
[SPARK-29532][SQL] Simplify interval string parsing
yaooqinn commented on a change in pull request #26190: [SPARK-29532][SQL] Simplify interval string parsing
URL: https://github.com/apache/spark/pull/26190#discussion_r340494686
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/IntervalUtils.scala
##########
@@ -17,21 +17,24 @@
package org.apache.spark.sql.catalyst.util
+import org.apache.spark.sql.catalyst.parser.{CatalystSqlParser, ParseException}
import org.apache.spark.sql.types.Decimal
import org.apache.spark.unsafe.types.CalendarInterval
object IntervalUtils {
- val MONTHS_PER_YEAR: Int = 12
- val MONTHS_PER_QUARTER: Byte = 3
- val YEARS_PER_MILLENNIUM: Int = 1000
- val YEARS_PER_CENTURY: Int = 100
- val YEARS_PER_DECADE: Int = 10
- val MICROS_PER_HOUR: Long = DateTimeUtils.MILLIS_PER_HOUR * DateTimeUtils.MICROS_PER_MILLIS
- val MICROS_PER_MINUTE: Long = DateTimeUtils.MILLIS_PER_MINUTE * DateTimeUtils.MICROS_PER_MILLIS
- val DAYS_PER_MONTH: Byte = 30
- val MICROS_PER_MONTH: Long = DAYS_PER_MONTH * DateTimeUtils.SECONDS_PER_DAY
+ final val MONTHS_PER_YEAR: Int = 12
+ final val MONTHS_PER_QUARTER: Byte = 3
+ final val YEARS_PER_MILLENNIUM: Int = 1000
+ final val YEARS_PER_CENTURY: Int = 100
+ final val YEARS_PER_DECADE: Int = 10
+ final val MICROS_PER_HOUR: Long =
+ DateTimeUtils.MILLIS_PER_HOUR * DateTimeUtils.MICROS_PER_MILLIS
+ final val MICROS_PER_MINUTE: Long =
+ DateTimeUtils.MILLIS_PER_MINUTE * DateTimeUtils.MICROS_PER_MILLIS
+ final val DAYS_PER_MONTH: Byte = 30
+ final val MICROS_PER_MONTH: Long = DAYS_PER_MONTH * DateTimeUtils.SECONDS_PER_DAY
Review comment:
`MICROS_PER_MONTH` is wrong here, which should be `DAYS_PER_MONTH * DateTimeUtils. MICROS_PER_DAY` I will fix this in https://github.com/apache/spark/pull/26314
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org