You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Mark Hindess <ma...@googlemail.com> on 2010/07/27 10:18:53 UTC
[build] Lots of test failures/regressions
I've just fixed a break (r979569) that was stopping the hudson builds
running all the tests. However even with the aborted tests run, there
were a lot of regressions. See:
http://hudson.zones.apache.org/hudson/view/Harmony/job/Harmony-1.5-head-linux-x86_64-full-tests/272/
Unfortunately, hudson hadn't done a build in a while so quite a few
changes went into that build which makes it harder to see what might
have caused the failures.
The latest test run:
http://hudson.zones.apache.org/hudson/view/Harmony/job/Harmony-1.5-head-linux-x86_64-full-tests/275/
should at least run all the tests.
Please can we focus on fixing these regressions?
Regards,
Mark.
[general] Next milestones (was: Re: [build] Lots of test failures/regressions)
Posted by Tim Ellison <t....@gmail.com>.
Maybe time to plan the next milestone release -- we have lots of fixes
in since the last set of releases and it would be good to get all these
improvements thoroughly tested and out there.
Set some dates for the end of August?
Regards,
Tim
On 27/Jul/2010 09:18, Mark Hindess wrote:
> I've just fixed a break (r979569) that was stopping the hudson builds
> running all the tests. However even with the aborted tests run, there
> were a lot of regressions. See:
>
> http://hudson.zones.apache.org/hudson/view/Harmony/job/Harmony-1.5-head-linux-x86_64-full-tests/272/
>
> Unfortunately, hudson hadn't done a build in a while so quite a few
> changes went into that build which makes it harder to see what might
> have caused the failures.
>
> The latest test run:
>
> http://hudson.zones.apache.org/hudson/view/Harmony/job/Harmony-1.5-head-linux-x86_64-full-tests/275/
>
> should at least run all the tests.
>
> Please can we focus on fixing these regressions?
>
> Regards,
> Mark.
>
>
>
Re: [build] Lots of test failures/regressions
Posted by Tim Ellison <t....@gmail.com>.
On 27/Jul/2010 10:42, Deven You wrote:
> Tim
> We need applied HARMONY-6594 and HARMONY-6590 all together, since HARMONY-6594
> fixes CharsetEncoder's behavoir which discloses the errors in
> OutputStream.close() which will be fixed with HARMONY-6590
Let me test them together and see what's happening.
Regards,
Tim
Re: [build] Lots of test failures/regressions
Posted by Deven You <de...@gmail.com>.
Tim
We need applied HARMONY-6594 and HARMONY-6590 all together, since HARMONY-6594
fixes CharsetEncoder's behavoir which discloses the errors in
OutputStream.close() which will be fixed with HARMONY-6590
2010/7/27 Tim Ellison <t....@gmail.com>
> On 27/Jul/2010 10:09, Mark Hindess wrote:
> > In message <20...@d12av02.megacenter.de.ibm.com>,
> > "Mark Hindess" writes:
> >> I've just fixed a break (r979569) that was stopping the hudson builds
> >> running all the tests. However even with the aborted tests run, there
> >> were a lot of regressions. See:
> >>
> >>
> http://hudson.zones.apache.org/hudson/view/Harmony/job/Harmony-1.5-head-lin
> >> ux-x86_64-full-tests/272/
> >>
> >> Unfortunately, hudson hadn't done a build in a while so quite a few
> >> changes went into that build which makes it harder to see what might
> >> have caused the failures.
> >>
> >> The latest test run:
> >>
> >>
> http://hudson.zones.apache.org/hudson/view/Harmony/job/Harmony-1.5-head-lin
> >> ux-x86_64-full-tests/275/
> >>
> >> should at least run all the tests.
> >>
> >> Please can we focus on fixing these regressions?
> >
> > Looks like:
> >
> > r967069 | tellison | 2010-07-23 13:24:45 +0100 (Fri, 23 Jul 2010) | 2
> lines
> > Changed paths:
> > M
> /harmony/enhanced/java/trunk/classlib/modules/nio_char/src/main/java/java/nio/charset/CharsetEncoder.java
> > M
> /harmony/enhanced/java/trunk/classlib/modules/nio_char/src/test/java/org/apache/harmony/nio_char/tests/java/nio/charset/ASCIICharsetEncoderTest.java
> > M
> /harmony/enhanced/java/trunk/classlib/modules/nio_char/src/test/java/tests/api/java/nio/charset/CharsetEncoderTest.java
> >
> > Apply patch for HARMONY-6594 ([classlib][nio_char]
> > CharsetEncoder.flush(Bytebuffer) doesn't follow the spec and RI's
> > behavior)
> >
> > is responsible for most of the test failures.
> >
> > Deven/Tim: can you take a look please?
>
> I reverted the patch.
>
> It passed the nio_char tests ;-) but I didn't run the full set of
> tests. I'll take another look and enhance the nio_char tests.
>
> Regards,
> Tim
>
Re: [build] Lots of test failures/regressions
Posted by Tim Ellison <t....@gmail.com>.
On 27/Jul/2010 10:09, Mark Hindess wrote:
> In message <20...@d12av02.megacenter.de.ibm.com>,
> "Mark Hindess" writes:
>> I've just fixed a break (r979569) that was stopping the hudson builds
>> running all the tests. However even with the aborted tests run, there
>> were a lot of regressions. See:
>>
>> http://hudson.zones.apache.org/hudson/view/Harmony/job/Harmony-1.5-head-lin
>> ux-x86_64-full-tests/272/
>>
>> Unfortunately, hudson hadn't done a build in a while so quite a few
>> changes went into that build which makes it harder to see what might
>> have caused the failures.
>>
>> The latest test run:
>>
>> http://hudson.zones.apache.org/hudson/view/Harmony/job/Harmony-1.5-head-lin
>> ux-x86_64-full-tests/275/
>>
>> should at least run all the tests.
>>
>> Please can we focus on fixing these regressions?
>
> Looks like:
>
> r967069 | tellison | 2010-07-23 13:24:45 +0100 (Fri, 23 Jul 2010) | 2 lines
> Changed paths:
> M /harmony/enhanced/java/trunk/classlib/modules/nio_char/src/main/java/java/nio/charset/CharsetEncoder.java
> M /harmony/enhanced/java/trunk/classlib/modules/nio_char/src/test/java/org/apache/harmony/nio_char/tests/java/nio/charset/ASCIICharsetEncoderTest.java
> M /harmony/enhanced/java/trunk/classlib/modules/nio_char/src/test/java/tests/api/java/nio/charset/CharsetEncoderTest.java
>
> Apply patch for HARMONY-6594 ([classlib][nio_char]
> CharsetEncoder.flush(Bytebuffer) doesn't follow the spec and RI's
> behavior)
>
> is responsible for most of the test failures.
>
> Deven/Tim: can you take a look please?
I reverted the patch.
It passed the nio_char tests ;-) but I didn't run the full set of
tests. I'll take another look and enhance the nio_char tests.
Regards,
Tim
Re: [build] Lots of test failures/regressions
Posted by Mikołaj Paulina Roszak <en...@stargard.mm.pl>.
Mikołaj Paulina Roszak
+48 604339153
PL07 1160 2202 0000 0001 0723 2044
S.W.I.F.T. BIGBPLPWXXX
mikolaj.roszak@bankmillennium.pl
Re: [build] Lots of test failures/regressions
Posted by Deven You <de...@gmail.com>.
Mark,
These errors will be fixed by HARMONY-6590 which is marked as a dependency
on the HARMONY-6594 jira. Our logic of OutputStream.close() is wrong
according to java spec (wrongly use CharsetEncoder.flush()), but previously
our CharsetEncoder also doesn't comply with RI so that 2 errors by chance
let OutputStream.close() pass luni unit test before . Please see my comments
on https://issues.apache.org/jira/browse/HARMONY-6590. Thanks a lot!
2010/7/27 Mark Hindess <ma...@googlemail.com>
>
> In message <20...@d12av02.megacenter.de.ibm.com>,
> "Mark Hindess" writes:
> >
> > I've just fixed a break (r979569) that was stopping the hudson builds
> > running all the tests. However even with the aborted tests run, there
> > were a lot of regressions. See:
> >
> >
> http://hudson.zones.apache.org/hudson/view/Harmony/job/Harmony-1.5-head-lin
> > ux-x86_64-full-tests/272/
> >
> > Unfortunately, hudson hadn't done a build in a while so quite a few
> > changes went into that build which makes it harder to see what might
> > have caused the failures.
> >
> > The latest test run:
> >
> >
> http://hudson.zones.apache.org/hudson/view/Harmony/job/Harmony-1.5-head-lin
> > ux-x86_64-full-tests/275/
> >
> > should at least run all the tests.
> >
> > Please can we focus on fixing these regressions?
>
> Looks like:
>
> r967069 | tellison | 2010-07-23 13:24:45 +0100 (Fri, 23 Jul 2010) | 2
> lines
> Changed paths:
> M
> /harmony/enhanced/java/trunk/classlib/modules/nio_char/src/main/java/java/nio/charset/CharsetEncoder.java
> M
> /harmony/enhanced/java/trunk/classlib/modules/nio_char/src/test/java/org/apache/harmony/nio_char/tests/java/nio/charset/ASCIICharsetEncoderTest.java
> M
> /harmony/enhanced/java/trunk/classlib/modules/nio_char/src/test/java/tests/api/java/nio/charset/CharsetEncoderTest.java
>
> Apply patch for HARMONY-6594 ([classlib][nio_char]
> CharsetEncoder.flush(Bytebuffer) doesn't follow the spec and RI's
> behavior)
>
> is responsible for most of the test failures.
>
> Deven/Tim: can you take a look please?
>
> Regards,
> Mark.
>
>
>
>
Re: [build] Lots of test failures/regressions
Posted by Mark Hindess <ma...@googlemail.com>.
In message <20...@d12av02.megacenter.de.ibm.com>,
"Mark Hindess" writes:
>
> I've just fixed a break (r979569) that was stopping the hudson builds
> running all the tests. However even with the aborted tests run, there
> were a lot of regressions. See:
>
> http://hudson.zones.apache.org/hudson/view/Harmony/job/Harmony-1.5-head-lin
> ux-x86_64-full-tests/272/
>
> Unfortunately, hudson hadn't done a build in a while so quite a few
> changes went into that build which makes it harder to see what might
> have caused the failures.
>
> The latest test run:
>
> http://hudson.zones.apache.org/hudson/view/Harmony/job/Harmony-1.5-head-lin
> ux-x86_64-full-tests/275/
>
> should at least run all the tests.
>
> Please can we focus on fixing these regressions?
Looks like:
r967069 | tellison | 2010-07-23 13:24:45 +0100 (Fri, 23 Jul 2010) | 2 lines
Changed paths:
M /harmony/enhanced/java/trunk/classlib/modules/nio_char/src/main/java/java/nio/charset/CharsetEncoder.java
M /harmony/enhanced/java/trunk/classlib/modules/nio_char/src/test/java/org/apache/harmony/nio_char/tests/java/nio/charset/ASCIICharsetEncoderTest.java
M /harmony/enhanced/java/trunk/classlib/modules/nio_char/src/test/java/tests/api/java/nio/charset/CharsetEncoderTest.java
Apply patch for HARMONY-6594 ([classlib][nio_char]
CharsetEncoder.flush(Bytebuffer) doesn't follow the spec and RI's
behavior)
is responsible for most of the test failures.
Deven/Tim: can you take a look please?
Regards,
Mark.