You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/11/01 21:49:49 UTC
[GitHub] [cloudstack] mlsorensen opened a new pull request, #6864: Allow ssvm agent certs to contain host IP for NAT situations
mlsorensen opened a new pull request, #6864:
URL: https://github.com/apache/cloudstack/pull/6864
### Description
There are some networking setups where system VM communications are proxied off of the hypervisor host on which the system VM is running. For example, if the KVM management network is a NAT bridge, or the network plugin employs user mode network for system VM management interfaces, then system VM agent comms look as though they come form the hypervisor host. Admittedly, these configurations are bespoke, which is why a configuration is provided and it's disabled by default.
In such a setup, the certificate authentication for agents fails because the source IP is that of the host of the system VM, rather than the system VM itself, and this IP is not in the connecting certificate presented. This PR adds a configuration value that allows the system VM cert to contain the host IP that the system VM is scheduled on. This allows such setups to maintain auth strictness on agent auth.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [x] Trivial
### How Has This Been Tested?
Tested this via unit tests, and in our private integration environment. When ca.framework.cert.systemvm.allow.host.ip is set, agent auth succeeds from system VMs, when unset, it fails as it did prior to this change.
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6864: Allow ssvm agent certs to contain host IP for NAT situations
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6864:
URL: https://github.com/apache/cloudstack/pull/6864#issuecomment-1304211926
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #6864: Allow ssvm agent certs to contain host IP for NAT situations
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged PR #6864:
URL: https://github.com/apache/cloudstack/pull/6864
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6864: Allow ssvm agent certs to contain host IP for NAT situations
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6864:
URL: https://github.com/apache/cloudstack/pull/6864#issuecomment-1343856647
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6864: Allow ssvm agent certs to contain host IP for NAT situations
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6864:
URL: https://github.com/apache/cloudstack/pull/6864#issuecomment-1343894155
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4821
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6864: Allow ssvm agent certs to contain host IP for NAT situations
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6864:
URL: https://github.com/apache/cloudstack/pull/6864#issuecomment-1300491175
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with
SystemVM template(s). I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6864: Allow ssvm agent certs to contain host IP for NAT situations
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6864:
URL: https://github.com/apache/cloudstack/pull/6864#issuecomment-1299337303
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6864)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6864&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6864&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6864&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6864&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6864&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6864&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6864&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6864&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6864&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6864&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6864&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6864&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6864&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6864&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6864&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6864&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6864: Allow ssvm agent certs to contain host IP for NAT situations
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6864:
URL: https://github.com/apache/cloudstack/pull/6864#issuecomment-1346012392
@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6864: Allow ssvm agent certs to contain host IP for NAT situations
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6864:
URL: https://github.com/apache/cloudstack/pull/6864#issuecomment-1299648998
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6864: Allow ssvm agent certs to contain host IP for NAT situations
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6864:
URL: https://github.com/apache/cloudstack/pull/6864#issuecomment-1303058262
Tests LGTM - the failure is a known intermittent issue not caused by this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] mlsorensen commented on pull request #6864: Allow ssvm agent certs to contain host IP for NAT situations
Posted by GitBox <gi...@apache.org>.
mlsorensen commented on PR #6864:
URL: https://github.com/apache/cloudstack/pull/6864#issuecomment-1341649599
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6864: Allow ssvm agent certs to contain host IP for NAT situations
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6864:
URL: https://github.com/apache/cloudstack/pull/6864#issuecomment-1303551777
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. LL-JID 197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6864: Allow ssvm agent certs to contain host IP for NAT situations
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6864:
URL: https://github.com/apache/cloudstack/pull/6864#issuecomment-1303487312
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6864: Allow ssvm agent certs to contain host IP for NAT situations
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6864:
URL: https://github.com/apache/cloudstack/pull/6864#issuecomment-1347190198
<b>Trillian test result (tid-5465)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42755 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6864-t5465-kvm-centos7.zip
Smoke tests completed. 105 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6864: Allow ssvm agent certs to contain host IP for NAT situations
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6864:
URL: https://github.com/apache/cloudstack/pull/6864#issuecomment-1300488917
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6864: Allow ssvm agent certs to contain host IP for NAT situations
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6864:
URL: https://github.com/apache/cloudstack/pull/6864#issuecomment-1304210230
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6864: Allow ssvm agent certs to contain host IP for NAT situations
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6864:
URL: https://github.com/apache/cloudstack/pull/6864#issuecomment-1343856797
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with
SystemVM template(s). I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6864: Allow ssvm agent certs to contain host IP for NAT situations
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6864:
URL: https://github.com/apache/cloudstack/pull/6864#issuecomment-1302616097
<b>Trillian test result (tid-5243)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41382 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6864-t5243-kvm-centos7.zip
Smoke tests completed. 103 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 462.04 | test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6864: Allow ssvm agent certs to contain host IP for NAT situations
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6864:
URL: https://github.com/apache/cloudstack/pull/6864#issuecomment-1303485946
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6864: Allow ssvm agent certs to contain host IP for NAT situations
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6864:
URL: https://github.com/apache/cloudstack/pull/6864#issuecomment-1304432756
<b>Trillian test result (tid-39)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38016 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6864-t39-kvm-centos7.zip
Smoke tests completed. 103 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_redundant_vpc_site2site_vpn | `Failure` | 746.38 | test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options | `Error` | 1273.54 | test_vpc_vpn.py
test_01_vpc_site2site_vpn | `Error` | 546.21 | test_vpc_vpn.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6864: Allow ssvm agent certs to contain host IP for NAT situations
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6864:
URL: https://github.com/apache/cloudstack/pull/6864#issuecomment-1346011548
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6864: Allow ssvm agent certs to contain host IP for NAT situations
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6864:
URL: https://github.com/apache/cloudstack/pull/6864#issuecomment-1300556990
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. LL-JID 183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6864: Allow ssvm agent certs to contain host IP for NAT situations
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6864:
URL: https://github.com/apache/cloudstack/pull/6864#issuecomment-1341650176
@mlsorensen a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6864: Allow ssvm agent certs to contain host IP for NAT situations
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6864:
URL: https://github.com/apache/cloudstack/pull/6864#issuecomment-1301734913
(rekick pkging in Sofia lab manually)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #6864: Allow ssvm agent certs to contain host IP for NAT situations
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #6864:
URL: https://github.com/apache/cloudstack/pull/6864#issuecomment-1299367516
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6864?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6864](https://codecov.io/gh/apache/cloudstack/pull/6864?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1e150a4) into [main](https://codecov.io/gh/apache/cloudstack/commit/fa39e61a4ccd33ccb9b81481eb57c64b3adaf6f7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fa39e61) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## main #6864 +/- ##
============================================
- Coverage 10.84% 10.84% -0.01%
Complexity 7104 7104
============================================
Files 2485 2485
Lines 245417 245421 +4
Branches 38326 38326
============================================
Hits 26627 26627
- Misses 215521 215525 +4
Partials 3269 3269
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6864?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...n/java/com/cloud/vm/VirtualMachineManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6864/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL29yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9jb20vY2xvdWQvdm0vVmlydHVhbE1hY2hpbmVNYW5hZ2VySW1wbC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...n/java/org/apache/cloudstack/ca/CAManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6864/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL2NhL0NBTWFuYWdlckltcGwuamF2YQ==) | `45.00% <0.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6864: Allow ssvm agent certs to contain host IP for NAT situations
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6864:
URL: https://github.com/apache/cloudstack/pull/6864#issuecomment-1299648017
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org