You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "Astro-Han (via GitHub)" <gi...@apache.org> on 2026/10/10 12:30:30 UTC

Re: [PR] fix(desktop): update Windows taskbar app icon [maka]

Astro-Han commented on code in PR #5202:
URL: https://github.com/apache/maka/pull/5202#discussion_r4237614569


##########
apps/desktop/src/main/windows-taskbar-icon.ts:
##########
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import { createHash } from 'node:crypto';
+import { existsSync, mkdirSync, renameSync, rmSync, writeFileSync } from 'node:fs';
+import { join } from 'node:path';
+import type { AppDetailsOptions, BaseWindow, NativeImage } from 'electron';
+
+/** Must stay aligned with electron-builder's appId and installed shortcut. */
+export const WINDOWS_APP_USER_MODEL_ID = 'com.maka.desktop';

Review Comment:
   [P3] This currently matches electron-builder's appId, but the test only compares windowsTaskbarAppDetails().appId with this same constant. It would stay green if the builder identity changed independently. Add an assertion against the builder configuration so the installed shortcut and per-window AppUserModel identity cannot silently drift.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org