[GitHub] [flink] TsReaper commented on pull request #12073: [FLINK-17735][table] Add specialized collecting iterator to Blink planner

[GitBox <gi...@apache.org>]

TsReaper commented on pull request #12073:
URL: https://github.com/apache/flink/pull/12073#issuecomment-629730294


   > Is the description here correct? The classes do not seem to relate to the Blink planner, but are all in the `flink-streaming-java` module.
   > 
   > I also don't understand how this is related specifically to SQL - isn't this a client side functionality, meaning it would be run as part of the JobClient (and used by the SQL Shell)?
   
   We initially would like to implement an iterator which will spill large data onto disks on client side. Currently only `ResettableExternalBuffer` in Blink planner can achieve this conveniently. But after an offline discussion with @KurtYoung yesterday, we decided to first simplify the implementation to a memory-only version. So this iterator is not related to Blink planner now. I'll update the description.
   
   The iterator is not running in `JobClient` but actually uses `JobClient`. It is indeed runs in the client side and used by the users.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org