You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/15 16:59:42 UTC

[GitHub] [flink-kubernetes-operator] morhidi opened a new pull request #67: [FLINK-26545] Ingress rules in managed namespace

morhidi opened a new pull request #67:
URL: https://github.com/apache/flink-kubernetes-operator/pull/67


   - moved the ingress(es) into the managed namespaces
   - the rules are created as <clusterid>.<namespace>.<domain> now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #67: [FLINK-26545] Ingress rules in managed namespace

Posted by GitBox <gi...@apache.org>.
gyfora merged pull request #67:
URL: https://github.com/apache/flink-kubernetes-operator/pull/67


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #67: [FLINK-26545] Ingress rules in managed namespace

Posted by GitBox <gi...@apache.org>.
morhidi commented on pull request #67:
URL: https://github.com/apache/flink-kubernetes-operator/pull/67#issuecomment-1068227422


   cc @wangyang0918 @gyfora 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] wangyang0918 commented on a change in pull request #67: [FLINK-26545] Ingress rules in managed namespace

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #67:
URL: https://github.com/apache/flink-kubernetes-operator/pull/67#discussion_r827817804



##########
File path: helm/flink-operator/templates/ingress.yaml
##########
@@ -17,6 +17,23 @@
 ################################################################################
 ---
 {{- if .Values.ingress.create }}
+{{- if .Values.watchNamespaces }}

Review comment:
       How could we create the ingress when `watchNamespaces` is not configured? By default, the operator is watching all the namespaces, I am afraid it still could not update the ingress rules when running in a different namespace with operator.
   
   All in all, I am suggesting to create the ingress in the java code, not the helm chart.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] morhidi commented on a change in pull request #67: [FLINK-26545] Ingress rules in managed namespace

Posted by GitBox <gi...@apache.org>.
morhidi commented on a change in pull request #67:
URL: https://github.com/apache/flink-kubernetes-operator/pull/67#discussion_r827898165



##########
File path: helm/flink-operator/templates/ingress.yaml
##########
@@ -17,6 +17,23 @@
 ################################################################################
 ---
 {{- if .Values.ingress.create }}
+{{- if .Values.watchNamespaces }}

Review comment:
       You're right the all namespace scenario is not covered properly. We discussed this yesterday with @gyfora and @mbalassi and haven't had the chance to update the PR yet.
   
   My main motivation behind using the Helm chart for creating the Ingresses was to use a more predictable/static manner. To my best knowledge Ingresses require at least an LB address, and a wildcard DNS entry with the current implementation to work properly, sometimes firewall/NW changes. 
   
   So my suggestion for the ingress logic is the following:
   
   - pre-create Ingresses for all watchNamespaces when the Operator is started (Let's use Java then)
   - create Ingresses on the fly whenever a CR is created in a new namespace
   - Set the operator deployment as the owner of all Ingresses and never delete them to avoid dynamic LB generation.
   
   Let me know what you think @wangyang0918 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] wangyang0918 commented on a change in pull request #67: [FLINK-26545] Ingress rules in managed namespace

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #67:
URL: https://github.com/apache/flink-kubernetes-operator/pull/67#discussion_r828916522



##########
File path: helm/flink-operator/templates/ingress.yaml
##########
@@ -17,6 +17,23 @@
 ################################################################################
 ---
 {{- if .Values.ingress.create }}
+{{- if .Values.watchNamespaces }}

Review comment:
       I will get to the PR soon and verify it on the ACK(alibaba container kubernetes). 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] wangyang0918 commented on a change in pull request #67: [FLINK-26545] Ingress rules in managed namespace

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #67:
URL: https://github.com/apache/flink-kubernetes-operator/pull/67#discussion_r829014340



##########
File path: flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/IngressUtils.java
##########
@@ -29,7 +33,8 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import java.util.Optional;
+import java.util.Collections;
+import java.util.List;
 
 /** Ingress utilities. */
 public class IngressUtils {

Review comment:
       The variable `INGRESS_NAME` is useless now.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] wangyang0918 commented on a change in pull request #67: [FLINK-26545] Ingress rules in managed namespace

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #67:
URL: https://github.com/apache/flink-kubernetes-operator/pull/67#discussion_r829014340



##########
File path: flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/IngressUtils.java
##########
@@ -29,7 +33,8 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import java.util.Optional;
+import java.util.Collections;
+import java.util.List;
 
 /** Ingress utilities. */
 public class IngressUtils {

Review comment:
       The variable `INGRESS_NAME` is useless now.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] morhidi commented on a change in pull request #67: [FLINK-26545] Ingress rules in managed namespace (don't merge)

Posted by GitBox <gi...@apache.org>.
morhidi commented on a change in pull request #67:
URL: https://github.com/apache/flink-kubernetes-operator/pull/67#discussion_r828730760



##########
File path: helm/flink-operator/templates/ingress.yaml
##########
@@ -17,6 +17,23 @@
 ################################################################################
 ---
 {{- if .Values.ingress.create }}
+{{- if .Values.watchNamespaces }}

Review comment:
       This should be doable with an ingress controller too, then. I'll dig into this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #67: [FLINK-26545] Ingress rules in managed namespace

Posted by GitBox <gi...@apache.org>.
morhidi commented on pull request #67:
URL: https://github.com/apache/flink-kubernetes-operator/pull/67#issuecomment-1070858680






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] morhidi commented on a change in pull request #67: [FLINK-26545] Ingress rules in managed namespace (don't merge)

Posted by GitBox <gi...@apache.org>.
morhidi commented on a change in pull request #67:
URL: https://github.com/apache/flink-kubernetes-operator/pull/67#discussion_r828879697



##########
File path: helm/flink-operator/templates/ingress.yaml
##########
@@ -17,6 +17,23 @@
 ################################################################################
 ---
 {{- if .Values.ingress.create }}
+{{- if .Values.watchNamespaces }}

Review comment:
       @wangyang0918 I've modified the basic logic accordingly. On Minikube it looks good, not sure if I'll have the chance to test it on AWS for example:
   
   ```
   k get ingress
   NAME             CLASS   HOSTS                                 ADDRESS        PORTS   AGE
   basic-ingress    nginx   basic-ingress.default.flink.k8s.io    192.168.49.2   80      30m
   basic-ingress2   nginx   basic-ingress2.default.flink.k8s.io   192.168.49.2   80      3m39s
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #67: [FLINK-26545] Ingress rules in managed namespace

Posted by GitBox <gi...@apache.org>.
morhidi commented on pull request #67:
URL: https://github.com/apache/flink-kubernetes-operator/pull/67#issuecomment-1070858680


   > LGTM.
   > 
   > I have verified on the ACK(alibaba container kubernetes). It also works as expected. All the ingresses could share a same LoadBalancer.
   
   This is good news! Thank you for your assistance @wangyang0918 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] Aitozi commented on a change in pull request #67: [FLINK-26545] Ingress rules in managed namespace

Posted by GitBox <gi...@apache.org>.
Aitozi commented on a change in pull request #67:
URL: https://github.com/apache/flink-kubernetes-operator/pull/67#discussion_r827633675



##########
File path: flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/BaseReconciler.java
##########
@@ -60,7 +59,11 @@ private DeleteControl shutdownAndDelete(
             FlinkUtils.deleteCluster(flinkApp, kubernetesClient, true);
         }
         IngressUtils.updateIngressRules(
-                flinkApp, effectiveConfig, operatorNamespace, kubernetesClient, true);
+                flinkApp,
+                effectiveConfig,
+                flinkApp.getMetadata().getNamespace(),

Review comment:
       this do not have pass the `flinkApp.getMetadata().getNamespace()`, it can get from the `flinkApp`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] wangyang0918 commented on a change in pull request #67: [FLINK-26545] Ingress rules in managed namespace (don't merge)

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #67:
URL: https://github.com/apache/flink-kubernetes-operator/pull/67#discussion_r828672167



##########
File path: helm/flink-operator/templates/ingress.yaml
##########
@@ -17,6 +17,23 @@
 ################################################################################
 ---
 {{- if .Values.ingress.create }}
+{{- if .Values.watchNamespaces }}

Review comment:
       Thanks for sharing the progress. For the owner reference, I am afraid we could not set the owner of all the ingress in different namespaces to the operator deployment. Refer to here[1] for more information.
   
   I am just thinking in a different way. Could we only create one ingress for the operator and let the operator do the HTTP requests redirecting? Benefit from this, we could easily integrate a unified authentication if necessary. I believe hadoop YARN[2] is running in a similar way to proxy the application master UI. 
   
   And maybe we could also consider to provide a webUI for the operator itself in the future, which could greatly lower the bar to use our k8s operator.
   
   
   [1]. https://pkg.go.dev/k8s.io/apimachinery/pkg/apis/meta/v1#OwnerReference
   [2]. https://hadoop.apache.org/docs/stable/hadoop-yarn/hadoop-yarn-site/WebApplicationProxy.html#:~:text=The%20Web%20Application%20Proxy%20is,web%20based%20attacks%20through%20YARN.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] Aitozi commented on pull request #67: [FLINK-26545] Ingress rules in managed namespace

Posted by GitBox <gi...@apache.org>.
Aitozi commented on pull request #67:
URL: https://github.com/apache/flink-kubernetes-operator/pull/67#issuecomment-1068741749


   LGTM otherwise a minor comment


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] morhidi commented on a change in pull request #67: [FLINK-26545] Ingress rules in managed namespace

Posted by GitBox <gi...@apache.org>.
morhidi commented on a change in pull request #67:
URL: https://github.com/apache/flink-kubernetes-operator/pull/67#discussion_r829059795



##########
File path: flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/IngressUtils.java
##########
@@ -29,7 +33,8 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import java.util.Optional;
+import java.util.Collections;
+import java.util.List;
 
 /** Ingress utilities. */
 public class IngressUtils {

Review comment:
       Removed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #67: [FLINK-26545] Ingress rules in managed namespace

Posted by GitBox <gi...@apache.org>.
gyfora merged pull request #67:
URL: https://github.com/apache/flink-kubernetes-operator/pull/67


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] morhidi commented on a change in pull request #67: [FLINK-26545] Ingress rules in managed namespace

Posted by GitBox <gi...@apache.org>.
morhidi commented on a change in pull request #67:
URL: https://github.com/apache/flink-kubernetes-operator/pull/67#discussion_r829059795



##########
File path: flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/IngressUtils.java
##########
@@ -29,7 +33,8 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import java.util.Optional;
+import java.util.Collections;
+import java.util.List;
 
 /** Ingress utilities. */
 public class IngressUtils {

Review comment:
       Removed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] morhidi commented on a change in pull request #67: [FLINK-26545] Ingress rules in managed namespace (don't merge)

Posted by GitBox <gi...@apache.org>.
morhidi commented on a change in pull request #67:
URL: https://github.com/apache/flink-kubernetes-operator/pull/67#discussion_r828788151



##########
File path: helm/flink-operator/templates/ingress.yaml
##########
@@ -17,6 +17,23 @@
 ################################################################################
 ---
 {{- if .Values.ingress.create }}
+{{- if .Values.watchNamespaces }}

Review comment:
       @wangyang0918 So it seems my assumption about the one LB address per Ingress is not correct:
   
   > With the NGINX Ingress controller you can also have multiple ingress objects for multiple environments or namespaces with the same network load balancer; with the ALB, each ingress object requires a new load balancer.
   
   ![](https://d2908q01vomqb2.cloudfront.net/ca3512f4dfa95a03169c5a670a4c91a19b3077b4/2022/01/27/image7-3.png)
   
   https://aws.amazon.com/blogs/opensource/network-load-balancer-nginx-ingress-controller-eks/
   
   It seems we can create one ingress per deployment, and it get's merged by nginx. I'll test this and see if it works. Having a single ingress per deplyment would solve the ownership issue as well.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] wangyang0918 commented on a change in pull request #67: [FLINK-26545] Ingress rules in managed namespace (don't merge)

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #67:
URL: https://github.com/apache/flink-kubernetes-operator/pull/67#discussion_r828672167



##########
File path: helm/flink-operator/templates/ingress.yaml
##########
@@ -17,6 +17,23 @@
 ################################################################################
 ---
 {{- if .Values.ingress.create }}
+{{- if .Values.watchNamespaces }}

Review comment:
       Thanks for sharing the progress. For the owner reference, I am afraid we could not set the owner of all the ingress in different namespaces to the operator deployment. Refer to here[1] for more information.
   
   I am just thinking in a different way. Could we only create one ingress for the operator and let the operator do the HTTP requests redirecting? Benefit from this, we could easily integrate a unified authentication if necessary. I believe hadoop YARN[2] is running in a similar way to proxy the application master UI. 
   
   And maybe we could also consider to provide a webUI for the operator itself in the future, which could greatly lower the bar to use our k8s operator.
   
   
   [1]. https://pkg.go.dev/k8s.io/apimachinery/pkg/apis/meta/v1#OwnerReference
   [2]. https://hadoop.apache.org/docs/stable/hadoop-yarn/hadoop-yarn-site/WebApplicationProxy.html




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] morhidi commented on a change in pull request #67: [FLINK-26545] Ingress rules in managed namespace (don't merge)

Posted by GitBox <gi...@apache.org>.
morhidi commented on a change in pull request #67:
URL: https://github.com/apache/flink-kubernetes-operator/pull/67#discussion_r828788151



##########
File path: helm/flink-operator/templates/ingress.yaml
##########
@@ -17,6 +17,23 @@
 ################################################################################
 ---
 {{- if .Values.ingress.create }}
+{{- if .Values.watchNamespaces }}

Review comment:
       @wangyang0918 So it seems my assumption about the one LB address per Ingress is not always true:
   
   > With the NGINX Ingress controller you can also have multiple ingress objects for multiple environments or namespaces with the same network load balancer; with the ALB, each ingress object requires a new load balancer.
   
   ![](https://d2908q01vomqb2.cloudfront.net/ca3512f4dfa95a03169c5a670a4c91a19b3077b4/2022/01/27/image7-3.png)
   
   https://aws.amazon.com/blogs/opensource/network-load-balancer-nginx-ingress-controller-eks/
   
   It seems we can create one ingress per deployment, and it get's merged by nginx. I'll test this and see if it works. Having a single ingress per deployment would solve the ownership issue as well.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] wangyang0918 commented on a change in pull request #67: [FLINK-26545] Ingress rules in managed namespace (don't merge)

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #67:
URL: https://github.com/apache/flink-kubernetes-operator/pull/67#discussion_r828810875



##########
File path: helm/flink-operator/templates/ingress.yaml
##########
@@ -17,6 +17,23 @@
 ################################################################################
 ---
 {{- if .Values.ingress.create }}
+{{- if .Values.watchNamespaces }}

Review comment:
       It makes sense to me if the implementation does not rely on a specific cloud provision.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] morhidi commented on a change in pull request #67: [FLINK-26545] Ingress rules in managed namespace

Posted by GitBox <gi...@apache.org>.
morhidi commented on a change in pull request #67:
URL: https://github.com/apache/flink-kubernetes-operator/pull/67#discussion_r827727745



##########
File path: flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/BaseReconciler.java
##########
@@ -60,7 +59,11 @@ private DeleteControl shutdownAndDelete(
             FlinkUtils.deleteCluster(flinkApp, kubernetesClient, true);
         }
         IngressUtils.updateIngressRules(
-                flinkApp, effectiveConfig, operatorNamespace, kubernetesClient, true);
+                flinkApp,
+                effectiveConfig,
+                flinkApp.getMetadata().getNamespace(),

Review comment:
       yup, I missed that. Thanks!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #67: [FLINK-26545] Ingress rules in managed namespace

Posted by GitBox <gi...@apache.org>.
morhidi commented on pull request #67:
URL: https://github.com/apache/flink-kubernetes-operator/pull/67#issuecomment-1070867937


   For the record I filed a new Jira https://issues.apache.org/jira/browse/FLINK-26706 with some improvements on ingress front


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org