You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/05/07 11:41:53 UTC

[GitHub] [commons-collections] dota17 opened a new pull request #159: [WIP]Updated the fail() exceptions with Junit5.

dota17 opened a new pull request #159:
URL: https://github.com/apache/commons-collections/pull/159


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] garydgregory commented on pull request #159: Updated the fail() exceptions with Junit5.

Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #159:
URL: https://github.com/apache/commons-collections/pull/159#issuecomment-1060050601


   I think JUnit 5 work might be done in master?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] garydgregory commented on pull request #159: Updated the fail() exceptions with Junit5.

Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #159:
URL: https://github.com/apache/commons-collections/pull/159#issuecomment-632113164


   > > @dota17 The title says "WIP". Are you still working on it?
   > 
   > Yes, I am.
   > If anyone has time to review, it would be really nice. ;-)
   > 
   > Thanks
   
   Hi @dota17 
   This PR currently touches **124** files, which is a lot to review. Personally, for me to review this, I'd want to know the PR is as best as you can make it, because, as you can imagine, I really do not want to do it twice! ;-) So either it's WIP or it is as good as it is going to get from your POV at least. Please let us know...
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] coveralls edited a comment on pull request #159: Updated the fail() exceptions with Junit5.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #159:
URL: https://github.com/apache/commons-collections/pull/159#issuecomment-625612511


   
   [![Coverage Status](https://coveralls.io/builds/30911332/badge)](https://coveralls.io/builds/30911332)
   
   Coverage increased (+0.03%) to 90.126% when pulling **fba99611d944783caf016eff16a6814d9f87aacc on dota17:junit5WithExceptions** into **9f37668d9243fc71178f0e94a2b560ef861a639a on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] coveralls edited a comment on pull request #159: [WIP]Updated the fail() exceptions with Junit5.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #159:
URL: https://github.com/apache/commons-collections/pull/159#issuecomment-625612511


   
   [![Coverage Status](https://coveralls.io/builds/30667748/badge)](https://coveralls.io/builds/30667748)
   
   Coverage decreased (-0.03%) to 90.094% when pulling **02dc3435613d1a17449f89c90304792e63abb1ba on dota17:junit5WithExceptions** into **a3eb3be4b0063351115a02f56c884b31a6cc8bff on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] coveralls edited a comment on pull request #159: Updated the fail() exceptions with Junit5.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #159:
URL: https://github.com/apache/commons-collections/pull/159#issuecomment-625612511


   
   [![Coverage Status](https://coveralls.io/builds/31130760/badge)](https://coveralls.io/builds/31130760)
   
   Coverage decreased (-0.004%) to 90.119% when pulling **d74240b0e88fc87c8918d2973eb4fa98d62ead2c on dota17:junit5WithExceptions** into **de4b95a7c8f3b78174b7eccd1d6249c812695eea on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] coveralls edited a comment on pull request #159: Updated the fail() exceptions with Junit5.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #159:
URL: https://github.com/apache/commons-collections/pull/159#issuecomment-625612511


   
   [![Coverage Status](https://coveralls.io/builds/30984373/badge)](https://coveralls.io/builds/30984373)
   
   Coverage decreased (-0.004%) to 90.089% when pulling **aa05290ebf7afc195e03d32abf21d1ee20b2f3dd on dota17:junit5WithExceptions** into **9f37668d9243fc71178f0e94a2b560ef861a639a on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] coveralls edited a comment on pull request #159: [WIP] Updated the fail() exceptions with Junit5.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #159:
URL: https://github.com/apache/commons-collections/pull/159#issuecomment-625612511


   
   [![Coverage Status](https://coveralls.io/builds/30875775/badge)](https://coveralls.io/builds/30875775)
   
   Coverage increased (+0.003%) to 90.126% when pulling **6d30bbec9e779c2297a0203db0bc0a6e77dfc995 on dota17:junit5WithExceptions** into **a3eb3be4b0063351115a02f56c884b31a6cc8bff on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] coveralls edited a comment on pull request #159: Updated the fail() exceptions with Junit5.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #159:
URL: https://github.com/apache/commons-collections/pull/159#issuecomment-625612511


   
   [![Coverage Status](https://coveralls.io/builds/30983976/badge)](https://coveralls.io/builds/30983976)
   
   Coverage decreased (-0.004%) to 90.089% when pulling **b043d821d6c1b23784d9e7935146d5c40eab69f4 on dota17:junit5WithExceptions** into **9f37668d9243fc71178f0e94a2b560ef861a639a on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] coveralls edited a comment on pull request #159: [WIP] Updated the fail() exceptions with Junit5.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #159:
URL: https://github.com/apache/commons-collections/pull/159#issuecomment-625612511


   
   [![Coverage Status](https://coveralls.io/builds/30780705/badge)](https://coveralls.io/builds/30780705)
   
   Coverage remained the same at 90.123% when pulling **a58806df35c69522fba17d64216b5209167b4b01 on dota17:junit5WithExceptions** into **a3eb3be4b0063351115a02f56c884b31a6cc8bff on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] coveralls edited a comment on pull request #159: Updated the fail() exceptions with Junit5.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #159:
URL: https://github.com/apache/commons-collections/pull/159#issuecomment-625612511


   
   [![Coverage Status](https://coveralls.io/builds/31330667/badge)](https://coveralls.io/builds/31330667)
   
   Coverage increased (+0.03%) to 90.148% when pulling **be9246b436e9db31a1d6eab0cdaf101d7a55284a on dota17:junit5WithExceptions** into **de4b95a7c8f3b78174b7eccd1d6249c812695eea on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] dota17 commented on pull request #159: Updated the fail() exceptions with Junit5.

Posted by GitBox <gi...@apache.org>.
dota17 commented on pull request #159:
URL: https://github.com/apache/commons-collections/pull/159#issuecomment-633001505


   Hi @garydgregory 
   Under the folder
   commons-collections/src/test/java/org/apache/commons/collections4 (junit5WithExceptions),
   I executed the command to get the fails without annotate and import.
     `grep -R fail * |  grep -v import |grep -v "\/\/" | grep -v "*"`
   The last 58 lines only use the fail without exception to get the failure details.
   I had used JUnit 5's assertThrows() in the tests instead of fail() or Assert.fail() in the 
   132 files.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] coveralls edited a comment on pull request #159: [WIP] Updated the fail() exceptions with Junit5.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #159:
URL: https://github.com/apache/commons-collections/pull/159#issuecomment-625612511


   
   [![Coverage Status](https://coveralls.io/builds/30830134/badge)](https://coveralls.io/builds/30830134)
   
   Coverage remained the same at 90.123% when pulling **c2feee10ee74dc81e74892ba65ae5d215886db1b on dota17:junit5WithExceptions** into **a3eb3be4b0063351115a02f56c884b31a6cc8bff on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] coveralls edited a comment on pull request #159: [WIP]Updated the fail() exceptions with Junit5.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #159:
URL: https://github.com/apache/commons-collections/pull/159#issuecomment-625612511


   
   [![Coverage Status](https://coveralls.io/builds/30647704/badge)](https://coveralls.io/builds/30647704)
   
   Coverage remained the same at 90.123% when pulling **ce37f54b9b0b851917365f885723588bced31f9c on dota17:junit5WithExceptions** into **a3eb3be4b0063351115a02f56c884b31a6cc8bff on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] coveralls edited a comment on pull request #159: [WIP] Updated the fail() exceptions with Junit5.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #159:
URL: https://github.com/apache/commons-collections/pull/159#issuecomment-625612511


   
   [![Coverage Status](https://coveralls.io/builds/30827822/badge)](https://coveralls.io/builds/30827822)
   
   Coverage decreased (-0.03%) to 90.094% when pulling **ba399bdb12338ebbfb80076def2809ff10edfa5c on dota17:junit5WithExceptions** into **a3eb3be4b0063351115a02f56c884b31a6cc8bff on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] coveralls edited a comment on pull request #159: Updated the fail() exceptions with Junit5.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #159:
URL: https://github.com/apache/commons-collections/pull/159#issuecomment-625612511


   
   [![Coverage Status](https://coveralls.io/builds/31254268/badge)](https://coveralls.io/builds/31254268)
   
   Coverage decreased (-0.004%) to 90.119% when pulling **90b23d9e10a445efafa4cc61504f1e00901883c7 on dota17:junit5WithExceptions** into **de4b95a7c8f3b78174b7eccd1d6249c812695eea on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] coveralls edited a comment on pull request #159: [WIP]Updated the fail() exceptions with Junit5.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #159:
URL: https://github.com/apache/commons-collections/pull/159#issuecomment-625612511


   
   [![Coverage Status](https://coveralls.io/builds/30667303/badge)](https://coveralls.io/builds/30667303)
   
   Coverage remained the same at 90.123% when pulling **982c44de8b6649f6daeeab11fe9524d93eb10957 on dota17:junit5WithExceptions** into **a3eb3be4b0063351115a02f56c884b31a6cc8bff on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] coveralls edited a comment on pull request #159: [WIP] Updated the fail() exceptions with Junit5.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #159:
URL: https://github.com/apache/commons-collections/pull/159#issuecomment-625612511


   
   [![Coverage Status](https://coveralls.io/builds/30878206/badge)](https://coveralls.io/builds/30878206)
   
   Coverage increased (+0.003%) to 90.126% when pulling **da7b8bad6f02ff313bd8905f79e648c39c97b226 on dota17:junit5WithExceptions** into **a3eb3be4b0063351115a02f56c884b31a6cc8bff on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] coveralls edited a comment on pull request #159: [WIP]Updated the fail() exceptions with Junit5.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #159:
URL: https://github.com/apache/commons-collections/pull/159#issuecomment-625612511


   
   [![Coverage Status](https://coveralls.io/builds/30694819/badge)](https://coveralls.io/builds/30694819)
   
   Coverage decreased (-0.03%) to 90.094% when pulling **9b8c2448830578bc05f18cfb7b5979aef78d3687 on dota17:junit5WithExceptions** into **a3eb3be4b0063351115a02f56c884b31a6cc8bff on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] coveralls edited a comment on pull request #159: [WIP]Updated the fail() exceptions with Junit5.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #159:
URL: https://github.com/apache/commons-collections/pull/159#issuecomment-625612511


   
   [![Coverage Status](https://coveralls.io/builds/30688181/badge)](https://coveralls.io/builds/30688181)
   
   Coverage decreased (-0.03%) to 90.094% when pulling **57c1eda15d8c8d8e2f7536ff46731b14d9eb5ac3 on dota17:junit5WithExceptions** into **a3eb3be4b0063351115a02f56c884b31a6cc8bff on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] coveralls edited a comment on pull request #159: Updated the fail() exceptions with Junit5.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #159:
URL: https://github.com/apache/commons-collections/pull/159#issuecomment-625612511


   
   [![Coverage Status](https://coveralls.io/builds/30878803/badge)](https://coveralls.io/builds/30878803)
   
   Coverage increased (+0.03%) to 90.126% when pulling **b68fc69924f856779e4a93068214d9cca4e9c013 on dota17:junit5WithExceptions** into **9f37668d9243fc71178f0e94a2b560ef861a639a on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] coveralls edited a comment on pull request #159: Updated the fail() exceptions with Junit5.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #159:
URL: https://github.com/apache/commons-collections/pull/159#issuecomment-625612511


   
   [![Coverage Status](https://coveralls.io/builds/31061407/badge)](https://coveralls.io/builds/31061407)
   
   Coverage increased (+0.03%) to 90.119% when pulling **ccb7eab8d8a6f9a684ba67ce90869f3f7e26e4e2 on dota17:junit5WithExceptions** into **9f37668d9243fc71178f0e94a2b560ef861a639a on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] coveralls commented on pull request #159: [WIP]Updated the fail() exceptions with Junit5.

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #159:
URL: https://github.com/apache/commons-collections/pull/159#issuecomment-625612511


   
   [![Coverage Status](https://coveralls.io/builds/30643344/badge)](https://coveralls.io/builds/30643344)
   
   Coverage remained the same at 90.123% when pulling **19ddde7b42ea2e4dc4fa863e7faa1d39aefff57e on dota17:junit5WithExceptions** into **a3eb3be4b0063351115a02f56c884b31a6cc8bff on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] coveralls edited a comment on pull request #159: [WIP] Updated the fail() exceptions with Junit5.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #159:
URL: https://github.com/apache/commons-collections/pull/159#issuecomment-625612511


   
   [![Coverage Status](https://coveralls.io/builds/30827979/badge)](https://coveralls.io/builds/30827979)
   
   Coverage remained the same at 90.123% when pulling **edf5dde427b30de2e99986421ad816214310fbdc on dota17:junit5WithExceptions** into **a3eb3be4b0063351115a02f56c884b31a6cc8bff on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] dota17 commented on pull request #159: Updated the fail() exceptions with Junit5.

Posted by GitBox <gi...@apache.org>.
dota17 commented on pull request #159:
URL: https://github.com/apache/commons-collections/pull/159#issuecomment-636294209


   comparators/AbstractComparatorTest.java
   comparators/BooleanComparatorTest.java
   comparators/ComparatorChainTest.java
   comparators/FixedOrderComparatorTest.java
   comparators/ReverseComparatorTest.java
   iterators/BoundedIteratorTest.java
   iterators/PeekingIteratorTest.java
   iterators/PushbackIteratorTest.java
   iterators/SkippingIteratorTest.java
   keyvalue/AbstractMapEntryTest.java
   keyvalue/DefaultKeyValueTest.java
   keyvalue/DefaultMapEntryTest.java
   keyvalue/TiedMapEntryTest.java
   keyvalue/UnmodifiableMapEntryTest.java
   map/LazyMapTest.java
   map/LazySortedMapTest.java
   properties/AbstractPropertiesFactoryTest.java
   properties/PropertiesFactoryTest.java
   properties/SortedPropertiesFactoryTest.java
   
   org.junit.jupiter.api.Test was used as a drop in replacement for org.juit.Test without arguments. These Tests are with arguments, how to proceed?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] coveralls edited a comment on pull request #159: [WIP] Updated the fail() exceptions with Junit5.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #159:
URL: https://github.com/apache/commons-collections/pull/159#issuecomment-625612511


   
   [![Coverage Status](https://coveralls.io/builds/30803069/badge)](https://coveralls.io/builds/30803069)
   
   Coverage remained the same at 90.123% when pulling **d6ceca99057800cb7ed400fc54bcbd4f634f240f on dota17:junit5WithExceptions** into **a3eb3be4b0063351115a02f56c884b31a6cc8bff on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] coveralls edited a comment on pull request #159: [WIP] Updated the fail() exceptions with Junit5.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #159:
URL: https://github.com/apache/commons-collections/pull/159#issuecomment-625612511


   
   [![Coverage Status](https://coveralls.io/builds/30807650/badge)](https://coveralls.io/builds/30807650)
   
   Coverage remained the same at 90.123% when pulling **fba2d56ddae309913fc3549eac74664993a65ef2 on dota17:junit5WithExceptions** into **a3eb3be4b0063351115a02f56c884b31a6cc8bff on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] coveralls edited a comment on pull request #159: Updated the fail() exceptions with Junit5.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #159:
URL: https://github.com/apache/commons-collections/pull/159#issuecomment-625612511


   
   [![Coverage Status](https://coveralls.io/builds/33012844/badge)](https://coveralls.io/builds/33012844)
   
   Coverage decreased (-0.004%) to 90.123% when pulling **46ad29ebaeba698a92f576992adbc28cf0b89435 on dota17:junit5WithExceptions** into **cec45f826fad9e0eeccfcb1805300e75c4dfe5d2 on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] dota17 commented on pull request #159: Updated the fail() exceptions with Junit5.

Posted by GitBox <gi...@apache.org>.
dota17 commented on pull request #159:
URL: https://github.com/apache/commons-collections/pull/159#issuecomment-632060510


   > @dota17 The title says "WIP". Are you still working on it?
   
   Yes, I am. 
   If anyone has time to review, it would be really nice. ;-)
   
   Thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] coveralls edited a comment on pull request #159: [WIP]Updated the fail() exceptions with Junit5.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #159:
URL: https://github.com/apache/commons-collections/pull/159#issuecomment-625612511


   
   [![Coverage Status](https://coveralls.io/builds/30670308/badge)](https://coveralls.io/builds/30670308)
   
   Coverage remained the same at 90.123% when pulling **efbaf155668c7646e88c60c1a69dbd71ff6468fb on dota17:junit5WithExceptions** into **a3eb3be4b0063351115a02f56c884b31a6cc8bff on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] garydgregory commented on pull request #159: Updated the fail() exceptions with Junit5.

Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #159:
URL: https://github.com/apache/commons-collections/pull/159#issuecomment-1059196500


   I just merged a series of JUnit 5 PRs; if this PR still contains changes not covered in git master, please rebase, if not, please close it. TY!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] coveralls edited a comment on pull request #159: [WIP] Updated the fail() exceptions with Junit5.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #159:
URL: https://github.com/apache/commons-collections/pull/159#issuecomment-625612511


   
   [![Coverage Status](https://coveralls.io/builds/30857938/badge)](https://coveralls.io/builds/30857938)
   
   Coverage increased (+0.003%) to 90.126% when pulling **b0317fd71e29d73b1ed7676d94daedafb3293add on dota17:junit5WithExceptions** into **a3eb3be4b0063351115a02f56c884b31a6cc8bff on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org