You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celix.apache.org by "pnoltes (via GitHub)" <gi...@apache.org> on 2023/05/12 07:41:50 UTC
[PR] Hotfix/remove refresh bundle after uninstall (celix)
pnoltes opened a new pull request, #553:
URL: https://github.com/apache/celix/pull/553
This PR fixes an issue that the during bundle install a warning is printed that a bundle cannot be refreshed.
I removed the fw_bundleRefresh call, because it was only used in bundle uninstall and I see no reason to then refresh the bundle.
Also solves a issue that the dm infos gathering for also done for not active bundles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Hotfix/remove refresh bundle after uninstall (celix)
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #553:
URL: https://github.com/apache/celix/pull/553#issuecomment-1545334940
## [Codecov](https://app.codecov.io/gh/apache/celix/pull/553?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#553](https://app.codecov.io/gh/apache/celix/pull/553?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e7b53f5) into [master](https://app.codecov.io/gh/apache/celix/commit/fc18c65d66918b8223e85944b910f9c15776947b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fc18c65) will **increase** coverage by `0.22%`.
> The diff coverage is `99.70%`.
> :exclamation: Current head e7b53f5 differs from pull request most recent head c907d6a. Consider uploading reports for the commit c907d6a to get more accurate results
```diff
@@ Coverage Diff @@
## master #553 +/- ##
==========================================
+ Coverage 77.43% 77.66% +0.22%
==========================================
Files 226 229 +3
Lines 34639 34928 +289
==========================================
+ Hits 26824 27126 +302
+ Misses 7815 7802 -13
```
| [Impacted Files](https://app.codecov.io/gh/apache/celix/pull/553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [libs/framework/src/dm\_dependency\_manager\_impl.c](https://app.codecov.io/gh/apache/celix/pull/553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlicy9mcmFtZXdvcmsvc3JjL2RtX2RlcGVuZGVuY3lfbWFuYWdlcl9pbXBsLmM=) | `79.47% <93.33%> (-0.26%)` | :arrow_down: |
| [bundles/logging/log\_admin/src/celix\_log\_admin.c](https://app.codecov.io/gh/apache/celix/pull/553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9sb2dnaW5nL2xvZ19hZG1pbi9zcmMvY2VsaXhfbG9nX2FkbWluLmM=) | `99.76% <100.00%> (+0.02%)` | :arrow_up: |
| [bundles/logging/log\_helper/src/celix\_log\_helper.c](https://app.codecov.io/gh/apache/celix/pull/553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9sb2dnaW5nL2xvZ19oZWxwZXIvc3JjL2NlbGl4X2xvZ19oZWxwZXIuYw==) | `100.00% <100.00%> (ø)` | |
| [libs/framework/src/framework.c](https://app.codecov.io/gh/apache/celix/pull/553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlicy9mcmFtZXdvcmsvc3JjL2ZyYW1ld29yay5j) | `77.71% <100.00%> (+0.24%)` | :arrow_up: |
| [libs/rcm/src/celix\_capability.c](https://app.codecov.io/gh/apache/celix/pull/553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlicy9yY20vc3JjL2NlbGl4X2NhcGFiaWxpdHkuYw==) | `100.00% <100.00%> (ø)` | |
| [libs/rcm/src/celix\_requirement.c](https://app.codecov.io/gh/apache/celix/pull/553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlicy9yY20vc3JjL2NlbGl4X3JlcXVpcmVtZW50LmM=) | `100.00% <100.00%> (ø)` | |
| [libs/rcm/src/celix\_resource.c](https://app.codecov.io/gh/apache/celix/pull/553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlicy9yY20vc3JjL2NlbGl4X3Jlc291cmNlLmM=) | `100.00% <100.00%> (ø)` | |
... and [3 files with indirect coverage changes](https://app.codecov.io/gh/apache/celix/pull/553/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Hotfix/remove refresh bundle after uninstall (celix)
Posted by "pnoltes (via GitHub)" <gi...@apache.org>.
pnoltes merged PR #553:
URL: https://github.com/apache/celix/pull/553
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org