You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Alex Rudyy (JIRA)" <ji...@apache.org> on 2017/06/29 17:34:00 UTC

[jira] [Resolved] (QPID-7817) [Java Broker] [WebSocket] Websocket implementation must not assume that web socket frame contains a whole AMQP frame

     [ https://issues.apache.org/jira/browse/QPID-7817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Rudyy resolved QPID-7817.
------------------------------
    Resolution: Fixed

Changes look good to me

> [Java Broker] [WebSocket] Websocket implementation must not assume that web socket frame contains a whole AMQP frame
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-7817
>                 URL: https://issues.apache.org/jira/browse/QPID-7817
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>            Reporter: Keith Wall
>            Assignee: Keith Wall
>             Fix For: qpid-java-broker-7.0.0
>
>
> Currently the Java Broker's AMQP web socket implementation does not uphold all the following:
> Advanced Message Queuing Protocol (AMQP) WebSocket Binding (WSB) Version 1.0 Committee Specification 01 2.4 Exchanging AMQP Frames
> bq. There is no mapping between an AMQP frame and a WebSocket message. Therefore, a single AMQP frame MAY be split over one or more consecutive WebSocket messages. Conversely, a single WebSocket message MAY contain one or more AMQP frames. There is also no mapping between an AMQP frame and a WebSocket frame. Therefore, a single AMQP frame MAY be split over one or more consecutive WebSocket frames. Conversely, a single WebSocket frame MAY contain one or more AMQP frames.
> The current implementation will fail if a websocket frame arrives containing a partial AMQP frame.  Furthermore since, QPID-7763, internally WebSocketProvider chunks the incoming bytes into QBBs.  If this chunking results in a frame overlapping a chunk boundary, processing will fail. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org