You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2016/09/09 22:07:46 UTC
[kudu-CR] tool: rename tablet mode to local replica
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4355
to review the following change.
Change subject: tool: rename tablet mode to local_replica
......................................................................
tool: rename tablet mode to local_replica
The tablet mode isn't actually going away, we're just going to use it for
"remote operations that are scoped to an entire tablet".
Change-Id: I2022a49817bfa48b74c734fd849d92d1f15a697f
---
M docs/release_notes.adoc
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/integration-tests/master_migration-itest.cc
M src/kudu/tools/CMakeLists.txt
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action.h
R src/kudu/tools/tool_action_local_replica.cc
M src/kudu/tools/tool_main.cc
8 files changed, 17 insertions(+), 16 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/4355/1
--
To view, visit http://gerrit.cloudera.org:8080/4355
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2022a49817bfa48b74c734fd849d92d1f15a697f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] tool: rename tablet mode to local replica
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: tool: rename tablet mode to local_replica
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4355/1/src/kudu/integration-tests/master_migration-itest.cc
File src/kudu/integration-tests/master_migration-itest.cc:
Line 172: "copy",
> while we're on the renaming, perhaps we should name this 'copy_from_remote'
I'll change it to copy_from_remote.
http://gerrit.cloudera.org:8080/#/c/4355/1/src/kudu/tools/tool_action_local_replica.cc
File src/kudu/tools/tool_action_local_replica.cc:
Line 273: .Description("Operate on local Kudu replicas")
> add something like "directly on the filesystem" or "operate on Kudu replica
Sure.
--
To view, visit http://gerrit.cloudera.org:8080/4355
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2022a49817bfa48b74c734fd849d92d1f15a697f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] tool: rename tablet mode to local replica
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: tool: rename tablet mode to local_replica
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4355
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2022a49817bfa48b74c734fd849d92d1f15a697f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] tool: rename tablet mode to local replica
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: tool: rename tablet mode to local_replica
......................................................................
tool: rename tablet mode to local_replica
The tablet mode isn't actually going away, we're just going to use it for
"remote operations that are scoped to an entire tablet".
Change-Id: I2022a49817bfa48b74c734fd849d92d1f15a697f
Reviewed-on: http://gerrit.cloudera.org:8080/4355
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
---
M docs/release_notes.adoc
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/integration-tests/master_migration-itest.cc
M src/kudu/tools/CMakeLists.txt
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action.h
R src/kudu/tools/tool_action_local_replica.cc
M src/kudu/tools/tool_main.cc
8 files changed, 24 insertions(+), 23 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4355
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2022a49817bfa48b74c734fd849d92d1f15a697f
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] tool: rename tablet mode to local replica
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4355
to look at the new patch set (#2).
Change subject: tool: rename tablet mode to local_replica
......................................................................
tool: rename tablet mode to local_replica
The tablet mode isn't actually going away, we're just going to use it for
"remote operations that are scoped to an entire tablet".
Change-Id: I2022a49817bfa48b74c734fd849d92d1f15a697f
---
M docs/release_notes.adoc
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/integration-tests/master_migration-itest.cc
M src/kudu/tools/CMakeLists.txt
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action.h
R src/kudu/tools/tool_action_local_replica.cc
M src/kudu/tools/tool_main.cc
8 files changed, 24 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/4355/2
--
To view, visit http://gerrit.cloudera.org:8080/4355
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2022a49817bfa48b74c734fd849d92d1f15a697f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] tool: rename tablet mode to local replica
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: tool: rename tablet mode to local_replica
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4355/1/src/kudu/integration-tests/master_migration-itest.cc
File src/kudu/integration-tests/master_migration-itest.cc:
Line 172: "copy",
while we're on the renaming, perhaps we should name this 'copy_from_remote' or 'download_from_remote'?
http://gerrit.cloudera.org:8080/#/c/4355/1/src/kudu/tools/tool_action_local_replica.cc
File src/kudu/tools/tool_action_local_replica.cc:
Line 273: .Description("Operate on local Kudu replicas")
add something like "directly on the filesystem" or "operate on Kudu replicas via the local filesystem" or somesuch? something to make clear it's not via a running server.
--
To view, visit http://gerrit.cloudera.org:8080/4355
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2022a49817bfa48b74c734fd849d92d1f15a697f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] tool: rename tablet mode to local replica
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: tool: rename tablet mode to local_replica
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/3318/
--
To view, visit http://gerrit.cloudera.org:8080/4355
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2022a49817bfa48b74c734fd849d92d1f15a697f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] tool: rename tablet mode to local replica
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: tool: rename tablet mode to local_replica
......................................................................
Patch Set 2:
Build Started http://104.196.14.100/job/kudu-gerrit/3328/
--
To view, visit http://gerrit.cloudera.org:8080/4355
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2022a49817bfa48b74c734fd849d92d1f15a697f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No