[GitHub] [shardingsphere] sandynz commented on a diff in pull request #23906: Optimized CDC implementation with MySQL and PostgreSQL support

["sandynz (via GitHub)" <gi...@apache.org>]

sandynz commented on code in PR #23906:
URL: https://github.com/apache/shardingsphere/pull/23906#discussion_r1094217421


##########
kernel/data-pipeline/cdc/client/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/client/util/AnyValueConvert.java:
##########
@@ -98,7 +99,9 @@ public static Object convertToObject(final Any any) throws InvalidProtocolBuffer
         if (any.is(BlobValue.class)) {
             return any.unpack(BlobValue.class).getValue().toByteArray();
         }
-        return JsonFormat.printer().includingDefaultValueFields().print(any);
+        // can't use JsonFormat, might change the original value without error prompt. there need to cover more types,

Review Comment:
   Seems need add TODO



##########
proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/cdc/CDCBackendHandler.java:
##########
@@ -87,8 +87,9 @@ public CDCResponse createSubscription(final CDCRequest request) {
             return CDCResponseGenerator.failed(request.getRequestId(), CDCResponseErrorCode.SERVER_ERROR, "Not find sharding rule");
         }
         Map<String, List<DataNode>> actualDataNodesMap = new HashMap<>();
-        for (String each : tableNames) {
-            actualDataNodesMap.put(each, getActualDataNodes(shardingRule.get(), each));
+        // TODO need support case-insensitive later
+        for (TableName each : createSubscription.getTableNamesList()) {
+            actualDataNodesMap.put(each.getName(), getActualDataNodes(shardingRule.get(), each.getName()));
         }

Review Comment:
   Looks it's not completed. e.g.
   1, In ImporterFactory, only openGauss is handled
   2, Maybe more code blocks need to be handled, include cdc client
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org