You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ap...@apache.org on 2009/05/18 23:53:07 UTC

svn commit: r776109 - /hadoop/hbase/trunk_on_hadoop-0.18.3/src/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java

Author: apurtell
Date: Mon May 18 21:53:06 2009
New Revision: 776109

URL: http://svn.apache.org/viewvc?rev=776109&view=rev
Log:
more edits for HBASE-1401

Modified:
    hadoop/hbase/trunk_on_hadoop-0.18.3/src/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java

Modified: hadoop/hbase/trunk_on_hadoop-0.18.3/src/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
URL: http://svn.apache.org/viewvc/hadoop/hbase/trunk_on_hadoop-0.18.3/src/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java?rev=776109&r1=776108&r2=776109&view=diff
==============================================================================
--- hadoop/hbase/trunk_on_hadoop-0.18.3/src/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java (original)
+++ hadoop/hbase/trunk_on_hadoop-0.18.3/src/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java Mon May 18 21:53:06 2009
@@ -1387,11 +1387,10 @@
    * Data structure to hold a HMsg and retries count.
    */
   private static final class ToDoEntry {
-    protected volatile int tries;
+    protected final AtomicInteger tries = new AtomicInteger(0);
     protected final HMsg msg;
 
     ToDoEntry(final HMsg msg) {
-      this.tries = 0;
       this.msg = msg;
     }
   }
@@ -1486,9 +1485,9 @@
             if (ex instanceof IOException) {
               ex = RemoteExceptionHandler.checkIOException((IOException) ex);
             }
-            if(e != null && e.tries < numRetries) {
+            if(e != null && e.tries.get() < numRetries) {
               LOG.warn(ex);
-              e.tries++;
+              e.tries.incrementAndGet();
               try {
                 toDo.put(e);
               } catch (InterruptedException ie) {