[GitHub] [netbeans] sdedic commented on a diff in pull request #4176: External Code Formatters added into NBLS.

[GitBox <gi...@apache.org>]

sdedic commented on code in PR #4176:
URL: https://github.com/apache/netbeans/pull/4176#discussion_r890105911


##########
java/java.lsp.server/vscode/package-lock.json:
##########
@@ -9,8 +9,8 @@
 			"version": "0.1.0",
 			"license": "Apache 2.0",
 			"dependencies": {
+				"@vscode/debugadapter": "1.55.1",
 				"jsonc-parser": "3.0.0",
-				"vscode-debugadapter": "1.51.0",

Review Comment:
   Intentional change ?



##########
java/java.lsp.server/build.xml:
##########
@@ -42,8 +42,8 @@
         <chmod file="${lsp.build.dir}/platform/lib/nbexec" perm="u+x"/>
         <chmod file="${lsp.build.dir}/java/maven/bin/mvn" perm="u+x" />
 
-        <property name="3rdparty.modules" value=".*nbjavac.*"/>
-        <autoupdate todir="${lsp.build.dir}/extra" updatecenter="file://${nb_all}/nb/updatecenters/build/classes/org/netbeans/modules/updatecenters/resources/3rdparty-catalog.xml">

Review Comment:
   Hm, doesn't this require that the build only happens online ... if so, any idea how it could reuse once downloaded info or disable the external fetch for a routine development build ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists