[jira] Commented: (XMLRPC-85) CLONE -Patch to allow protocol://user:password@host.domain.tld urls to be supplied to XmlRpcClient

["Danny Angus (JIRA)" <xm...@ws.apache.org>]

    [ http://issues.apache.org/jira/browse/XMLRPC-85?page=comments#action_12413091 ] 

Danny Angus commented on XMLRPC-85:
-----------------------------------

After discussion with users and a look at mail archives it would appear that this patch, had it been applied, would have resolved a number of users' issues. There is also still support for having it applied by users on the users list.

XMLRPC-27 has been closed so I am opening this clone to request that this patch actually be applied and not discarded.


Index: XmlRpcClient.java
===================================================================
RCS file: /home/cvspublic/xml-rpc/src/java/org/apache/xmlrpc/XmlRpcClient.java,v
retrieving revision 1.14
diff -u -r1.14 XmlRpcClient.java
--- XmlRpcClient.java	21 Nov 2002 01:28:16 -0000	1.14
+++ XmlRpcClient.java	26 Nov 2002 12:18:20 -0000
@@ -97,6 +97,15 @@
     public XmlRpcClient(URL url)
     {
         this.url = url;
+        if(url.getUserInfo()!=null){
+            String user = url.getUserInfo();
+            int split = user.indexOf(':');
+            if (split > -1){
+                this.setBasicAuthentication(user.substring(0,split), user.substring(split+1));
+            }else{
+                this.setBasicAuthentication(user,"");
+            }
+        }        
         if (XmlRpc.debug)
         {
             System.out.println("Created client to url space " + url);


> CLONE -Patch to allow protocol://user:password@host.domain.tld urls to be supplied to XmlRpcClient
> --------------------------------------------------------------------------------------------------
>
>          Key: XMLRPC-85
>          URL: http://issues.apache.org/jira/browse/XMLRPC-85
>      Project: XML-RPC
>         Type: Bug

>   Components: Source
>     Versions: 1.2
>  Environment: Operating System: Other
> Platform: Other
>     Reporter: Danny Angus

>
> I submitted a patch to the dev list in december, it appears to have been 
> forgotten.
> See: http://nagoya.apache.org/eyebrowse/ReadMsg?listName=rpc-
> dev@xml.apache.org&msgNo=530

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: xmlrpc-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: xmlrpc-dev-help@ws.apache.org