You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/08/03 21:00:58 UTC
[GitHub] [camel-quarkus] ppalaga opened a new pull request #2982: Polish dependency management
ppalaga opened a new pull request #2982:
URL: https://github.com/apache/camel-quarkus/pull/2982
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga merged pull request #2982: Polish dependency management
Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #2982:
URL: https://github.com/apache/camel-quarkus/pull/2982
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on a change in pull request #2982: Polish dependency management
Posted by GitBox <gi...@apache.org>.
aldettinger commented on a change in pull request #2982:
URL: https://github.com/apache/camel-quarkus/pull/2982#discussion_r682450388
##########
File path: extensions-support/reactor-netty/runtime/pom.xml
##########
@@ -62,6 +62,12 @@
<dependency>
<groupId>io.projectreactor.netty</groupId>
<artifactId>reactor-netty</artifactId>
+ <exclusions>
+ <exclusion>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-resolver-dns-native-macos</artifactId>
Review comment:
ok, thanks for explanation :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #2982: Polish dependency management
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #2982:
URL: https://github.com/apache/camel-quarkus/pull/2982#discussion_r682400679
##########
File path: extensions-support/reactor-netty/runtime/pom.xml
##########
@@ -62,6 +62,12 @@
<dependency>
<groupId>io.projectreactor.netty</groupId>
<artifactId>reactor-netty</artifactId>
+ <exclusions>
+ <exclusion>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-resolver-dns-native-macos</artifactId>
Review comment:
Yeah, my assumption is that this native resolver artifact does not help in GraalVM native mode anyway and that there is some plain java fallback. That's why I asked @ffang to check on his Mac.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on a change in pull request #2982: Polish dependency management
Posted by GitBox <gi...@apache.org>.
aldettinger commented on a change in pull request #2982:
URL: https://github.com/apache/camel-quarkus/pull/2982#discussion_r682394186
##########
File path: extensions-support/reactor-netty/runtime/pom.xml
##########
@@ -62,6 +62,12 @@
<dependency>
<groupId>io.projectreactor.netty</groupId>
<artifactId>reactor-netty</artifactId>
+ <exclusions>
+ <exclusion>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-resolver-dns-native-macos</artifactId>
Review comment:
So, we are disabling netty dns resolvers on mac O/S ? Or maybe there is a kind of non native fallback dns ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #2982: Polish dependency management
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #2982:
URL: https://github.com/apache/camel-quarkus/pull/2982#issuecomment-892165745
@ffang could you please check if `camel-quarkus-integration-test-azure-storage-blob` and `camel-quarkus-integration-test-azure-storage-queue` pass for you on Mac (incl. native mode) after this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org