You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/15 05:27:45 UTC
[GitHub] [airflow] dimberman opened a new pull request #13080: KubernetesExecutor overrides should only append to lists
dimberman opened a new pull request #13080:
URL: https://github.com/apache/airflow/pull/13080
This PR makes 1.10 interaction more similar to that of Airflow 2.0.
Essentially users are able to override values that are in maps, but when
it comes to lists in k8s objects, it is too complicated to consistently
override.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13080: KubernetesExecutor overrides should only append to lists
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13080:
URL: https://github.com/apache/airflow/pull/13080#issuecomment-745095464
[The Workflow run](https://github.com/apache/airflow/actions/runs/422462347) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman commented on a change in pull request #13080: KubernetesExecutor overrides should only append to lists
Posted by GitBox <gi...@apache.org>.
dimberman commented on a change in pull request #13080:
URL: https://github.com/apache/airflow/pull/13080#discussion_r543544646
##########
File path: airflow/kubernetes/pod_generator.py
##########
@@ -501,14 +505,18 @@ def reconcile_containers(base_containers,
client_container = client_containers[0]
base_container = base_containers[0]
client_container = extend_object_field(
- base_container,
- client_container,
- 'volume_mounts',
- 'mount_path')
Review comment:
Hi @potiuk this removal is deliberate as that is how it is treated in 2.0. 2.0 only allows appends to lists. I believe this actually wroks out nicely as when there are multiple of hte same value k8s will just take the last value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #13080: KubernetesExecutor overrides should only append to lists
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #13080:
URL: https://github.com/apache/airflow/pull/13080
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #13080: KubernetesExecutor overrides should only append to lists
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #13080:
URL: https://github.com/apache/airflow/pull/13080#discussion_r543188413
##########
File path: airflow/kubernetes/pod_generator.py
##########
@@ -501,14 +505,18 @@ def reconcile_containers(base_containers,
client_container = client_containers[0]
base_container = base_containers[0]
client_container = extend_object_field(
- base_container,
- client_container,
- 'volume_mounts',
- 'mount_path')
Review comment:
Is this 'mount_path' removal deliberate?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #13080: KubernetesExecutor overrides should only append to lists
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #13080:
URL: https://github.com/apache/airflow/pull/13080#discussion_r574112781
##########
File path: airflow/kubernetes/pod_generator.py
##########
@@ -50,21 +49,15 @@ class PodDefaults(object):
def __init__(self):
pass
- XCOM_MOUNT_PATH = '/airflow/xcom'
- SIDECAR_CONTAINER_NAME = 'airflow-xcom-sidecar'
+ XCOM_MOUNT_PATH = "/airflow/xcom"
Review comment:
Can you remove the unrelated changes please -- so it will be easier to just check the changes now and in future too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman commented on pull request #13080: KubernetesExecutor overrides should only append to lists
Posted by GitBox <gi...@apache.org>.
dimberman commented on pull request #13080:
URL: https://github.com/apache/airflow/pull/13080#issuecomment-776910480
@kaxil PTAL
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #13080: KubernetesExecutor overrides should only append to lists
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #13080:
URL: https://github.com/apache/airflow/pull/13080#discussion_r543567680
##########
File path: airflow/kubernetes/pod_generator.py
##########
@@ -501,14 +505,18 @@ def reconcile_containers(base_containers,
client_container = client_containers[0]
base_container = base_containers[0]
client_container = extend_object_field(
- base_container,
- client_container,
- 'volume_mounts',
- 'mount_path')
Review comment:
Will that cause any more regression to the current behaviour from 1.10.11 / 1.10.12?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman commented on a change in pull request #13080: KubernetesExecutor overrides should only append to lists
Posted by GitBox <gi...@apache.org>.
dimberman commented on a change in pull request #13080:
URL: https://github.com/apache/airflow/pull/13080#discussion_r543661706
##########
File path: airflow/kubernetes/pod_generator.py
##########
@@ -501,14 +505,18 @@ def reconcile_containers(base_containers,
client_container = client_containers[0]
base_container = base_containers[0]
client_container = extend_object_field(
- base_container,
- client_container,
- 'volume_mounts',
- 'mount_path')
Review comment:
@kaxil it shouldn't cause any regressions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13080: KubernetesExecutor overrides should only append to lists
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13080:
URL: https://github.com/apache/airflow/pull/13080#issuecomment-774282126
[The Workflow run](https://github.com/apache/airflow/actions/runs/541571186) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13080: KubernetesExecutor overrides should only append to lists
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13080:
URL: https://github.com/apache/airflow/pull/13080#issuecomment-745511913
[The Workflow run](https://github.com/apache/airflow/actions/runs/423993450) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13080: KubernetesExecutor overrides should only append to lists
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13080:
URL: https://github.com/apache/airflow/pull/13080#issuecomment-745169082
Does it look like 1.10.15 :) ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13080: KubernetesExecutor overrides should only append to lists
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13080:
URL: https://github.com/apache/airflow/pull/13080#issuecomment-808821165
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org