You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "chiacyu (via GitHub)" <gi...@apache.org> on 2024/07/24 07:14:59 UTC
[PR] KAFKA-17177: reviewers.py should grep "authors" to offer more candidates of reviewers information [kafka]
chiacyu opened a new pull request, #16674:
URL: https://github.com/apache/kafka/pull/16674
As title, this pull request add grep author to get more information.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17177: reviewers.py should grep "authors" to offer more candidates of reviewers information [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #16674:
URL: https://github.com/apache/kafka/pull/16674#issuecomment-2247246821
@chiacyu Do you test it on your local? The following error happens on my local
```
/home/chia7712/project/kafka/./reviewers.py:41: SyntaxWarning: invalid escape sequence '\|'
stream = os.popen("git log | grep 'Reviewers\|Author'")
/home/chia7712/project/kafka/./reviewers.py:52: SyntaxWarning: invalid escape sequence '\s'
m = re.match("(?P<name>.*)\s<(?P<email>.*)>", item[0])
Utility to help generate 'Reviewers' string for Pull Requests. Use Ctrl+D or Ctrl+C to exit
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17177: reviewers.py should grep "authors" to offer more candidates of reviewers information [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #16674:
URL: https://github.com/apache/kafka/pull/16674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17177: reviewers.py should grep "authors" to offer more candidates of reviewers information [kafka]
Posted by "chiacyu (via GitHub)" <gi...@apache.org>.
chiacyu commented on PR #16674:
URL: https://github.com/apache/kafka/pull/16674#issuecomment-2247293196
Let me check that, thanks for the reminder and also could you please share what you typed into the prompt to cause it @chia7712 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17177: reviewers.py should grep "authors" to offer more candidates of reviewers information [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #16674:
URL: https://github.com/apache/kafka/pull/16674#issuecomment-2249926709
@chiacyu could you please fix line#53 also?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17177: reviewers.py should grep "authors" to offer more candidates of reviewers information [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #16674:
URL: https://github.com/apache/kafka/pull/16674#issuecomment-2247324263
> Let me check that, thanks for the reminder and also could you please share what you typed into the prompt to cause it
`./reviewers.py`
BTW, it seems to me the simple fix is to add `r` to make raw string instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org