You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Pengyu Nie (Jira)" <ji...@apache.org> on 2020/03/28 21:24:00 UTC

[jira] [Closed] (COLLECTIONS-737) The test FluentIterableTest.size should be split

     [ https://issues.apache.org/jira/browse/COLLECTIONS-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pengyu Nie closed COLLECTIONS-737.
----------------------------------

Verified as complete. Thanks!

> The test FluentIterableTest.size should be split
> ------------------------------------------------
>
>                 Key: COLLECTIONS-737
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-737
>             Project: Commons Collections
>          Issue Type: Test
>          Components: Collection
>    Affects Versions: 4.4
>            Reporter: Pengyu Nie
>            Assignee: Bruno P. Kinoshita
>            Priority: Major
>             Fix For: 4.5
>
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> The first part of FluentIterableTest.size is not testing function
> FluentIterable.size (see code copied below). Actually,
> FluentIterable.size will not be invoked at all, because
> FluentIterable.of(null) will throw an NPE before that. This part
> should be extracted as a separate unit test like
> FluentIterableTest.ofNull.
> {code:java}
> try {
>     FluentIterable.of((Iterable<?>) null).size();
>     fail("expecting NullPointerException");
> } catch (final NullPointerException npe) {
>     // expected
> }{code}
> I'll create a pull request for this issue.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)