You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2020/05/07 15:42:23 UTC

[Impala-ASF-CR] IMPALA-9731: Remove USE CDP HIVElse and Hive 2 support

Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15869

Change subject: IMPALA-9731: Remove USE_CDP_HIVE=false and Hive 2 support
......................................................................

IMPALA-9731: Remove USE_CDP_HIVE=false and Hive 2 support

Impala 4 moved to using CDP versions for components, which involves
adopting Hive 3. This removes the old code supporting CDH components
and Hive 2. Specifically, it does the following:
1. Remove USE_CDP_HIVE and default to the values from USE_CDP_HIVE=true.
USE_CDP_HIVE now has no effect on the Impala environment. This also
means that bin/jenkins/build-all-flag-combinations.sh no longer
include USE_CDP_HIVE=false as a configuration.
2. Remove USE_CDH_KUDU and default to getting Impala from the
native toolchain.
3. Ban IMPALA_HIVE_MAJOR_VERSION<3 and remove related code, including
the IMPALA_HIVE_MAJOR_VERSION=2 maven profile in fe/pom.xml.

There is a fair amount of code that still references the Hive major
version. Upstream Hive is now working on Hive 4, so there is a high
likelihood that we'll need some code to deal with that transition.
This leaves some code (such as maven profiles) and test logic in
place.

Change-Id: Id85e849beaf4e19dda4092874185462abd2ec608
---
M README-build.md
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M fe/pom.xml
D fe/src/compat-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
D fe/src/compat-hive-2/java/org/apache/impala/compat/MetastoreShim.java
M testdata/bin/create-load-data.sh
M testdata/bin/run-hive-server.sh
M testdata/cluster/admin
M testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.py
11 files changed, 81 insertions(+), 1,108 deletions(-)

git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/15869/3
--
To view, visit http://gerrit.cloudera.org:8080/15869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id85e849beaf4e19dda4092874185462abd2ec608
Gerrit-Change-Number: 15869
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-9731: Remove USE CDP HIVElse and Hive 2 support

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15869 )

Change subject: IMPALA-9731: Remove USE_CDP_HIVE=false and Hive 2 support
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id85e849beaf4e19dda4092874185462abd2ec608
Gerrit-Change-Number: 15869
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 May 2020 22:14:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9731: Remove USE CDP HIVElse and Hive 2 support

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15869 )

Change subject: IMPALA-9731: Remove USE_CDP_HIVE=false and Hive 2 support
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id85e849beaf4e19dda4092874185462abd2ec608
Gerrit-Change-Number: 15869
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 May 2020 16:23:25 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9731: Remove USE CDP HIVElse and Hive 2 support

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15869 )

Change subject: IMPALA-9731: Remove USE_CDP_HIVE=false and Hive 2 support
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5994/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id85e849beaf4e19dda4092874185462abd2ec608
Gerrit-Change-Number: 15869
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 May 2020 16:11:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9731: Remove USE CDP HIVElse and Hive 2 support

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15869 )

Change subject: IMPALA-9731: Remove USE_CDP_HIVE=false and Hive 2 support
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id85e849beaf4e19dda4092874185462abd2ec608
Gerrit-Change-Number: 15869
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 May 2020 16:59:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9731: Remove USE CDP HIVElse and Hive 2 support

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15869 )

Change subject: IMPALA-9731: Remove USE_CDP_HIVE=false and Hive 2 support
......................................................................

IMPALA-9731: Remove USE_CDP_HIVE=false and Hive 2 support

Change-Id: Id85e849beaf4e19dda4092874185462abd2ec608
Reviewed-on: http://gerrit.cloudera.org:8080/15869
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M README-build.md
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
M fe/pom.xml
D fe/src/compat-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java
D fe/src/compat-hive-2/java/org/apache/impala/compat/MetastoreShim.java
M testdata/bin/create-load-data.sh
M testdata/bin/run-hive-server.sh
M testdata/cluster/admin
M testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.py
11 files changed, 81 insertions(+), 1,108 deletions(-)

Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/15869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id85e849beaf4e19dda4092874185462abd2ec608
Gerrit-Change-Number: 15869
Gerrit-PatchSet: 5
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9731: Remove USE CDP HIVElse and Hive 2 support

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.

Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15869 )

Change subject: IMPALA-9731: Remove USE_CDP_HIVE=false and Hive 2 support
......................................................................


Patch Set 3:

GVO failure is IMPALA-9729, not related to this.


-- 
To view, visit http://gerrit.cloudera.org:8080/15869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id85e849beaf4e19dda4092874185462abd2ec608
Gerrit-Change-Number: 15869
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 May 2020 15:42:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9731: Remove USE CDP HIVElse and Hive 2 support

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15869 )

Change subject: IMPALA-9731: Remove USE_CDP_HIVE=false and Hive 2 support
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5782/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/15869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id85e849beaf4e19dda4092874185462abd2ec608
Gerrit-Change-Number: 15869
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 May 2020 16:59:44 +0000
Gerrit-HasComments: No