You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2018/04/23 22:23:19 UTC
Review Request 66769: Fixed flaky
ReconciliationTest.ReconcileStatusUpdateTaskState.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66769/
-----------------------------------------------------------
Review request for mesos, Andrei Budnik, Alexander Rukletsov, and Megha Sharma.
Bugs: MESOS-8618
https://issues.apache.org/jira/browse/MESOS-8618
Repository: mesos
Description
-------
To simulate a master failover we need to use `replicated_log` as the
registry otherwiser the master loses persisted info about the agents.
Diffs
-----
src/tests/reconciliation_tests.cpp b06244b5f3efad3a88e367cd8e26cebd3d9f2e43
Diff: https://reviews.apache.org/r/66769/diff/1/
Testing
-------
Make check.
Thanks,
Jiang Yan Xu
Re: Review Request 66769: Fixed flaky
ReconciliationTest.ReconcileStatusUpdateTaskState.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66769/#review201806
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['66769']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66769
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66769/logs/mesos-tests-stdout.log):
```
[ RUN ] ContentType/SchedulerTest.OperationFeedbackValidationNoResourceProviderCapability/1
[ OK ] ContentType/SchedulerTest.OperationFeedbackValidationNoResourceProviderCapability/1 (14582 ms)
[ RUN ] ContentType/SchedulerTest.OperationFeedbackValidationSchedulerDriverFramework/0
[ OK ] ContentType/SchedulerTest.OperationFeedbackValidationSchedulerDriverFramework/0 (14634 ms)
[ RUN ] ContentType/SchedulerTest.OperationFeedbackValidationSchedulerDriverFramework/1
[ OK ] ContentType/SchedulerTest.OperationFeedbackValidationSchedulerDriverFramework/1 (14614 ms)
[ RUN ] ContentType/SchedulerTest.ShutdownExecutor/0
[ OK ] ContentType/SchedulerTest.ShutdownExecutor/0 (14296 ms)
[ RUN ] ContentType/SchedulerTest.ShutdownExecutor/1
[ OK ] ContentType/SchedulerTest.ShutdownExecutor/1 (14701 ms)
[ RUN ] ContentType/SchedulerTest.Decline/0
[ OK ] ContentType/SchedulerTest.Decline/0 (14596 ms)
[ RUN ] ContentType/SchedulerTest.Decline/1
[ OK ] ContentType/SchedulerTest.Decline/1 (14588 ms)
[ RUN ] ContentType/SchedulerTest.Revive/0
[ OK ] ContentType/SchedulerTest.Revive/0 (14445 ms)
[ RUN ] ContentType/SchedulerTest.Revive/1
[ OK ] ContentType/SchedulerTest.Revive/1 (14773 ms)
[ RUN ] ContentType/SchedulerTest.Suppress/0
[ OK ] ContentType/SchedulerTest.Suppress/0 (14383 ms)
[ RUN ] ContentType/SchedulerTest.Suppress/1
[ OK ] ContentType/SchedulerTest.Suppress/1 (14499 ms)
[ RUN ] ContentType/SchedulerTest.NoOffersWithAllRolesSuppressed/0
[ OK ] ContentType/SchedulerTest.NoOffersWithAllRolesSuppressed/0 (19771 ms)
[ RUN ] ContentType/SchedulerTest.NoOffersWithAllRolesSuppressed/1
[ OK ] ContentType/SchedulerTest.NoOffersWithAllRolesSuppressed/1 (19163 ms)
[ RUN ] ContentType/SchedulerTest.NoOffersOnReregistrationWithAllRolesSuppressed/0
[ OK ] ContentType/SchedulerTest.NoOffersOnReregistrationWithAllRolesSuppressed/0 (19115 ms)
[ RUN ] ContentType/SchedulerTest.NoOffersOnReregistrationWithAllRolesSuppressed/1
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66769/logs/mesos-tests-stderr.log):
```
I0424 02:07:55.174295 5316 master.cpp:515] Master only allowing authenticated frameworks to register
I0424 02:07:55.174295 5316 master.cpp:521] Master only allowing authenticated agents to register
I0424 02:07:55.174295 5316 master.cpp:527] Master only allowing authenticated HTTP frameworks to register
I0424 02:07:55.175309 5316 credentials.hpp:37] Loading credentials for authentication from 'C:\Users\mesos\AppData\Local\Temp\v9N7gu\credentials'
I0424 02:07:55.176336 5316 master.cpp:571] Using default 'crammd5' authenticator
I0424 02:07:55.177335 5316 http.cpp:959] Creating default 'basic' HTTP authenticator for realm 'mesos-master-readonly'
I0424 02:07:55.178337 5316 http.cpp:959] Creating default 'basic' HTTP authenticator for realm 'mesos-master-readwrite'
I0424 02:07:55.178337 5316 http.cpp:959] Creating default 'basic' HTTP authenticator for realm 'mesos-master-scheduler'
I0424 02:07:55.179302 5316 master.cpp:652] Authorization enabled
I0424 02:07:55.190335 9356 master.cpp:2127] Elected as the leading master!
I0424 02:07:55.190335 9356 master.cpp:1683] Recovering from registrar
I0424 02:07:55.192330 11052 registrar.cpp:383] Successfully fetched the registry (0B) in 995072ns
I0424 02:07:55.192330 11052 registrar.cpp:487] Applied 1 operations in 0ns; attempting to update the registry
I0424 02:07:55.195006 10084 registrar.cpp:544] Successfully updated the registry in 1.068032ms
I0424 02:07:55.195006 10084 registrar.cpp:416] Successfully recovered registrar
I0424 02:07:55.195991 8460 master.cpp:1797] Recovered 0 agents from the registry (139B); allowing 10mins for agents to reregister
W0424 02:07:59.792044 4876 process.cpp:2821] Attempted to spawn already running process files@172.27.128.1:56750
I0424 02:07:59.794049 4876 containerizer.cpp:296] Using isolation { windows/cpu, filesystem/windows, windows/mem, environment_secret }
I0424 02:07:59.797027 4876 provisioner.cpp:299] Using default backend 'copy'
I0424 02:07:59.803056 4876 cluster.cpp:460] Creating default 'local' authorizer
I0424 02:07:59.810024 15748 slave.cpp:261] Mesos agent started on (420)@172.27.128.1:56750
I0424 02:07:59.810024 15748 slave.cpp:262] Flags at startup: --acls="" --appc_simple_discovery_uri_prefix="http://" --appc_store_dir="C:\Users\mesos\AppData\Local\Temp\rM4djq\store\appc" --authenticate_http_executors="true" --authenticate_http_readonly="true" --authenticate_http_readwrite="true" --authenticatee="crammd5" --authentication_backoff_factor="1secs" --authorizer="local" --container_disk_watch_interval="15secs" --containerizers="mesos" --credential="C:\Users\mesos\AppData\Local\Temp\rM4djq\credential" --default_role="*" --disk_watch_interval="1mins" --docker="docker" --docker_kill_orphans="true" --docker_registry="https://registry-1.docker.io" --docker_remove_delay="6hrs" --docker_socket="//./pipe/docker_engine" --docker_stop_timeout="0ns" --docker_store_dir="C:\Users\mesos\AppData\Local\Temp\rM4djq\store\docker" --docker_volume_checkpoint_dir="/var/run/mesos/isolators/docker/volume" --enforce_container_disk_quota="false" --executor_registration_timeout="1mins" --executor_r
eregistration_timeout="2secs" --executor_shutdown_grace_period="5secs" --fetcher_cache_dir="C:\Users\mesos\AppData\Local\Temp\rM4djq\fetch" --fetcher_cache_size="2GB" --fetcher_stall_timeout="1mins" --frameworks_home="" --gc_delay="1weeks" --gc_disk_headroom="0.1" --hadoop_home="" --help="false" --hostname_lookup="true" --http_command_executor="false" --http_credentials="C:\Users\mesos\AppData\Local\Temp\rM4djq\http_credentials" --http_heartbeat_interval="30secs" --initialize_driver_logging="true" --isolation="windows/cpu,windows/mem" --jwt_secret_key="C:\Users\mesos\AppData\Local\Temp\rM4djq\jwt_secret_key" --launcher="windows" --launcher_dir="D:\DCOS\mesos\src" --logbufsecs="0" --logging_level="INFO" --max_completed_executors_per_framework="150" --memory_profiling="false" --oversubscribed_resources_interval="15secs" --port="5051" --qos_correction_interval_min="0ns" --quiet="false" --reconfiguration_policy="equal" --recover="reconnect" --recovery_timeout="15mins" --registration_bac
koff_factor="10ms" --resources="cpus:4;gpus:0;mem:2048;disk:1024;ports:[31000-32000]" --runtime_dir="C:\Users\mesos\AppData\Local\Temp\rM4djq" --sandbox_directory="C:\mesos\sandbox" --strict="true" --version="false" --work_dir="C:\Users\mesos\AppData\Local\Temp\1Q8aoD" --zk_session_timeout="10secs"
I0424 02:07:59.814028 15748 credentials.hpp:86] Loading credential for authentication from 'C:\Users\mesos\AppData\Local\Temp\rM4djq\credential'
I0424 02:07:59.814028 15748 slave.cpp:294] Agent using credential for: test-principal
I0424 02:07:59.814028 15748 credentials.hpp:37] Loading credentials for authentication from 'C:\Users\mesos\AppData\Local\Temp\rM4djq\http_credentials'
I0424 02:07:59.816025 15748 http.cpp:959] Creating default 'basic' HTTP authenticator for realm 'mesos-agent-executor'
I0424 02:07:59.817026 15748 http.cpp:980] Creating default 'jwt' HTTP authenticator for realm 'mesos-agent-executor'
I0424 02:07:59.817026 15748 http.cpp:959] Creating default 'basic' HTTP authenticator for realm 'mesos-agent-readonly'
I0424 02:07:59.818018 15748 http.cpp:980] Creating default 'jwt' HTTP authenticator for realm 'mesos-agent-readonly'
I0424 02:07:59.819018 15748 http.cpp:959] Cre```
- Mesos Reviewbot Windows
On April 23, 2018, 10:23 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66769/
> -----------------------------------------------------------
>
> (Updated April 23, 2018, 10:23 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Alexander Rukletsov, and Megha Sharma.
>
>
> Bugs: MESOS-8618
> https://issues.apache.org/jira/browse/MESOS-8618
>
>
> Repository: mesos
>
>
> Description
> -------
>
> To simulate a master failover we need to use `replicated_log` as the
> registry otherwise the master loses persisted info about the agents.
>
>
> Diffs
> -----
>
> src/tests/reconciliation_tests.cpp b06244b5f3efad3a88e367cd8e26cebd3d9f2e43
>
>
> Diff: https://reviews.apache.org/r/66769/diff/1/
>
>
> Testing
> -------
>
> Make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 66769: Fixed flaky
ReconciliationTest.ReconcileStatusUpdateTaskState.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66769/#review201807
-----------------------------------------------------------
Patch looks great!
Reviews applied: [66769]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 23, 2018, 10:23 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66769/
> -----------------------------------------------------------
>
> (Updated April 23, 2018, 10:23 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Alexander Rukletsov, and Megha Sharma.
>
>
> Bugs: MESOS-8618
> https://issues.apache.org/jira/browse/MESOS-8618
>
>
> Repository: mesos
>
>
> Description
> -------
>
> To simulate a master failover we need to use `replicated_log` as the
> registry otherwise the master loses persisted info about the agents.
>
>
> Diffs
> -----
>
> src/tests/reconciliation_tests.cpp b06244b5f3efad3a88e367cd8e26cebd3d9f2e43
>
>
> Diff: https://reviews.apache.org/r/66769/diff/1/
>
>
> Testing
> -------
>
> Make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 66769: Fixed flaky
ReconciliationTest.ReconcileStatusUpdateTaskState.
Posted by Megha Sharma <ms...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66769/#review201944
-----------------------------------------------------------
Ship it!
Ship It!
- Megha Sharma
On April 23, 2018, 10:23 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66769/
> -----------------------------------------------------------
>
> (Updated April 23, 2018, 10:23 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Alexander Rukletsov, and Megha Sharma.
>
>
> Bugs: MESOS-8618
> https://issues.apache.org/jira/browse/MESOS-8618
>
>
> Repository: mesos
>
>
> Description
> -------
>
> To simulate a master failover we need to use `replicated_log` as the
> registry otherwise the master loses persisted info about the agents.
>
>
> Diffs
> -----
>
> src/tests/reconciliation_tests.cpp b06244b5f3efad3a88e367cd8e26cebd3d9f2e43
>
>
> Diff: https://reviews.apache.org/r/66769/diff/1/
>
>
> Testing
> -------
>
> Make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 66769: Fixed flaky
ReconciliationTest.ReconcileStatusUpdateTaskState.
Posted by Andrei Budnik <ab...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66769/#review201924
-----------------------------------------------------------
Ship it!
Ship It!
- Andrei Budnik
On April 23, 2018, 10:23 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66769/
> -----------------------------------------------------------
>
> (Updated April 23, 2018, 10:23 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Alexander Rukletsov, and Megha Sharma.
>
>
> Bugs: MESOS-8618
> https://issues.apache.org/jira/browse/MESOS-8618
>
>
> Repository: mesos
>
>
> Description
> -------
>
> To simulate a master failover we need to use `replicated_log` as the
> registry otherwise the master loses persisted info about the agents.
>
>
> Diffs
> -----
>
> src/tests/reconciliation_tests.cpp b06244b5f3efad3a88e367cd8e26cebd3d9f2e43
>
>
> Diff: https://reviews.apache.org/r/66769/diff/1/
>
>
> Testing
> -------
>
> Make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>